From: Pavel Machek <pavel@ucw.cz>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] regulator: bd9571mwv: Document "backup_mode" sysfs file
Date: Sun, 15 Jul 2018 18:59:26 +0200 [thread overview]
Message-ID: <20180715165926.GB10023@amd> (raw)
In-Reply-To: <20180713154720.18316-4-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Fri 2018-07-13 17:47:20, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> + following steps must be followed exactly:
> + 1. Configure PMIC for backup mode, to change the role of
> + the accessory power switch from a power switch to a
> + wake-up switch,
> + 2. Switch accessory power switch off, to prepare for
> + system suspend, which is a manual step not controlled
> + by software,
> + 3. Suspend system,
> + 4. Switch accessory power switch on, to resume the
> + system.
> + DDR Backup Mode must be explicitly enabled by the user,
> + to invoke step 1.
I'd add "please don't design hardware like that" :-). Anyway,
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-07-15 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 15:47 [PATCH v3 0/3] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
2018-07-13 15:47 ` [PATCH v3 1/3] regulator: bd9571mwv: Use "backup_mode" sysfs file instead of "wake_up" Geert Uytterhoeven
2018-07-13 20:08 ` Geert Uytterhoeven
2018-07-13 15:47 ` [PATCH v3 2/3] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
2018-07-13 15:47 ` [PATCH v3 3/3] regulator: bd9571mwv: Document "backup_mode" sysfs file Geert Uytterhoeven
2018-07-15 16:59 ` Pavel Machek [this message]
2018-07-15 16:57 ` [PATCH v3 0/3] regulator: bd9571mwv: Add support for toggle power switches Pavel Machek
2018-07-16 8:58 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180715165926.GB10023@amd \
--to=pavel@ucw.cz \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.