All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: John Whitmore <johnfwhitmore@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	kstewart@linuxfoundation.org, pombredanne@nexb.com,
	tglx@linutronix.de
Subject: Re: [PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style
Date: Mon, 16 Jul 2018 10:41:38 +0200	[thread overview]
Message-ID: <20180716084138.GB8260@kroah.com> (raw)
In-Reply-To: <20180713201247.21428-2-johnfwhitmore@gmail.com>

On Fri, Jul 13, 2018 at 09:12:38PM +0100, John Whitmore wrote:
> To clear a checkpatch issue removed the typedef of the enumeration TR_SELECT
> this should not impact runtime code as it's only a coding style change.
> 
> Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h      |  4 ++--
>  drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 10 +++++-----
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h     |  4 ++--
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c |  6 +++---
>  4 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index 3b7968681f77..0fa55af7060a 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -2391,7 +2391,7 @@ int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb);
>  void TsInitAddBA(struct ieee80211_device *ieee, PTX_TS_RECORD pTS,
>  		 u8 Policy, u8 bOverwritePending);
>  void TsInitDelBA(struct ieee80211_device *ieee,
> -		 PTS_COMMON_INFO pTsCommonInfo, TR_SELECT TxRxSelect);
> +		 PTS_COMMON_INFO pTsCommonInfo, enum TR_SELECT TxRxSelect);
>  void BaSetupTimeOut(struct timer_list *t);
>  void TxBaInactTimeout(struct timer_list *t);
>  void RxBaInactTimeout(struct timer_list *t);
> @@ -2402,7 +2402,7 @@ bool GetTs(
>  	PTS_COMMON_INFO                 *ppTS,
>  	u8                              *Addr,
>  	u8                              TID,
> -	TR_SELECT                       TxRxSelect,  //Rx:1, Tx:0
> +	enum TR_SELECT                  TxRxSelect,  //Rx:1, Tx:0

This really should be "enum tr_select", right?  No ALL CAPS variable
types please.

thanks,

greg k-h

  reply	other threads:[~2018-07-16  8:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 20:12 staging:rtl8192u: [0/10] Coding style changes John Whitmore
2018-07-13 20:12 ` [PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style John Whitmore
2018-07-16  8:41   ` Greg KH [this message]
2018-07-16 11:30     ` John Whitmore
2018-07-13 20:12 ` [PATCH 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO " John Whitmore
2018-07-16  8:42   ` Greg KH
2018-07-16 11:36     ` John Whitmore
2018-07-13 20:12 ` [PATCH 03/10] staging:rtl8192u: Rename List > list - Coding style John Whitmore
2018-07-13 20:12 ` [PATCH 04/10] staging:rtl8192u: rename SetupTimer > setup_timer - Style John Whitmore
2018-07-13 20:12 ` [PATCH 05/10] staging:rtl8192u: Rename InactTimer > inact_timer " John Whitmore
2018-07-13 20:12 ` [PATCH 06/10] staging:rtl8192u: Rename Addr > addr " John Whitmore
2018-07-13 20:12 ` [PATCH 07/10] staging:rtl8192u: Rename TSpec > t_spec " John Whitmore
2018-07-13 20:12 ` [PATCH 08/10] staging:rtl8192u: Rename TClass > t_class " John Whitmore
2018-07-13 20:12 ` [PATCH 09/10] staging:trl8192u: Rename TClasProc > t_clas_proc " John Whitmore
2018-07-13 20:12 ` [PATCH 10/10] staging:rtl8192u: Rename TClasNum > t_clas_num " John Whitmore
2018-07-16  8:40 ` staging:rtl8192u: [0/10] Coding style changes Greg KH
2018-07-16 11:34   ` John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716084138.GB8260@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=johnfwhitmore@gmail.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.