From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D507ECDFB3 for ; Mon, 16 Jul 2018 08:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D807208E9 for ; Mon, 16 Jul 2018 08:42:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D807208E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730795AbeGPJI1 (ORCPT ); Mon, 16 Jul 2018 05:08:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37624 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728734AbeGPJI1 (ORCPT ); Mon, 16 Jul 2018 05:08:27 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 18604D02; Mon, 16 Jul 2018 08:42:07 +0000 (UTC) Date: Mon, 16 Jul 2018 10:42:05 +0200 From: Greg KH To: John Whitmore Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, kstewart@linuxfoundation.org, pombredanne@nexb.com, tglx@linutronix.de Subject: Re: [PATCH 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO - Style Message-ID: <20180716084205.GC8260@kroah.com> References: <20180713201247.21428-1-johnfwhitmore@gmail.com> <20180713201247.21428-3-johnfwhitmore@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180713201247.21428-3-johnfwhitmore@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 13, 2018 at 09:12:39PM +0100, John Whitmore wrote: > To clear a checkpatch issue removed the typedef of the structure > TS_COMMON_INFO. > > This change removes the previous declaration, which defined two types, both > TS_COMMON_INFO and a pointer type PTS_COMMON_INFO: > > typedef struct _TS_COMMON_INFO { > ... > } TS_COMMON_INFO, *PTS_COMMON_INFO; > Same here, this should be "struct ts_common_info", not TS_COMMON_INFO. Can you fix both of these issues up and resend the series? thanks, greg k-h