From: Igor Mammedov <imammedo@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, l00284672 <lizhengui@huawei.com>,
Fam Zheng <famz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] virtio-scsi: fix hotplug ->reset() vs event race
Date: Mon, 16 Jul 2018 11:28:23 +0200 [thread overview]
Message-ID: <20180716112823.0b8925d0@redhat.com> (raw)
In-Reply-To: <20180716083732.3347-1-stefanha@redhat.com>
On Mon, 16 Jul 2018 09:37:30 +0100
Stefan Hajnoczi <stefanha@redhat.com> wrote:
> v2:
> * Drop Error **errp argument to post_plug() handler [Paolo]
> * Move post_plug() call outside if (dev->hotplugged)
>
> The virtio-scsi command virtqueues run during hotplug. This creates the
> possibility of race conditions since the guest can submit commands while the
> monitor is performing hotplug.
>
> See Patch 2 for a fix for the ->reset() vs event race condition that Zhengui Li
> encountered.
>
> Stefan Hajnoczi (2):
> qdev: add HotplugHandler->post_plug() callback
> virtio-scsi: fix hotplug ->reset() vs event race
>
> include/hw/hotplug.h | 11 +++++++++++
> hw/core/hotplug.c | 10 ++++++++++
> hw/core/qdev.c | 4 ++++
> hw/scsi/virtio-scsi.c | 11 ++++++++++-
> 4 files changed, 35 insertions(+), 1 deletion(-)
>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
prev parent reply other threads:[~2018-07-16 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 8:37 [Qemu-devel] [PATCH v2 0/2] virtio-scsi: fix hotplug ->reset() vs event race Stefan Hajnoczi
2018-07-16 8:37 ` [Qemu-devel] [PATCH v2 1/2] qdev: add HotplugHandler->post_plug() callback Stefan Hajnoczi
2018-07-16 8:37 ` [Qemu-devel] [PATCH v2 2/2] virtio-scsi: fix hotplug ->reset() vs event race Stefan Hajnoczi
2018-07-16 12:40 ` Michael S. Tsirkin
2018-07-16 14:11 ` Paolo Bonzini
2018-07-16 9:28 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716112823.0b8925d0@redhat.com \
--to=imammedo@redhat.com \
--cc=famz@redhat.com \
--cc=lizhengui@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.