From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb HC busted? From: Sudip Mukherjee Message-Id: <20180717155901.5csifwp5ak2ixfk5@debian> Date: Tue, 17 Jul 2018 16:59:01 +0100 To: Greg KH Cc: Alan Stern , Mathias Nyman , Andy Shevchenko , Andy Shevchenko , Mathias Nyman , linux-usb@vger.kernel.org, lukaszx.szulc@intel.com, Christoph Hellwig , Marek Szyprowski , iommu@lists.linux-foundation.org List-ID: T24gVHVlLCBKdWwgMTcsIDIwMTggYXQgMDU6NTI6NTlQTSArMDIwMCwgR3JlZyBLSCB3cm90ZToK PiBPbiBUdWUsIEp1bCAxNywgMjAxOCBhdCAxMDozMTozOEFNIC0wNDAwLCBBbGFuIFN0ZXJuIHdy b3RlOgo+ID4gT24gVHVlLCAxNyBKdWwgMjAxOCwgR3JlZyBLSCB3cm90ZToKPiA+IAo+ID4gPiA+ IEZyb206IFN1ZGlwIE11a2hlcmplZSA8c3VkaXBtLm11a2hlcmplZUBnbWFpbC5jb20+Cj4gPiA+ ID4gRGF0ZTogVHVlLCAxMCBKdWwgMjAxOCAwOTo1MDowMCArMDEwMAo+ID4gPiA+IFN1YmplY3Q6 IFtQQVRDSF0gaGFja3kgc29sdXRpb24gdG8gbWVtLWNvcnJ1cHRpb24KPiA+ID4gPiAKPiA+ID4g PiBTaWduZWQtb2ZmLWJ5OiBTdWRpcCBNdWtoZXJqZWUgPHN1ZGlwbS5tdWtoZXJqZWVAZ21haWwu Y29tPgo+ID4gPiA+IC0tLQo8c25pcD4KPiA+IAo+ID4gTm8sIG5laXRoZXIgb2YgdGhlc2UgaXMg cmlnaHQuICBJdCdzIHBvc3NpYmxlIHRvIHVzZSAKPiA+IHVzYl9zZXRfaW50ZXJmYWNlKCkgYXMg YSBraW5kIG9mICJzb2Z0IiByZXNldC4gIEV2ZW4gd2hlbiB0aGUgbmV3IAo+ID4gYWx0c2V0dGlu ZyBpcyBzcGVjaWZpZWQgdG8gYmUgdGhlIHNhbWUgYXMgdGhlIGN1cnJlbnQgb25lLCB3ZSBzdGls bCAKPiA+IGhhdmUgdG8gdGVsbCB0aGUgbG93ZXItbGF5ZXIgZHJpdmVycyBhbmQgaGFyZHdhcmUg YWJvdXQgaXQuCj4gCj4gWW91IGFyZSByaWdodCwgaXQncyBhIGhhY2t5IHNvZnQgcmVzZXQsIEkg d2FzIGp1c3QgdHJ5aW5nIHRvIGZpZ3VyZSBvdXQKPiB3aGF0IHRoZSBibHVldG9vdGggZHJpdmVy IHdhcyB0cnlpbmcgdG8gZG8uICBJIHdvdWxkbid0IGV4cGVjdCBpdCB0byBiZQo+IGNhbGxpbmcg dGhhdCBmdW5jdGlvbiBhIGxvdCwgYnV0IEkgZ3Vlc3MgaXQgZG9lcyA6KAoKdXNiX3NldF9pbnRl cmZhY2UoKSBpcyBiZWluZyBjYWxsZWQgdHdvIHRpbWVzIGZyb20gYmx1ZXRvb3RoIGV2ZW50LiBC dXQKSSBhbSBub3cgYWRkaW5nIG1vcmUgZGVidWdzIHRvIHNlZSB3aHkgeW91ciBwYXRjaCBkaWQg bm90IHdvcmsuCi0tLQpSZWdhcmRzClN1ZGlwCi0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBs aXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9m IGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGlu Zm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: usb HC busted? Date: Tue, 17 Jul 2018 16:59:01 +0100 Message-ID: <20180717155901.5csifwp5ak2ixfk5@debian> References: <20180717120411.GB28592@kroah.com> <20180717155259.GB2416@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180717155259.GB2416-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Greg KH Cc: Mathias Nyman , Mathias Nyman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Christoph Hellwig , Andy Shevchenko , Alan Stern , Andy Shevchenko , lukaszx.szulc-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, Jul 17, 2018 at 05:52:59PM +0200, Greg KH wrote: > On Tue, Jul 17, 2018 at 10:31:38AM -0400, Alan Stern wrote: > > On Tue, 17 Jul 2018, Greg KH wrote: > > > > > > From: Sudip Mukherjee > > > > Date: Tue, 10 Jul 2018 09:50:00 +0100 > > > > Subject: [PATCH] hacky solution to mem-corruption > > > > > > > > Signed-off-by: Sudip Mukherjee > > > > --- > > > > No, neither of these is right. It's possible to use > > usb_set_interface() as a kind of "soft" reset. Even when the new > > altsetting is specified to be the same as the current one, we still > > have to tell the lower-layer drivers and hardware about it. > > You are right, it's a hacky soft reset, I was just trying to figure out > what the bluetooth driver was trying to do. I wouldn't expect it to be > calling that function a lot, but I guess it does :( usb_set_interface() is being called two times from bluetooth event. But I am now adding more debugs to see why your patch did not work. -- Regards Sudip