All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Plotnikov <dplotnikov@virtuozzo.com>
To: dgilbert@redhat.com, quintela@redhat.com, pbonzini@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v1 06/17] background snapshot: add helpers to manage a copy of ram block list
Date: Wed, 18 Jul 2018 18:41:49 +0300	[thread overview]
Message-ID: <20180718154200.26777-7-dplotnikov@virtuozzo.com> (raw)
In-Reply-To: <20180718154200.26777-1-dplotnikov@virtuozzo.com>

The VM ramblock list may be changed during the snapshotting.
We want to make sure that we have the same ramblock list as it
was at the time of snapshot beginning.
So, we create a copy of the list at the beginning of the snapshotting
and use it during the process.

Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
---
 migration/ram.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++
 migration/ram.h |  6 ++++++
 2 files changed, 57 insertions(+)

diff --git a/migration/ram.c b/migration/ram.c
index 021d583b9b..4399c31606 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1508,6 +1508,57 @@ static int ram_save_host_page(RAMState *rs, PageSearchStatus *pss,
     return pages;
 }
 
+/* BackGround Snapshot Blocks */
+static RamBlockList bgs_blocks;
+
+static RamBlockList *ram_bgs_block_list_get(void)
+{
+    return &bgs_blocks;
+}
+
+void ram_block_list_create(void)
+{
+    RAMBlock *block = NULL;
+    RamBlockList *block_list = ram_bgs_block_list_get();
+
+    qemu_mutex_lock_ramlist();
+    QLIST_FOREACH(block, &ram_list.blocks, next) {
+        memory_region_ref(block->mr);
+        QLIST_INSERT_HEAD(block_list, block, bgs_next);
+    }
+    qemu_mutex_unlock_ramlist();
+}
+
+void ram_block_list_destroy(void)
+{
+    RAMBlock *next, *block;
+    RamBlockList *block_list = ram_bgs_block_list_get();
+
+    QLIST_FOREACH_SAFE(block, block_list, bgs_next, next) {
+        QLIST_REMOVE(block, bgs_next);
+        memory_region_unref(block->mr);
+    }
+}
+
+RAMBlock *ram_bgs_block_find(uint8_t *address, ram_addr_t *page_offset)
+{
+    RAMBlock *block = NULL;
+    RamBlockList *block_list = ram_bgs_block_list_get();
+
+    QLIST_FOREACH(block, block_list, bgs_next) {
+        /* This case append when the block is not mapped. */
+        if (block->host == NULL) {
+            continue;
+        }
+
+        if (address - block->host < block->max_length) {
+            *page_offset = (address - block->host) & TARGET_PAGE_MASK;
+            return block;
+        }
+    }
+
+    return NULL;
+}
 /**
  * ram_find_and_save_block: finds a dirty page and sends it to f
  *
diff --git a/migration/ram.h b/migration/ram.h
index 64d81e9f1d..385579cae9 100644
--- a/migration/ram.h
+++ b/migration/ram.h
@@ -31,6 +31,7 @@
 
 #include "qemu-common.h"
 #include "exec/cpu-common.h"
+#include "exec/ramlist.h"
 
 extern MigrationStats ram_counters;
 extern XBZRLECacheStats xbzrle_counters;
@@ -61,5 +62,10 @@ void ram_handle_compressed(void *host, uint8_t ch, uint64_t size);
 int ramblock_recv_bitmap_test(RAMBlock *rb, void *host_addr);
 void ramblock_recv_bitmap_set(RAMBlock *rb, void *host_addr);
 void ramblock_recv_bitmap_set_range(RAMBlock *rb, void *host_addr, size_t nr);
+/* For background snapshot */
+void ram_block_list_create(void);
+void ram_block_list_destroy(void);
+
+RAMBlock *ram_bgs_block_find(uint8_t *address, ram_addr_t *page_offset);
 
 #endif
-- 
2.17.0

  parent reply	other threads:[~2018-07-18 15:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 15:41 [Qemu-devel] [PATCH v1 00/17] Background snapshots Denis Plotnikov
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 01/17] migration: add background snapshot capability Denis Plotnikov
2018-07-20  5:14   ` Peter Xu
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 02/17] bitops: add some atomic versions of bitmap operations Denis Plotnikov
2018-07-20  5:09   ` Peter Xu
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 03/17] threads: add infrastructure to process sigsegv Denis Plotnikov
2018-07-20  4:58   ` Peter Xu
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 04/17] background snapshot: make a dedicated type for ram block list Denis Plotnikov
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 05/17] ram: extend the data structures for background snapshotting Denis Plotnikov
2018-07-20  7:59   ` Peter Xu
2018-07-18 15:41 ` Denis Plotnikov [this message]
2018-07-20  7:57   ` [Qemu-devel] [PATCH v1 06/17] background snapshot: add helpers to manage a copy of ram block list Peter Xu
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 07/17] background snapshot: introduce page buffer Denis Plotnikov
2018-07-20  9:22   ` Peter Xu
2018-07-20 10:34   ` Paolo Bonzini
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 08/17] migration: add helpers to change VM memory protection rights Denis Plotnikov
2018-07-20 11:28   ` Dr. David Alan Gilbert
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 09/17] background snapshot: extend RAM request for holding a page copy pointer Denis Plotnikov
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 10/17] background snapshots: adapt the page queueing code for using page copies Denis Plotnikov
2018-07-20  8:39   ` Peter Xu
2018-07-20 11:46   ` Peter Xu
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 11/17] background snapshot: add a memory page copying function Denis Plotnikov
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 12/17] ram: add background snapshot support in ram page saving part of migration Denis Plotnikov
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 13/17] background snapshot: add write-protected page access handler function Denis Plotnikov
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 14/17] kvm: add failed memeory access exit reason Denis Plotnikov
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 15/17] kvm: add vCPU failed memeory access processing Denis Plotnikov
2018-07-20  9:44   ` Peter Xu
2018-07-18 15:41 ` [Qemu-devel] [PATCH v1 16/17] migration: move the device state saving logic to a separate function Denis Plotnikov
2018-07-18 15:42 ` [Qemu-devel] [PATCH v1 17/17] background snapshot: enable background snapshot Denis Plotnikov
2018-07-20  9:27 ` [Qemu-devel] [PATCH v1 00/17] Background snapshots Peter Xu
2018-09-04 13:00   ` Denis Plotnikov
2018-09-05  3:32     ` Peter Xu
2018-09-05  9:18       ` Denis Plotnikov
2018-09-05  9:30         ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180718154200.26777-7-dplotnikov@virtuozzo.com \
    --to=dplotnikov@virtuozzo.com \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.