From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Date: Thu, 19 Jul 2018 10:16:01 +0000 Subject: [PATCH v3 2/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Message-Id: <20180719101601.25076-3-tzimmermann@suse.de> List-Id: References: <20180719101601.25076-1-tzimmermann@suse.de> In-Reply-To: <20180719101601.25076-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: rostedt@goodmis.org, pmladek@suse.com, linux-fbdev@vger.kernel.org, sergey.senozhatsky@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, hdegoede@redhat.com, akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com Cc: Thomas Zimmermann If the console is unlocked during registration, the console subsystem generates significant amounts of warnings, which obfuscate actual debugging messages. Setting ignore_console_lock_warning while debugging console registration avoid the noise. v3: - manipulate ignore_console_lock_warning with atomic_{inc,dec} v2: - restore ignore_console_lock_warning if lock_fb_info() fails Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbmem.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 9e2f9d3c760e..cb72cd6c5892 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -1691,17 +1691,22 @@ static int do_register_framebuffer(struct fb_info *fb_info) event.info = fb_info; if (!lockless_register_fb) console_lock(); + else + atomic_inc(&ignore_console_lock_warning); if (!lock_fb_info(fb_info)) { - if (!lockless_register_fb) - console_unlock(); - return -ENODEV; + ret = -ENODEV; + goto unlock_console; } + ret = 0; fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event); unlock_fb_info(fb_info); +unlock_console: if (!lockless_register_fb) console_unlock(); - return 0; + else + atomic_dec(&ignore_console_lock_warning); + return ret; } static int do_unregister_framebuffer(struct fb_info *fb_info) -- 2.18.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: [PATCH v3 2/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Date: Thu, 19 Jul 2018 12:16:01 +0200 Message-ID: <20180719101601.25076-3-tzimmermann@suse.de> References: <20180719101601.25076-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D9226EC3F for ; Thu, 19 Jul 2018 10:16:07 +0000 (UTC) In-Reply-To: <20180719101601.25076-1-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: rostedt@goodmis.org, pmladek@suse.com, linux-fbdev@vger.kernel.org, sergey.senozhatsky@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, hdegoede@redhat.com, akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com Cc: Thomas Zimmermann List-Id: dri-devel@lists.freedesktop.org SWYgdGhlIGNvbnNvbGUgaXMgdW5sb2NrZWQgZHVyaW5nIHJlZ2lzdHJhdGlvbiwgdGhlIGNvbnNv bGUgc3Vic3lzdGVtCmdlbmVyYXRlcyBzaWduaWZpY2FudCBhbW91bnRzIG9mIHdhcm5pbmdzLCB3 aGljaCBvYmZ1c2NhdGUgYWN0dWFsCmRlYnVnZ2luZyBtZXNzYWdlcy4gU2V0dGluZyBpZ25vcmVf Y29uc29sZV9sb2NrX3dhcm5pbmcgd2hpbGUgZGVidWdnaW5nCmNvbnNvbGUgcmVnaXN0cmF0aW9u IGF2b2lkIHRoZSBub2lzZS4KCnYzOgoJLSBtYW5pcHVsYXRlIGlnbm9yZV9jb25zb2xlX2xvY2tf d2FybmluZyB3aXRoIGF0b21pY197aW5jLGRlY30KdjI6CgktIHJlc3RvcmUgaWdub3JlX2NvbnNv bGVfbG9ja193YXJuaW5nIGlmIGxvY2tfZmJfaW5mbygpIGZhaWxzCgpTaWduZWQtb2ZmLWJ5OiBU aG9tYXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KLS0tCiBkcml2ZXJzL3ZpZGVv L2ZiZGV2L2NvcmUvZmJtZW0uYyB8IDEzICsrKysrKysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA5 IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRl by9mYmRldi9jb3JlL2ZibWVtLmMgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUvZmJtZW0uYwpp bmRleCA5ZTJmOWQzYzc2MGUuLmNiNzJjZDZjNTg5MiAxMDA2NDQKLS0tIGEvZHJpdmVycy92aWRl by9mYmRldi9jb3JlL2ZibWVtLmMKKysrIGIvZHJpdmVycy92aWRlby9mYmRldi9jb3JlL2ZibWVt LmMKQEAgLTE2OTEsMTcgKzE2OTEsMjIgQEAgc3RhdGljIGludCBkb19yZWdpc3Rlcl9mcmFtZWJ1 ZmZlcihzdHJ1Y3QgZmJfaW5mbyAqZmJfaW5mbykKIAlldmVudC5pbmZvID0gZmJfaW5mbzsKIAlp ZiAoIWxvY2tsZXNzX3JlZ2lzdGVyX2ZiKQogCQljb25zb2xlX2xvY2soKTsKKwllbHNlCisJCWF0 b21pY19pbmMoJmlnbm9yZV9jb25zb2xlX2xvY2tfd2FybmluZyk7CiAJaWYgKCFsb2NrX2ZiX2lu Zm8oZmJfaW5mbykpIHsKLQkJaWYgKCFsb2NrbGVzc19yZWdpc3Rlcl9mYikKLQkJCWNvbnNvbGVf dW5sb2NrKCk7Ci0JCXJldHVybiAtRU5PREVWOworCQlyZXQgPSAtRU5PREVWOworCQlnb3RvIHVu bG9ja19jb25zb2xlOwogCX0KKwlyZXQgPSAwOwogCiAJZmJfbm90aWZpZXJfY2FsbF9jaGFpbihG Ql9FVkVOVF9GQl9SRUdJU1RFUkVELCAmZXZlbnQpOwogCXVubG9ja19mYl9pbmZvKGZiX2luZm8p OwordW5sb2NrX2NvbnNvbGU6CiAJaWYgKCFsb2NrbGVzc19yZWdpc3Rlcl9mYikKIAkJY29uc29s ZV91bmxvY2soKTsKLQlyZXR1cm4gMDsKKwllbHNlCisJCWF0b21pY19kZWMoJmlnbm9yZV9jb25z b2xlX2xvY2tfd2FybmluZyk7CisJcmV0dXJuIHJldDsKIH0KIAogc3RhdGljIGludCBkb191bnJl Z2lzdGVyX2ZyYW1lYnVmZmVyKHN0cnVjdCBmYl9pbmZvICpmYl9pbmZvKQotLSAKMi4xOC4wCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK