From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
Date: Thu, 19 Jul 2018 14:59:34 +0200 [thread overview]
Message-ID: <20180719125934.GA1432@bigcity.dyn.berto.se> (raw)
In-Reply-To: <153199919069.10140.15895581107478774899.sendpatchset@little-apple>
Hi Magnus,
Thanks for your patch.
On 2018-07-19 20:19:50 +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Browsing the DTS for all the R-Car SoCs with similar part numbers
> makes my head hurt, so to improve the user friendliness of the
> DTS code base include R-Car product name in each DTSI file.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> Based on renesas-drivers-2018-07-17-v4.18-rc5
>
> arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
>
> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi 2018-07-19 20:04:10.900607110 +0900
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree Source for the r8a7795 ES1.x SoC
> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
I'm just curies why do you append a extra 0 to the part number here and
for M3-W? Other then I think this change is good and will help me as
well to map part number to product name :-)
> *
> * Copyright (C) 2015 Renesas Electronics Corp.
> */
> --- 0001/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi 2018-07-19 20:04:21.030607110 +0900
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree Source for the r8a7795 SoC
> + * Device Tree Source for the R-Car H3 (R8A77950) SoC
> *
> * Copyright (C) 2015 Renesas Electronics Corp.
> */
> --- 0001/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7796.dtsi 2018-07-19 20:04:53.310607110 +0900
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree Source for the r8a7796 SoC
> + * Device Tree Source for the R-Car M3-W (R8A77960) SoC
> *
> * Copyright (C) 2016-2017 Renesas Electronics Corp.
> */
> --- 0001/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77965.dtsi 2018-07-19 20:05:24.380607110 +0900
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree Source for the r8a77965 SoC
> + * Device Tree Source for the R-Car M3-N (R8A77965) SoC
> *
> * Copyright (C) 2018 Jacopo Mondi <jacopo+renesas@jmondi.org>
> *
> --- 0001/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77970.dtsi 2018-07-19 20:06:31.090607110 +0900
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree Source for the r8a77970 SoC
> + * Device Tree Source for the R-Car V3M (R8A77970) SoC
> *
> * Copyright (C) 2016-2017 Renesas Electronics Corp.
> * Copyright (C) 2017 Cogent Embedded, Inc.
> --- 0001/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77980.dtsi 2018-07-19 20:06:16.310607110 +0900
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree Source for the r8a77980 SoC
> + * Device Tree Source for the R-Car V3H (R8A77980) SoC
> *
> * Copyright (C) 2018 Renesas Electronics Corp.
> * Copyright (C) 2018 Cogent Embedded, Inc.
> --- 0001/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77990.dtsi 2018-07-19 20:06:58.970607110 +0900
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * Device Tree Source for the r8a77990 SoC
> + * Device Tree Source for the R-Car E3 (R8A77990) SoC
> *
> * Copyright (C) 2018 Renesas Electronics Corp.
> */
> --- 0005/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77995.dtsi 2018-07-19 20:07:20.150607110 +0900
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree Source for the r8a77995 SoC
> + * Device Tree Source for the R-Car D3 (R8A77995) SoC
> *
> * Copyright (C) 2016 Renesas Electronics Corp.
> * Copyright (C) 2017 Glider bvba
--
Regards,
Niklas S�derlund
next prev parent reply other threads:[~2018-07-19 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 11:19 [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files Magnus Damm
2018-07-19 12:59 ` Niklas Söderlund [this message]
2018-07-19 17:16 ` Magnus Damm
2018-07-19 17:37 ` Geert Uytterhoeven
2018-07-20 3:05 ` Magnus Damm
2018-07-20 7:31 ` Geert Uytterhoeven
2018-07-24 12:15 ` Simon Horman
2018-07-20 8:21 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719125934.GA1432@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.