All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/5] nvme-multipath: disable ANA support if parsing fails
Date: Thu, 19 Jul 2018 16:43:55 +0200	[thread overview]
Message-ID: <20180719144355.GA20422@lst.de> (raw)
In-Reply-To: <20180716105837.101125-5-hare@suse.de>

On Mon, Jul 16, 2018@12:58:36PM +0200, Hannes Reinecke wrote:
> If we cannot parse the ANA log page we should just disable ANA
> support altogether, otherwise we fail to connect to the controller
> and we have no way of figuring out what went wrong.
> And we should kill the WARN_ON() statements as we now have a valid
> recovery strategy.

I don't like this.  There is a lot magic now where we need to
check if we have a buffer independent of wheter the controller
supports ANA to start with.

If we really have a that buggy controller we'll need to quirk it.

  reply	other threads:[~2018-07-19 14:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 10:58 [PATCH 0/5] nvme: ANA implementation fixes Hannes Reinecke
2018-07-16 10:58 ` [PATCH 1/5] nvme: count all ANA groups for ANA Log page Hannes Reinecke
2018-07-19 14:31   ` Christoph Hellwig
2018-09-17 13:49   ` Christoph Hellwig
2018-07-16 10:58 ` [PATCH 2/5] nvmet: fixup crash on NULL device path Hannes Reinecke
2018-07-17 13:48   ` Christoph Hellwig
2018-07-17 13:48     ` Hannes Reinecke
2018-07-17 13:55       ` Christoph Hellwig
2018-07-24 14:02       ` Christoph Hellwig
2018-07-25  7:25         ` Hannes Reinecke
2018-07-16 10:58 ` [PATCH 3/5] nvme-multipath: fixup crash during disconnect Hannes Reinecke
2018-07-19 14:31   ` Christoph Hellwig
2018-07-19 14:35     ` Christoph Hellwig
2018-07-16 10:58 ` [PATCH 4/5] nvme-multipath: disable ANA support if parsing fails Hannes Reinecke
2018-07-19 14:43   ` Christoph Hellwig [this message]
2018-07-19 16:00     ` Hannes Reinecke
2018-07-20 15:00       ` Christoph Hellwig
2018-07-16 10:58 ` [PATCH 5/5] nvme-multipath: parse entire ANA log page in nvme_set_ns_ana_state() Hannes Reinecke
2018-07-19 14:46   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719144355.GA20422@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.