From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH v4 07/10] KVM: arm/arm64: vgic: Return error on incompatible uaccess GICD_IIDR writes Date: Thu, 19 Jul 2018 19:09:32 +0200 Message-ID: <20180719170932.cqdilzdzfahugkf5@kamzik.brq.redhat.com> References: <1531746387-7033-1-git-send-email-christoffer.dall@arm.com> <1531746387-7033-8-git-send-email-christoffer.dall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marc Zyngier , Andre Przywara , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Christoffer Dall Return-path: Content-Disposition: inline In-Reply-To: <1531746387-7033-8-git-send-email-christoffer.dall@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Mon, Jul 16, 2018 at 03:06:24PM +0200, Christoffer Dall wrote: > If userspace attempts to write a GICD_IIDR that does not match the > kernel version, return an error to userspace. The intention is to allow > implementation changes inside KVM while avoiding silently breaking > migration resulting in guests not running without any clear indication > of what went wrong. > > Signed-off-by: Christoffer Dall > --- > virt/kvm/arm/vgic/vgic-mmio-v2.c | 21 ++++++++++++++++++--- > virt/kvm/arm/vgic/vgic-mmio-v3.c | 21 ++++++++++++++++++--- > 2 files changed, 36 insertions(+), 6 deletions(-) > Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 From: drjones@redhat.com (Andrew Jones) Date: Thu, 19 Jul 2018 19:09:32 +0200 Subject: [PATCH v4 07/10] KVM: arm/arm64: vgic: Return error on incompatible uaccess GICD_IIDR writes In-Reply-To: <1531746387-7033-8-git-send-email-christoffer.dall@arm.com> References: <1531746387-7033-1-git-send-email-christoffer.dall@arm.com> <1531746387-7033-8-git-send-email-christoffer.dall@arm.com> Message-ID: <20180719170932.cqdilzdzfahugkf5@kamzik.brq.redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jul 16, 2018 at 03:06:24PM +0200, Christoffer Dall wrote: > If userspace attempts to write a GICD_IIDR that does not match the > kernel version, return an error to userspace. The intention is to allow > implementation changes inside KVM while avoiding silently breaking > migration resulting in guests not running without any clear indication > of what went wrong. > > Signed-off-by: Christoffer Dall > --- > virt/kvm/arm/vgic/vgic-mmio-v2.c | 21 ++++++++++++++++++--- > virt/kvm/arm/vgic/vgic-mmio-v3.c | 21 ++++++++++++++++++--- > 2 files changed, 36 insertions(+), 6 deletions(-) > Reviewed-by: Andrew Jones