From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 2/2] drm/i915/mst: Continue state updates even if AUX writes fail. Date: Thu, 19 Jul 2018 16:37:48 -0700 Message-ID: <20180719233748.GB2184@intel.com> References: <20180718171943.3246-1-dhinakaran.pandiyan@intel.com> <20180718171943.3246-2-dhinakaran.pandiyan@intel.com> <20180719054316.GN2146@intel.com> <1532026300.28553.81.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECF386EE27 for ; Thu, 19 Jul 2018 23:37:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1532026300.28553.81.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMTksIDIwMTggYXQgMTE6NTE6NDBBTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBPbiBXZWQsIDIwMTgtMDctMTggYXQgMjI6NDMgLTA3MDAsIFJvZHJpZ28g Vml2aSB3cm90ZToKPiA+IE9uIFdlZCwgSnVsIDE4LCAyMDE4IGF0IDEwOjE5OjQzQU0gLTA3MDAs IERoaW5ha2FyYW4gUGFuZGl5YW4gd3JvdGU6Cj4gPiA+IAo+ID4gPiBXZSBhcmUgdG9vIGxhdGUg aW4gdGhlIGVuYWJsaW5nIHNlcXVlbmNlIHRvIGJhY2sgb3V0IGNsZWFubHksIG5vdAo+ID4gPiB1 cGRhdGluZwo+ID4gPiBzdGF0ZSB0cmFja2luZyB2YXJpYWJsZXMsIGxpa2UgaW50ZWxfZHAtPmFj dGl2ZV9tc3RfbGlua3MgaW4gdGhpcwo+ID4gPiBpbnN0YW5jZSwgcmVzdWx0cyBpbiBpbmNvcnJl Y3QgYmVoYXZpb3VyIGZ1cnRoZXIgYWxvbmcuCj4gPiBJIGFncmVlIHdpdGggeW91LCBhbHRob3Vn aCBJJ20gbm90IGZ1bGx5IGNvbnZpbmNlZCB0aGF0IHdlIG5lZWQgdG8KPiA+IGNhbGwgdGhlCj4g PiB1cGRhdGUgcGF5bG9hZCBpZiB2Y3BpIGFsbG9jYXRpb24gZmFpbGVkLi4uCj4gCj4gQnV0IHRo ZXJlIGlzIG1vcmUgcGF5bG9hZCB1cGRhdGUgY29kZSBpbiBpbnRlbF9tc3RfZW5hYmxlX2RwKCks CgpvaC4uLiB0aGUgcGFydDIgaW5kZWVkLi4uCgo+IHRoYXQKPiB3b3VsZCBnZXQgZXhlY3V0ZWQg cmVnYXJkbGVzcyBvZiB0aGlzIGRpZmYgYmVsb3cuIFdlJ2xsIGhhdmUgdG8gcmV3cml0ZQo+IHBy ZV9lbmFibGUsIGVuYWJsZSwgZGlzYWJsZSBhbmQgcG9zdF9kaXNhYmxlIGlmIHRoZSBpZGVhIGlz IGF2b2lkIHNpbmsKPiB0cmFuc2FjdGlvbnMgYWZ0ZXIgdGhlIGZpcnN0IGZhaWx1cmUuIEl0IGRv ZXMgbWFrZSBzZW5zZSB0byBkbyBhbGwgb2YKPiB0aGF0IGFzIGl0IGF2b2lkcyBwcmludGluZyBl cnJvciBtZXNzYWdlcyBpbiBkbWVzZyB3aGVuIHdlIHZlcnkgd2VsbAo+IGtub3cgdGhlIGJyYW5j aCBkZXZpY2UgaXMgZGlzY29ubmVjdGVkLCBidXQgdGhpcyBzaG91bGQgYmUgYSBzZXBhcmF0ZQo+ IGNoYW5nZS4KCmZhaXIgZW5vdWdoLi4uCgo+IE15IGlkZWEgd2FzIHRvIGJyaW5nIHByZV9lbmFi bGUvZW5hYmxlIGluIGxpbmUgd2l0aAo+IGRpc2FibGUvcG9zdF9kaXNhYmxlLgoKbWFrZXMgc2Vu c2UuLi4gSSBqdXN0IHNhdyBpdCBpcyBzaW1pbGFyIG9uIHBheWxvYWQgdXBkYXRlIGZhaWx1cmUu CgpSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKPiAK PiAKPiA+IAo+ID4gc28gaW1obyB0aGlzIGVudGlyZSBmdW5jdGlvbiBzaG91bGQgYmUgcmV3b3Jr ZWQgdG8gYmUgbGlrZSB0aGlzOgo+ID4gCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcF9tc3QuYwo+ID4gQEAgLTIxNyw3ICsyMTcsNiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9t c3RfcHJlX2VuYWJsZV9kcChzdHJ1Y3QKPiA+IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiDC oMKgwqDCoMKgwqDCoMKgZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5wb3J0 Owo+ID4gwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciA9 Cj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHRvX2ludGVsX2Nvbm5lY3Rvcihj b25uX3N0YXRlLT5jb25uZWN0b3IpOwo+ID4gLcKgwqDCoMKgwqDCoMKgaW50IHJldDsKPiA+IMKg wqDCoMKgwqDCoMKgwqB1aW50MzJfdCB0ZW1wOwo+ID4gwqAKPiA+IMKgwqDCoMKgwqDCoMKgwqAv KiBNU1QgZW5jb2RlcnMgYXJlIGJvdW5kIHRvIGEgY3J0Yywgbm90IHRvIGEgY29ubmVjdG9yLAo+ ID4gQEAgLTIzMywyNSArMjMyLDE1IEBAIHN0YXRpYyB2b2lkIGludGVsX21zdF9wcmVfZW5hYmxl X2RwKHN0cnVjdAo+ID4gaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+IMKgCj4gPiDCoMKgwqDC oMKgwqDCoMKgZHJtX2RwX3NlbmRfcG93ZXJfdXBkb3duX3BoeSgmaW50ZWxfZHAtPm1zdF9tZ3Is IGNvbm5lY3Rvci0KPiA+ID5wb3J0LCB0cnVlKTsKPiA+IMKgCj4gPiAtwqDCoMKgwqDCoMKgwqBp ZiAoaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MgPT0gMCkKPiA+ICvCoMKgwqDCoMKgwqDCoGlm IChpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcysrID09IDApCj4gPiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoGludGVsX2RpZ19wb3J0LT5iYXNlLnByZV9lbmFibGUoJmludGVsX2Rp Z19wb3J0LQo+ID4gPmJhc2UsCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqBwaXBlX2NvbmZpZywgTlVMTCk7Cj4gPiDCoAo+ID4gLcKgwqDCoMKgwqDCoMKgcmV0ID0g ZHJtX2RwX21zdF9hbGxvY2F0ZV92Y3BpKCZpbnRlbF9kcC0+bXN0X21nciwKPiA+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgY29ubmVjdG9yLT5wb3J0LAo+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBwaXBl X2NvbmZpZy0+cGJuLAo+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBwaXBlX2NvbmZpZy0+ZHBfbV9u LnR1KTsKPiA+IC3CoMKgwqDCoMKgwqDCoGlmIChyZXQgPT0gZmFsc2UpIHsKPiA+ICvCoMKgwqDC oMKgwqDCoGlmIChkcm1fZHBfbXN0X2FsbG9jYXRlX3ZjcGkoJmludGVsX2RwLT5tc3RfbWdyLCBj b25uZWN0b3ItCj4gPiA+cG9ydCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBwaXBlX2NvbmZpZy0+cGJu LCBwaXBlX2NvbmZpZy0KPiA+ID5kcF9tX24udHUpKQo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoGRybV9kcF91cGRhdGVfcGF5bG9hZF9wYXJ0MSgmaW50ZWxfZHAtPm1zdF9tZ3Ip Owo+ID4gK8KgwqDCoMKgwqDCoMKgZWxzZQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqBEUk1fRVJST1IoImZhaWxlZCB0byBhbGxvY2F0ZSB2Y3BpXG4iKTsKPiA+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm47Cj4gPiAtwqDCoMKgwqDCoMKgwqB9Cj4gPiAt Cj4gPiAtCj4gPiAtwqDCoMKgwqDCoMKgwqBpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcysrOwo+ ID4gLcKgwqDCoMKgwqDCoMKgdGVtcCA9IEk5MTVfUkVBRChEUF9UUF9TVEFUVVMocG9ydCkpOwo+ ID4gLcKgwqDCoMKgwqDCoMKgSTkxNV9XUklURShEUF9UUF9TVEFUVVMocG9ydCksIHRlbXApOwo+ ID4gLQo+ID4gLcKgwqDCoMKgwqDCoMKgcmV0ID0gZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3BhcnQx KCZpbnRlbF9kcC0+bXN0X21ncik7Cj4gPiAKPiA+IAo+ID4gcHJvYmFibHkgd2l0aAo+ID4gLcKg wqDCoMKgwqDCoMKgdGVtcCA9IEk5MTVfUkVBRChEUF9UUF9TVEFUVVMocG9ydCkpOwo+ID4gLcKg wqDCoMKgwqDCoMKgSTkxNV9XUklURShEUF9UUF9TVEFUVVMocG9ydCksIHRlbXApOwo+ID4gCj4g PiBpbiBhIHNlcGFyYXRlZCBwYXRjaC4gTm8gaWRlYSB3aHkgd2UgcmVhZCB0aGlzIHN0YXVzIHJl ZyBhbmQgd3JpdGUKPiA+IGJhY2suCj4gSXQgaXMgY2xlYXJpbmcgdGhlIEFDVCBzdGF0dXMgYml0 IGJ5IHdyaXRpbmcgYSAxLiBCc3BlYyBoYXMgdGhpcwo+IHVuZGVywqBEUF9UUF9TVEFUVVM6MjQK PiAKPiAtREsKPiAKPiA+IEkgZGlkbid0IHNlZSBvbiBzcGVjIGFueSBpbmRpY2F0aW9uIHRoYXQg dGhpcyBjbGVhbnMgaXQgb3IgdGhhdCB3ZQo+ID4gbmVlZCB0aGF0Cj4gPiBmb3IgY2xlYW5pbmcg b3IgYW55dGhpbmcgZWxzZS4KPiA+IAo+ID4gPiAKPiA+ID4gCj4gPiA+IHYyOiBGaXhlZCBpbnQg di9zIGJvb2wgY29tcGFyaXNvbgo+ID4gPiAKPiA+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJp Z28udml2aUBpbnRlbC5jb20+Cj4gPiA+IENjOiBOYXRoYW4gQ2lvYmFudSA8bmF0aGFuLmQuY2lv YmFudUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFu ZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gwqBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYyB8IDUgKy0tLS0KPiA+ID4gwqAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDQgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMKPiA+ID4gYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ID4gPiBpbmRleCA3ZTNlMDE2MDc2 NDMuLjExMGU3ZmYyMmVmNyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHBfbXN0LmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBf bXN0LmMKPiA+ID4gQEAgLTI0MSwxMSArMjQxLDggQEAgc3RhdGljIHZvaWQgaW50ZWxfbXN0X3By ZV9lbmFibGVfZHAoc3RydWN0Cj4gPiA+IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiA+IMKg CQkJCcKgwqDCoMKgwqDCoMKgY29ubmVjdG9yLT5wb3J0LAo+ID4gPiDCoAkJCQnCoMKgwqDCoMKg wqDCoHBpcGVfY29uZmlnLT5wYm4sCj4gPiA+IMKgCQkJCcKgwqDCoMKgwqDCoMKgcGlwZV9jb25m aWctPmRwX21fbi50dSk7Cj4gPiA+IC0JaWYgKHJldCA9PSBmYWxzZSkgewo+ID4gPiArCWlmICgh cmV0KQo+ID4gPiDCoAkJRFJNX0VSUk9SKCJmYWlsZWQgdG8gYWxsb2NhdGUgdmNwaVxuIik7Cj4g PiA+IC0JCXJldHVybjsKPiA+ID4gLQl9Cj4gPiA+IC0KPiA+ID4gwqAKPiA+ID4gwqAJaW50ZWxf ZHAtPmFjdGl2ZV9tc3RfbGlua3MrKzsKPiA+ID4gwqAJdGVtcCA9IEk5MTVfUkVBRChEUF9UUF9T VEFUVVMocG9ydCkpOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK