* [PATCH 0/4] mtd: Remove gpio.h inclusions where we can
@ 2018-07-20 9:57 Boris Brezillon
2018-07-20 9:57 ` [PATCH 1/4] mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions Boris Brezillon
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Boris Brezillon @ 2018-07-20 9:57 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd,
David Woodhouse, Brian Norris, Marek Vasut
Hello,
The fix I sent here [1] lead me to look at other places including gpio.h
in the MTD subsystem. While some inclusions are valid, some of them can
be removed of replaced by gpio/consumer.h.
All these changes have been compile-tested.
Regards,
Boris
[1]http://patchwork.ozlabs.org/patch/946614/
Boris Brezillon (4):
mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions
mtd: rawnand: atmel: Stop including gpio.h
mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion
mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h
drivers/mtd/nand/raw/atmel/nand-controller.c | 1 -
drivers/mtd/nand/raw/au1550nd.c | 1 -
drivers/mtd/nand/raw/sunxi_nand.c | 2 --
drivers/mtd/spi-nor/atmel-quadspi.c | 2 +-
4 files changed, 1 insertion(+), 5 deletions(-)
--
2.14.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/4] mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions
2018-07-20 9:57 [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Boris Brezillon
@ 2018-07-20 9:57 ` Boris Brezillon
2018-07-20 9:57 ` [PATCH 2/4] mtd: rawnand: atmel: Stop including gpio.h Boris Brezillon
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Boris Brezillon @ 2018-07-20 9:57 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd,
David Woodhouse, Brian Norris, Marek Vasut
Commit ddd5ed3a90e7 ("mtd: rawnand: sunxi: Remove support for
GPIO-based Ready/Busy polling") removed GPIO-based RB polling. We no
longer need to include gpio headers.
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
drivers/mtd/nand/raw/sunxi_nand.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index 07f3ff9a28f2..2c0cbe72b449 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -29,14 +29,12 @@
#include <linux/platform_device.h>
#include <linux/of.h>
#include <linux/of_device.h>
-#include <linux/of_gpio.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/rawnand.h>
#include <linux/mtd/partitions.h>
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/dmaengine.h>
-#include <linux/gpio.h>
#include <linux/interrupt.h>
#include <linux/iopoll.h>
#include <linux/reset.h>
--
2.14.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/4] mtd: rawnand: atmel: Stop including gpio.h
2018-07-20 9:57 [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Boris Brezillon
2018-07-20 9:57 ` [PATCH 1/4] mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions Boris Brezillon
@ 2018-07-20 9:57 ` Boris Brezillon
2018-07-20 9:57 ` [PATCH 3/4] mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion Boris Brezillon
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Boris Brezillon @ 2018-07-20 9:57 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd,
David Woodhouse, Brian Norris, Marek Vasut
gpio/consumer.h defines everything we need, and it's clearly stated in
gpio.h that GPIO consumers should directly stop including gpio.h if they
can.
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
drivers/mtd/nand/raw/atmel/nand-controller.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index 855cc7729c43..4d27401f1299 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -52,7 +52,6 @@
#include <linux/dma-mapping.h>
#include <linux/dmaengine.h>
#include <linux/genalloc.h>
-#include <linux/gpio.h>
#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/mfd/syscon.h>
--
2.14.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/4] mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion
2018-07-20 9:57 [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Boris Brezillon
2018-07-20 9:57 ` [PATCH 1/4] mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions Boris Brezillon
2018-07-20 9:57 ` [PATCH 2/4] mtd: rawnand: atmel: Stop including gpio.h Boris Brezillon
@ 2018-07-20 9:57 ` Boris Brezillon
2018-07-20 9:57 ` [PATCH 4/4] mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h Boris Brezillon
2018-07-26 23:29 ` [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Miquel Raynal
4 siblings, 0 replies; 8+ messages in thread
From: Boris Brezillon @ 2018-07-20 9:57 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd,
David Woodhouse, Brian Norris, Marek Vasut
We don't use the GPIO API in this driver, let's just remove the
<linux/gpio.h> inclusion.
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
drivers/mtd/nand/raw/au1550nd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/au1550nd.c b/drivers/mtd/nand/raw/au1550nd.c
index df0ef1f1e2f5..35f5c84cd331 100644
--- a/drivers/mtd/nand/raw/au1550nd.c
+++ b/drivers/mtd/nand/raw/au1550nd.c
@@ -8,7 +8,6 @@
*/
#include <linux/slab.h>
-#include <linux/gpio.h>
#include <linux/module.h>
#include <linux/interrupt.h>
#include <linux/mtd/mtd.h>
--
2.14.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/4] mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h
2018-07-20 9:57 [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Boris Brezillon
` (2 preceding siblings ...)
2018-07-20 9:57 ` [PATCH 3/4] mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion Boris Brezillon
@ 2018-07-20 9:57 ` Boris Brezillon
2018-07-27 7:48 ` Boris Brezillon
2018-07-26 23:29 ` [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Miquel Raynal
4 siblings, 1 reply; 8+ messages in thread
From: Boris Brezillon @ 2018-07-20 9:57 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd,
David Woodhouse, Brian Norris, Marek Vasut
GPIO consumers now include <linux/gpio/consumer.h> instead of
<linux/gpio.h> if they can.
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
drivers/mtd/spi-nor/atmel-quadspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c b/drivers/mtd/spi-nor/atmel-quadspi.c
index 6c5708bacad8..ce65c2b53ac1 100644
--- a/drivers/mtd/spi-nor/atmel-quadspi.c
+++ b/drivers/mtd/spi-nor/atmel-quadspi.c
@@ -34,7 +34,7 @@
#include <linux/of.h>
#include <linux/io.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
/* QSPI register offsets */
#define QSPI_CR 0x0000 /* Control Register */
--
2.14.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] mtd: Remove gpio.h inclusions where we can
2018-07-20 9:57 [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Boris Brezillon
` (3 preceding siblings ...)
2018-07-20 9:57 ` [PATCH 4/4] mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h Boris Brezillon
@ 2018-07-26 23:29 ` Miquel Raynal
2018-07-26 23:30 ` Miquel Raynal
4 siblings, 1 reply; 8+ messages in thread
From: Miquel Raynal @ 2018-07-26 23:29 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, linux-mtd, David Woodhouse, Brian Norris,
Marek Vasut
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Fri, 20 Jul 2018
11:57:37 +0200:
> Hello,
>
> The fix I sent here [1] lead me to look at other places including gpio.h
> in the MTD subsystem. While some inclusions are valid, some of them can
> be removed of replaced by gpio/consumer.h.
>
> All these changes have been compile-tested.
>
> Regards,
>
> Boris
>
> [1]http://patchwork.ozlabs.org/patch/946614/
>
> Boris Brezillon (4):
> mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions
> mtd: rawnand: atmel: Stop including gpio.h
> mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion
> mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h
>
> drivers/mtd/nand/raw/atmel/nand-controller.c | 1 -
> drivers/mtd/nand/raw/au1550nd.c | 1 -
> drivers/mtd/nand/raw/sunxi_nand.c | 2 --
> drivers/mtd/spi-nor/atmel-quadspi.c | 2 +-
> 4 files changed, 1 insertion(+), 5 deletions(-)
>
Series applied to nand/next.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] mtd: Remove gpio.h inclusions where we can
2018-07-26 23:29 ` [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Miquel Raynal
@ 2018-07-26 23:30 ` Miquel Raynal
0 siblings, 0 replies; 8+ messages in thread
From: Miquel Raynal @ 2018-07-26 23:30 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, linux-mtd, David Woodhouse, Brian Norris,
Marek Vasut
Hi Miquel,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Fri, 27 Jul 2018
01:29:15 +0200:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@bootlin.com> wrote on Fri, 20 Jul 2018
> 11:57:37 +0200:
>
> > Hello,
> >
> > The fix I sent here [1] lead me to look at other places including gpio.h
> > in the MTD subsystem. While some inclusions are valid, some of them can
> > be removed of replaced by gpio/consumer.h.
> >
> > All these changes have been compile-tested.
> >
> > Regards,
> >
> > Boris
> >
> > [1]http://patchwork.ozlabs.org/patch/946614/
> >
> > Boris Brezillon (4):
> > mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions
> > mtd: rawnand: atmel: Stop including gpio.h
> > mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion
> > mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h
> >
> > drivers/mtd/nand/raw/atmel/nand-controller.c | 1 -
> > drivers/mtd/nand/raw/au1550nd.c | 1 -
> > drivers/mtd/nand/raw/sunxi_nand.c | 2 --
> > drivers/mtd/spi-nor/atmel-quadspi.c | 2 +-
> > 4 files changed, 1 insertion(+), 5 deletions(-)
> >
>
> Series applied to nand/next.
Of course I was speaking about patches 1,2,3 only.
>
> Thanks,
> Miquèl
--
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4/4] mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h
2018-07-20 9:57 ` [PATCH 4/4] mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h Boris Brezillon
@ 2018-07-27 7:48 ` Boris Brezillon
0 siblings, 0 replies; 8+ messages in thread
From: Boris Brezillon @ 2018-07-27 7:48 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd,
David Woodhouse, Brian Norris, Marek Vasut
On Fri, 20 Jul 2018 11:57:41 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> GPIO consumers now include <linux/gpio/consumer.h> instead of
> <linux/gpio.h> if they can.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Applied.
> ---
> drivers/mtd/spi-nor/atmel-quadspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c b/drivers/mtd/spi-nor/atmel-quadspi.c
> index 6c5708bacad8..ce65c2b53ac1 100644
> --- a/drivers/mtd/spi-nor/atmel-quadspi.c
> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c
> @@ -34,7 +34,7 @@
> #include <linux/of.h>
>
> #include <linux/io.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>
> /* QSPI register offsets */
> #define QSPI_CR 0x0000 /* Control Register */
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-07-27 7:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-20 9:57 [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Boris Brezillon
2018-07-20 9:57 ` [PATCH 1/4] mtd: rawnand: sunxi: Remove gpio.h and of_gpio.h inclusions Boris Brezillon
2018-07-20 9:57 ` [PATCH 2/4] mtd: rawnand: atmel: Stop including gpio.h Boris Brezillon
2018-07-20 9:57 ` [PATCH 3/4] mtd: rawnand: au1550nd: Remove unneeded gpio.h inclusion Boris Brezillon
2018-07-20 9:57 ` [PATCH 4/4] mtd: spi-nor: atmel-qspi: Include gpio/consumer.h instead of gpio.h Boris Brezillon
2018-07-27 7:48 ` Boris Brezillon
2018-07-26 23:29 ` [PATCH 0/4] mtd: Remove gpio.h inclusions where we can Miquel Raynal
2018-07-26 23:30 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.