From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 2/4] cmd: nvedit: propagate envflag to set_default_vars
Date: Fri, 20 Jul 2018 08:35:09 -0400 [thread overview]
Message-ID: <20180720123509.GF11755@bill-the-cat> (raw)
In-Reply-To: <20180624161657.32632-3-yaniv.levinsky@compulab.co.il>
On Sun, Jun 24, 2018 at 07:16:55PM +0300, Yaniv Levinsky wrote:
> The env_flag in do_env_default() doesn't get propagated and therefore
> gets ignored by himport_r(). This breaks to ability to "forcibly" reset
> variables to their default values using the environment command.
>
> Scenario example of the problem:
> # setenv kernel uImage
> # setenv .flags kernel:so
> # env default -f kernel
> ## Error: Can't overwrite "kernel"
> himport_r: can't insert "kernel=zImage" into hash table
>
> Change the call path so it will pass the flag correctly.
>
> Signed-off-by: Yaniv Levinsky <yaniv.levinsky@compulab.co.il>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180720/ead74cd0/attachment.sig>
next prev parent reply other threads:[~2018-07-20 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 16:16 [U-Boot] [PATCH 0/4] fix propagation of flags from do_env_default() Yaniv Levinsky
2018-06-24 16:16 ` [U-Boot] [PATCH 1/4] cmd: nvedit: rename flags in do_env_default Yaniv Levinsky
2018-07-20 12:35 ` [U-Boot] [U-Boot, " Tom Rini
2018-06-24 16:16 ` [U-Boot] [PATCH 2/4] cmd: nvedit: propagate envflag to set_default_vars Yaniv Levinsky
2018-07-20 12:35 ` Tom Rini [this message]
2018-06-24 16:16 ` [U-Boot] [PATCH 3/4] cmd: nvedit: set H_INTERACTIVE in do_env_default Yaniv Levinsky
2018-07-20 12:35 ` [U-Boot] [U-Boot, " Tom Rini
2018-06-24 16:16 ` [U-Boot] [PATCH 4/4] env: common: accept flags on reset to default env Yaniv Levinsky
2018-07-20 12:35 ` [U-Boot] [U-Boot, " Tom Rini
2018-07-11 15:21 ` [U-Boot] [PATCH 0/4] fix propagation of flags from do_env_default() Yaniv Levinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720123509.GF11755@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.