From: Segher Boessenkool <segher@kernel.crashing.org>
To: Joe Perches <joe@perches.com>
Cc: Dirk Gouders <dirk@gouders.net>,
Andy Whitcroft <apw@canonical.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: kbuild: if_changed: check for multiple calls in targets
Date: Fri, 20 Jul 2018 10:21:50 -0500 [thread overview]
Message-ID: <20180720152150.GB16221@gate.crashing.org> (raw)
In-Reply-To: <01cfa83d2e29667d311d679c904b1648cd35c614.camel@perches.com>
On Fri, Jul 20, 2018 at 03:06:37AM -0700, Joe Perches wrote:
> On Fri, 2018-07-20 at 09:48 +0200, Dirk Gouders wrote:
> > + # Check for multiple calls of if_changed within a target in Makefiles
> > + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
>
> The uses of .* here are superfluous.
And it looks like you wanted to match this only at the beginning of the
string, which would be /^Makefile/ etc.
Segher
next prev parent reply other threads:[~2018-07-20 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 12:39 [PATCH] checkpatch: if_changed: check for multiple calls in targets Dirk Gouders
2018-07-16 15:23 ` Joe Perches
2018-07-17 9:32 ` Dirk Gouders
2018-07-20 7:48 ` [PATCH v2] checkpatch: kbuild: " Dirk Gouders
2018-07-20 10:06 ` Joe Perches
2018-07-20 15:21 ` Segher Boessenkool [this message]
2018-07-20 15:33 ` Joe Perches
2018-07-20 15:44 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720152150.GB16221@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=apw@canonical.com \
--cc=dirk@gouders.net \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.