From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] pinctrl: stm32: fix bank io port number Date: Fri, 20 Jul 2018 10:35:15 -0600 Message-ID: <20180720163515.GA16515@rob-hp-laptop> References: <1531745857-5561-1-git-send-email-alexandre.torgue@st.com> <1531745857-5561-2-git-send-email-alexandre.torgue@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1531745857-5561-2-git-send-email-alexandre.torgue@st.com> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Torgue Cc: Linus Walleij , Maxime Coquelin , Mark Rutland , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, amelie.delaunay@st.com List-Id: linux-gpio@vger.kernel.org On Mon, Jul 16, 2018 at 02:57:36PM +0200, Alexandre Torgue wrote: > In case the exti line is not in line with the bank number (that is the case > when there is an hole between two banks, for example GPIOK and then GPIOZ), > use "st,bank-ioport" DT property to get the right exti line. > > Signed-off-by: Amelie Delaunay > Signed-off-by: Alexandre Torgue > > diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt > index 9a06e1f..60c678a 100644 > --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt > @@ -55,6 +55,8 @@ Optional properties: > NOTE: If "gpio-ranges" is used for a gpio controller, all gpio-controller > have to use a "gpio-ranges" entry. > More details in Documentation/devicetree/bindings/gpio/gpio.txt. > + - st,bank-ioport: should correspond to the EXTI IOport selection (EXTI line > + used to select GPIOs as interrupts). ioport sounds like something else. Perhaps '-exti-line'? > > Example 1: > #include From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Fri, 20 Jul 2018 10:35:15 -0600 Subject: [PATCH 1/2] pinctrl: stm32: fix bank io port number In-Reply-To: <1531745857-5561-2-git-send-email-alexandre.torgue@st.com> References: <1531745857-5561-1-git-send-email-alexandre.torgue@st.com> <1531745857-5561-2-git-send-email-alexandre.torgue@st.com> Message-ID: <20180720163515.GA16515@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jul 16, 2018 at 02:57:36PM +0200, Alexandre Torgue wrote: > In case the exti line is not in line with the bank number (that is the case > when there is an hole between two banks, for example GPIOK and then GPIOZ), > use "st,bank-ioport" DT property to get the right exti line. > > Signed-off-by: Amelie Delaunay > Signed-off-by: Alexandre Torgue > > diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt > index 9a06e1f..60c678a 100644 > --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt > @@ -55,6 +55,8 @@ Optional properties: > NOTE: If "gpio-ranges" is used for a gpio controller, all gpio-controller > have to use a "gpio-ranges" entry. > More details in Documentation/devicetree/bindings/gpio/gpio.txt. > + - st,bank-ioport: should correspond to the EXTI IOport selection (EXTI line > + used to select GPIOs as interrupts). ioport sounds like something else. Perhaps '-exti-line'? > > Example 1: > #include