From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A555ECDE5F for ; Sat, 21 Jul 2018 16:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C06EF20854 for ; Sat, 21 Jul 2018 16:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C06EF20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbeGURvJ (ORCPT ); Sat, 21 Jul 2018 13:51:09 -0400 Received: from mail.bootlin.com ([62.4.15.54]:48901 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727737AbeGURvJ (ORCPT ); Sat, 21 Jul 2018 13:51:09 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 9574320737; Sat, 21 Jul 2018 18:57:45 +0200 (CEST) Received: from bbrezillon (unknown [37.173.79.60]) by mail.bootlin.com (Postfix) with ESMTPSA id 73F2D206F3; Sat, 21 Jul 2018 18:57:40 +0200 (CEST) Date: Sat, 21 Jul 2018 18:57:37 +0200 From: Boris Brezillon To: Miquel Raynal Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 13/35] mtd: rawnand: marvell: convert driver to nand_scan() Message-ID: <20180721185537.01f01362@bbrezillon> In-Reply-To: <20180720151527.16038-14-miquel.raynal@bootlin.com> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-14-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jul 2018 17:15:05 +0200 Miquel Raynal wrote: > > - ret = nand_scan_tail(mtd); > + chip->controller->ops = &marvell_nand_controller_ops; Assigning ->ops to &marvell_nand_controller_ops should be done only once in the probe function (here [1]). With that fixed, you can add Reviewed-by: Boris Brezillon > + ret = nand_scan(mtd, marvell_nand->nsels); > if (ret) { > - dev_err(dev, "nand_scan_tail failed: %d\n", ret); > + dev_err(dev, "could not scan the nand chip\n"); > return ret; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v4 13/35] mtd: rawnand: marvell: convert driver to nand_scan() Date: Sat, 21 Jul 2018 18:57:37 +0200 Message-ID: <20180721185537.01f01362@bbrezillon> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-14-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180720151527.16038-14-miquel.raynal@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Alexandre Belloni , Mans Rullgard , Maxime Ripard , Stefan Agner , linux-kernel@vger.kernel.org, Masahiro Yamada , linux-mtd@lists.infradead.org, Kamal Dasu , Josh Wu , Marc Gonzalez , Marek Vasut , Chen-Yu Tsai , bcm-kernel-feedback-list@broadcom.com, Sylvain Lemieux , Wenyou Yang , Tudor Ambarus , Vladimir Zapolskiy , Harvey Hunt , linux-mediatek@lists.infradead.org, Matthias Brugger , Han Xu , Xiaolei Li , linux-arm-kernel@lists.infradead.org, Richard List-Id: linux-mediatek@lists.infradead.org On Fri, 20 Jul 2018 17:15:05 +0200 Miquel Raynal wrote: > > - ret = nand_scan_tail(mtd); > + chip->controller->ops = &marvell_nand_controller_ops; Assigning ->ops to &marvell_nand_controller_ops should be done only once in the probe function (here [1]). With that fixed, you can add Reviewed-by: Boris Brezillon > + ret = nand_scan(mtd, marvell_nand->nsels); > if (ret) { > - dev_err(dev, "nand_scan_tail failed: %d\n", ret); > + dev_err(dev, "could not scan the nand chip\n"); > return ret; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Sat, 21 Jul 2018 18:57:37 +0200 Subject: [PATCH v4 13/35] mtd: rawnand: marvell: convert driver to nand_scan() In-Reply-To: <20180720151527.16038-14-miquel.raynal@bootlin.com> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-14-miquel.raynal@bootlin.com> Message-ID: <20180721185537.01f01362@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 20 Jul 2018 17:15:05 +0200 Miquel Raynal wrote: > > - ret = nand_scan_tail(mtd); > + chip->controller->ops = &marvell_nand_controller_ops; Assigning ->ops to &marvell_nand_controller_ops should be done only once in the probe function (here [1]). With that fixed, you can add Reviewed-by: Boris Brezillon > + ret = nand_scan(mtd, marvell_nand->nsels); > if (ret) { > - dev_err(dev, "nand_scan_tail failed: %d\n", ret); > + dev_err(dev, "could not scan the nand chip\n"); > return ret; > } >