From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B8FECDFBB for ; Sat, 21 Jul 2018 17:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEE1A20854 for ; Sat, 21 Jul 2018 17:21:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEE1A20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728156AbeGUSPJ (ORCPT ); Sat, 21 Jul 2018 14:15:09 -0400 Received: from mail.bootlin.com ([62.4.15.54]:49351 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727483AbeGUSPJ (ORCPT ); Sat, 21 Jul 2018 14:15:09 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id B19DC20737; Sat, 21 Jul 2018 19:21:41 +0200 (CEST) Received: from bbrezillon (unknown [37.173.79.60]) by mail.bootlin.com (Postfix) with ESMTPSA id 8ADDC207B4; Sat, 21 Jul 2018 19:21:24 +0200 (CEST) Date: Sat, 21 Jul 2018 19:21:01 +0200 From: Boris Brezillon To: Miquel Raynal Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 16/35] mtd: rawnand: nandsim: convert driver to nand_scan() Message-ID: <20180721192101.0e0d1860@bbrezillon> In-Reply-To: <20180720151527.16038-17-miquel.raynal@bootlin.com> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-17-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jul 2018 17:15:08 +0200 Miquel Raynal wrote: > Two helpers have been added to the core to make ECC-related > configuration between the detection phase and the final NAND scan. Use > these hooks and convert the driver to just use nand_scan() instead of > both nand_scan_ident() and nand_scan_tail(). > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nandsim.c | 82 +++++++++++++++++++++++------------------- > 1 file changed, 45 insertions(+), 37 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c > index 8a3b36cfe5ea..71ac034aee9c 100644 > --- a/drivers/mtd/nand/raw/nandsim.c > +++ b/drivers/mtd/nand/raw/nandsim.c > @@ -2192,6 +2192,48 @@ static void ns_nand_read_buf(struct mtd_info *mtd, u_char *buf, int len) > return; > } > > +static int ns_attach_chip(struct nand_chip *chip) > +{ > + unsigned int eccsteps, eccbytes; > + > + if (!bch) > + return 0; > + > + if (!mtd_nand_has_bch()) { > + NS_ERR("BCH ECC support is disabled\n"); > + return -EINVAL; > + } > + > + /* Use 512-byte ecc blocks */ > + eccsteps = nsmtd->writesize / 512; > + eccbytes = ((bch * 13) + 7) / 8; > + > + /* Do not bother supporting small page devices */ > + if (nsmtd->oobsize < 64 || !eccsteps) { > + NS_ERR("BCH not available on small page devices\n"); > + return -EINVAL; > + } > + > + if (((eccbytes * eccsteps) + 2) > nsmtd->oobsize) { > + NS_ERR("Invalid BCH value %u\n", bch); > + return -EINVAL; > + } > + > + chip->ecc.mode = NAND_ECC_SOFT; > + chip->ecc.algo = NAND_ECC_BCH; > + chip->ecc.size = 512; > + chip->ecc.strength = bch; > + chip->ecc.bytes = eccbytes; > + > + NS_INFO("Using %u-bit/%u bytes BCH ECC\n", bch, chip->ecc.size); > + > + return 0; > +} > + > +static const struct nand_controller_ops ns_controller_ops = { > + .attach_chip = ns_attach_chip, > +}; > + > /* > * Module initialization function > */ > @@ -2276,44 +2318,10 @@ static int __init ns_init_module(void) > if ((retval = parse_gravepages()) != 0) > goto error; > > - retval = nand_scan_ident(nsmtd, 1, NULL); > + chip->dummy_controller.ops = &ns_controller_ops; > + retval = nand_scan(nsmtd, 1); > if (retval) { > - NS_ERR("cannot scan NAND Simulator device\n"); > - goto error; > - } > - > - if (bch) { > - unsigned int eccsteps, eccbytes; > - if (!mtd_nand_has_bch()) { > - NS_ERR("BCH ECC support is disabled\n"); > - retval = -EINVAL; > - goto error; > - } > - /* use 512-byte ecc blocks */ > - eccsteps = nsmtd->writesize/512; > - eccbytes = (bch*13+7)/8; > - /* do not bother supporting small page devices */ > - if ((nsmtd->oobsize < 64) || !eccsteps) { > - NS_ERR("bch not available on small page devices\n"); > - retval = -EINVAL; > - goto error; > - } > - if ((eccbytes*eccsteps+2) > nsmtd->oobsize) { > - NS_ERR("invalid bch value %u\n", bch); > - retval = -EINVAL; > - goto error; > - } > - chip->ecc.mode = NAND_ECC_SOFT; > - chip->ecc.algo = NAND_ECC_BCH; > - chip->ecc.size = 512; > - chip->ecc.strength = bch; > - chip->ecc.bytes = eccbytes; > - NS_INFO("using %u-bit/%u bytes BCH ECC\n", bch, chip->ecc.size); > - } > - > - retval = nand_scan_tail(nsmtd); > - if (retval) { > - NS_ERR("can't register NAND Simulator\n"); > + NS_ERR("Could not scan NAND Simulator device\n"); > goto error; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v4 16/35] mtd: rawnand: nandsim: convert driver to nand_scan() Date: Sat, 21 Jul 2018 19:21:01 +0200 Message-ID: <20180721192101.0e0d1860@bbrezillon> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-17-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180720151527.16038-17-miquel.raynal@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai List-Id: linux-mediatek@lists.infradead.org On Fri, 20 Jul 2018 17:15:08 +0200 Miquel Raynal wrote: > Two helpers have been added to the core to make ECC-related > configuration between the detection phase and the final NAND scan. Use > these hooks and convert the driver to just use nand_scan() instead of > both nand_scan_ident() and nand_scan_tail(). > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nandsim.c | 82 +++++++++++++++++++++++------------------- > 1 file changed, 45 insertions(+), 37 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c > index 8a3b36cfe5ea..71ac034aee9c 100644 > --- a/drivers/mtd/nand/raw/nandsim.c > +++ b/drivers/mtd/nand/raw/nandsim.c > @@ -2192,6 +2192,48 @@ static void ns_nand_read_buf(struct mtd_info *mtd, u_char *buf, int len) > return; > } > > +static int ns_attach_chip(struct nand_chip *chip) > +{ > + unsigned int eccsteps, eccbytes; > + > + if (!bch) > + return 0; > + > + if (!mtd_nand_has_bch()) { > + NS_ERR("BCH ECC support is disabled\n"); > + return -EINVAL; > + } > + > + /* Use 512-byte ecc blocks */ > + eccsteps = nsmtd->writesize / 512; > + eccbytes = ((bch * 13) + 7) / 8; > + > + /* Do not bother supporting small page devices */ > + if (nsmtd->oobsize < 64 || !eccsteps) { > + NS_ERR("BCH not available on small page devices\n"); > + return -EINVAL; > + } > + > + if (((eccbytes * eccsteps) + 2) > nsmtd->oobsize) { > + NS_ERR("Invalid BCH value %u\n", bch); > + return -EINVAL; > + } > + > + chip->ecc.mode = NAND_ECC_SOFT; > + chip->ecc.algo = NAND_ECC_BCH; > + chip->ecc.size = 512; > + chip->ecc.strength = bch; > + chip->ecc.bytes = eccbytes; > + > + NS_INFO("Using %u-bit/%u bytes BCH ECC\n", bch, chip->ecc.size); > + > + return 0; > +} > + > +static const struct nand_controller_ops ns_controller_ops = { > + .attach_chip = ns_attach_chip, > +}; > + > /* > * Module initialization function > */ > @@ -2276,44 +2318,10 @@ static int __init ns_init_module(void) > if ((retval = parse_gravepages()) != 0) > goto error; > > - retval = nand_scan_ident(nsmtd, 1, NULL); > + chip->dummy_controller.ops = &ns_controller_ops; > + retval = nand_scan(nsmtd, 1); > if (retval) { > - NS_ERR("cannot scan NAND Simulator device\n"); > - goto error; > - } > - > - if (bch) { > - unsigned int eccsteps, eccbytes; > - if (!mtd_nand_has_bch()) { > - NS_ERR("BCH ECC support is disabled\n"); > - retval = -EINVAL; > - goto error; > - } > - /* use 512-byte ecc blocks */ > - eccsteps = nsmtd->writesize/512; > - eccbytes = (bch*13+7)/8; > - /* do not bother supporting small page devices */ > - if ((nsmtd->oobsize < 64) || !eccsteps) { > - NS_ERR("bch not available on small page devices\n"); > - retval = -EINVAL; > - goto error; > - } > - if ((eccbytes*eccsteps+2) > nsmtd->oobsize) { > - NS_ERR("invalid bch value %u\n", bch); > - retval = -EINVAL; > - goto error; > - } > - chip->ecc.mode = NAND_ECC_SOFT; > - chip->ecc.algo = NAND_ECC_BCH; > - chip->ecc.size = 512; > - chip->ecc.strength = bch; > - chip->ecc.bytes = eccbytes; > - NS_INFO("using %u-bit/%u bytes BCH ECC\n", bch, chip->ecc.size); > - } > - > - retval = nand_scan_tail(nsmtd); > - if (retval) { > - NS_ERR("can't register NAND Simulator\n"); > + NS_ERR("Could not scan NAND Simulator device\n"); > goto error; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Sat, 21 Jul 2018 19:21:01 +0200 Subject: [PATCH v4 16/35] mtd: rawnand: nandsim: convert driver to nand_scan() In-Reply-To: <20180720151527.16038-17-miquel.raynal@bootlin.com> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-17-miquel.raynal@bootlin.com> Message-ID: <20180721192101.0e0d1860@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 20 Jul 2018 17:15:08 +0200 Miquel Raynal wrote: > Two helpers have been added to the core to make ECC-related > configuration between the detection phase and the final NAND scan. Use > these hooks and convert the driver to just use nand_scan() instead of > both nand_scan_ident() and nand_scan_tail(). > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nandsim.c | 82 +++++++++++++++++++++++------------------- > 1 file changed, 45 insertions(+), 37 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c > index 8a3b36cfe5ea..71ac034aee9c 100644 > --- a/drivers/mtd/nand/raw/nandsim.c > +++ b/drivers/mtd/nand/raw/nandsim.c > @@ -2192,6 +2192,48 @@ static void ns_nand_read_buf(struct mtd_info *mtd, u_char *buf, int len) > return; > } > > +static int ns_attach_chip(struct nand_chip *chip) > +{ > + unsigned int eccsteps, eccbytes; > + > + if (!bch) > + return 0; > + > + if (!mtd_nand_has_bch()) { > + NS_ERR("BCH ECC support is disabled\n"); > + return -EINVAL; > + } > + > + /* Use 512-byte ecc blocks */ > + eccsteps = nsmtd->writesize / 512; > + eccbytes = ((bch * 13) + 7) / 8; > + > + /* Do not bother supporting small page devices */ > + if (nsmtd->oobsize < 64 || !eccsteps) { > + NS_ERR("BCH not available on small page devices\n"); > + return -EINVAL; > + } > + > + if (((eccbytes * eccsteps) + 2) > nsmtd->oobsize) { > + NS_ERR("Invalid BCH value %u\n", bch); > + return -EINVAL; > + } > + > + chip->ecc.mode = NAND_ECC_SOFT; > + chip->ecc.algo = NAND_ECC_BCH; > + chip->ecc.size = 512; > + chip->ecc.strength = bch; > + chip->ecc.bytes = eccbytes; > + > + NS_INFO("Using %u-bit/%u bytes BCH ECC\n", bch, chip->ecc.size); > + > + return 0; > +} > + > +static const struct nand_controller_ops ns_controller_ops = { > + .attach_chip = ns_attach_chip, > +}; > + > /* > * Module initialization function > */ > @@ -2276,44 +2318,10 @@ static int __init ns_init_module(void) > if ((retval = parse_gravepages()) != 0) > goto error; > > - retval = nand_scan_ident(nsmtd, 1, NULL); > + chip->dummy_controller.ops = &ns_controller_ops; > + retval = nand_scan(nsmtd, 1); > if (retval) { > - NS_ERR("cannot scan NAND Simulator device\n"); > - goto error; > - } > - > - if (bch) { > - unsigned int eccsteps, eccbytes; > - if (!mtd_nand_has_bch()) { > - NS_ERR("BCH ECC support is disabled\n"); > - retval = -EINVAL; > - goto error; > - } > - /* use 512-byte ecc blocks */ > - eccsteps = nsmtd->writesize/512; > - eccbytes = (bch*13+7)/8; > - /* do not bother supporting small page devices */ > - if ((nsmtd->oobsize < 64) || !eccsteps) { > - NS_ERR("bch not available on small page devices\n"); > - retval = -EINVAL; > - goto error; > - } > - if ((eccbytes*eccsteps+2) > nsmtd->oobsize) { > - NS_ERR("invalid bch value %u\n", bch); > - retval = -EINVAL; > - goto error; > - } > - chip->ecc.mode = NAND_ECC_SOFT; > - chip->ecc.algo = NAND_ECC_BCH; > - chip->ecc.size = 512; > - chip->ecc.strength = bch; > - chip->ecc.bytes = eccbytes; > - NS_INFO("using %u-bit/%u bytes BCH ECC\n", bch, chip->ecc.size); > - } > - > - retval = nand_scan_tail(nsmtd); > - if (retval) { > - NS_ERR("can't register NAND Simulator\n"); > + NS_ERR("Could not scan NAND Simulator device\n"); > goto error; > } >