From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 704E7ECDFB8 for ; Sun, 22 Jul 2018 09:31:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C88F520858 for ; Sun, 22 Jul 2018 09:31:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C88F520858 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728443AbeGVK1Q (ORCPT ); Sun, 22 Jul 2018 06:27:16 -0400 Received: from mail.bootlin.com ([62.4.15.54]:59706 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728020AbeGVK1P (ORCPT ); Sun, 22 Jul 2018 06:27:15 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 5D410207B4; Sun, 22 Jul 2018 11:31:09 +0200 (CEST) Received: from bbrezillon (unknown [37.173.49.123]) by mail.bootlin.com (Postfix) with ESMTPSA id 75F98207A8; Sun, 22 Jul 2018 11:31:07 +0200 (CEST) Date: Sun, 22 Jul 2018 11:31:06 +0200 From: Boris Brezillon To: Miquel Raynal Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Stefan Agner , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 32/35] mtd: rawnand: tegra: convert driver to nand_scan() Message-ID: <20180722113106.45c11ecb@bbrezillon> In-Reply-To: <20180720151527.16038-33-miquel.raynal@bootlin.com> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-33-miquel.raynal@bootlin.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jul 2018 17:15:24 +0200 Miquel Raynal wrote: > + chip = &nand->chip; > + chip->controller = &ctrl->controller; > + chip->controller->ops = &tegra_nand_controller_ops; Should be moved next to the controller initialization. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v4 32/35] mtd: rawnand: tegra: convert driver to nand_scan() Date: Sun, 22 Jul 2018 11:31:06 +0200 Message-ID: <20180722113106.45c11ecb@bbrezillon> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-33-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180720151527.16038-33-miquel.raynal@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: Wenyou Yang , Josh Wu , Tudor Ambarus , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Nicolas Ferre , Alexandre Belloni , Kamal Dasu , Masahiro Yamada , Han Xu , Harvey Hunt , Vladimir Zapolskiy , Sylvain Lemieux , Xiaolei Li , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai List-Id: linux-mediatek@lists.infradead.org On Fri, 20 Jul 2018 17:15:24 +0200 Miquel Raynal wrote: > + chip = &nand->chip; > + chip->controller = &ctrl->controller; > + chip->controller->ops = &tegra_nand_controller_ops; Should be moved next to the controller initialization. From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Sun, 22 Jul 2018 11:31:06 +0200 Subject: [PATCH v4 32/35] mtd: rawnand: tegra: convert driver to nand_scan() In-Reply-To: <20180720151527.16038-33-miquel.raynal@bootlin.com> References: <20180720151527.16038-1-miquel.raynal@bootlin.com> <20180720151527.16038-33-miquel.raynal@bootlin.com> Message-ID: <20180722113106.45c11ecb@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 20 Jul 2018 17:15:24 +0200 Miquel Raynal wrote: > + chip = &nand->chip; > + chip->controller = &ctrl->controller; > + chip->controller->ops = &tegra_nand_controller_ops; Should be moved next to the controller initialization.