All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ka-cheong.poon@oracle.com
Cc: netdev@vger.kernel.org, santosh.shilimkar@oracle.com,
	rds-devel@oss.oracle.com, sowmini.varadhan@oracle.com
Subject: Re: [PATCH v4 net-next 2/3] rds: Enable RDS IPv6 support
Date: Mon, 23 Jul 2018 11:15:45 -0700 (PDT)	[thread overview]
Message-ID: <20180723.111545.2052989865778508499.davem@davemloft.net> (raw)
In-Reply-To: <4dc7ee44840f6166cec8847aefc2bc51e072a7ac.1532318752.git.ka-cheong.poon@oracle.com>

From: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Date: Mon, 23 Jul 2018 07:16:11 -0700

> @@ -163,15 +165,29 @@ int rds_tcp_accept_one(struct socket *sock)
>  
>  	inet = inet_sk(new_sock->sk);
>  
> +	my_addr = &new_sock->sk->sk_v6_rcv_saddr;
> +	peer_addr = &new_sock->sk->sk_v6_daddr,
>  	rdsdebug("accepted tcp %pI6c:%u -> %pI6c:%u\n",

Note that comma, instead of a semicolon, at the end of the peer_addr
assignment.

This doesn't even compile.

  parent reply	other threads:[~2018-07-23 19:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 14:16 [PATCH v4 net-next 0/3] rds: IPv6 support Ka-Cheong Poon
2018-07-23 14:16 ` [PATCH v4 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr Ka-Cheong Poon
2018-07-23 16:54   ` Santosh Shilimkar
2018-07-23 14:16 ` [PATCH v4 net-next 2/3] rds: Enable RDS IPv6 support Ka-Cheong Poon
2018-07-23 16:55   ` Santosh Shilimkar
2018-07-23 18:15   ` David Miller [this message]
2018-07-24  3:18     ` Ka-Cheong Poon
2018-07-24  3:20       ` David Miller
2018-07-24  3:37         ` Ka-Cheong Poon
2018-07-23 14:16 ` [PATCH v4 net-next 3/3] rds: Extend RDS API for " Ka-Cheong Poon
2018-07-23 16:55   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723.111545.2052989865778508499.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ka-cheong.poon@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    --cc=sowmini.varadhan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.