From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 4/5] compress/zlib: support burst
 enqueue/dequeue
Date: Mon, 23 Jul 2018 10:35:57 -0700
Message-ID: <20180723103557.0c94c4a5@xeon-e3>
References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com>
 <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com>
 <20180723095357.5a85b206@xeon-e3>
 <CY4PR0701MB3634D6C72203CEC71EC6EF4EF0560@CY4PR0701MB3634.namprd07.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Athreya, Narayana Prasad"
 <NarayanaPrasad.Athreya@cavium.com>, "Challa, Mahipal"
 <Mahipal.Challa@cavium.com>, "Gupta, Ashish" <Ashish.Gupta@cavium.com>,
 "Sahu, Sunila" <Sunila.Sahu@cavium.com>
To: "Verma, Shally" <Shally.Verma@cavium.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com
 [209.85.215.179]) by dpdk.org (Postfix) with ESMTP id 5215A235
 for <dev@dpdk.org>; Mon, 23 Jul 2018 19:36:01 +0200 (CEST)
Received: by mail-pg1-f179.google.com with SMTP id x5-v6so875897pgp.7
 for <dev@dpdk.org>; Mon, 23 Jul 2018 10:36:01 -0700 (PDT)
In-Reply-To: <CY4PR0701MB3634D6C72203CEC71EC6EF4EF0560@CY4PR0701MB3634.namprd07.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 23 Jul 2018 17:14:26 +0000
"Verma, Shally" <Shally.Verma@cavium.com> wrote:

> >-----Original Message-----
> >From: Stephen Hemminger <stephen@networkplumber.org>
> >Sent: 23 July 2018 22:24
> >To: Verma, Shally <Shally.Verma@cavium.com>
> >Cc: pablo.de.lara.guarch@intel.com; dev@dpdk.org; Athreya, Narayana Prasad <NarayanaPrasad.Athreya@cavium.com>; Challa,
> >Mahipal <Mahipal.Challa@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>;
> >Sahu, Sunila <Sunila.Sahu@cavium.com>
> >Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
> >
> >External Email
> >
> >On Sat, 21 Jul 2018 23:47:48 +0530
> >Shally Verma <shally.verma@caviumnetworks.com> wrote:
> >  
> >> -/** Parse comp xform and set private xform/stream parameters */
> >> +/** Compute next mbuf in the list, assign data buffer and length,
> >> + *  returns 0 if mbuf is NULL
> >> + */
> >> +#define COMPUTE_BUF(mbuf, data, len)         \
> >> +             ((mbuf = mbuf->next) ?          \
> >> +             (data = rte_pktmbuf_mtod(mbuf, uint8_t *)),     \
> >> +             (len = rte_pktmbuf_data_len(mbuf)) : 0)
> >> +  
> >
> >Could this be an inline not a macro?  
> [Shally] Again what goes in favour of inline here? Just curious to know if DPDK has any preferred guidelines regarding this?
> 
> Thanks
> Shally 


Macros have no type checking and are harder to debug.
They should only be used when doing generic code (ie template like).