From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@linux.intel.com
Cc: tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org, acme@kernel.org,
alexander.shishkin@linux.intel.com, vincent.weaver@maine.edu,
jolsa@redhat.com, ak@linux.intel.com
Subject: Re: [PATCH 3/4] perf/x86/intel/ds: Handle PEBS overflow for fixed counters
Date: Mon, 23 Jul 2018 17:02:17 +0200 [thread overview]
Message-ID: <20180723150217.GC2512@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180723145944.GB2458@hirez.programming.kicks-ass.net>
On Mon, Jul 23, 2018 at 04:59:44PM +0200, Peter Zijlstra wrote:
> On Thu, Mar 08, 2018 at 06:15:41PM -0800, kan.liang@linux.intel.com wrote:
> > diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
> > index ef47a418d819..86149b87cce8 100644
> > --- a/arch/x86/events/intel/core.c
> > +++ b/arch/x86/events/intel/core.c
> > @@ -2280,7 +2280,10 @@ static int intel_pmu_handle_irq(struct pt_regs *regs)
> > * counters from the GLOBAL_STATUS mask and we always process PEBS
> > * events via drain_pebs().
> > */
> > - status &= ~(cpuc->pebs_enabled & PEBS_COUNTER_MASK);
> > + if (x86_pmu.flags & PMU_FL_PEBS_ALL)
> > + status &= ~(cpuc->pebs_enabled & EXTENDED_PEBS_COUNTER_MASK);
> > + else
> > + status &= ~(cpuc->pebs_enabled & PEBS_COUNTER_MASK);
> >
> > /*
> > * PEBS overflow sets bit 62 in the global status register
>
> Doesn't this re-introduce the problem fixed in commit fd583ad1563be,
> where pebs_enabled:32-34 are PEBS Load Latency, instead of fixed
> counters?
*GROAN* the MSR definitions now differ between Core and Atom :-(
next prev parent reply other threads:[~2018-07-23 15:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 2:15 [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS kan.liang
2018-03-09 2:15 ` [PATCH 2/4] x86/perf/intel: Support PEBS on fixed counters kan.liang
2018-07-25 14:32 ` [tip:perf/core] perf/x86/intel: " tip-bot for Kan Liang
2018-03-09 2:15 ` [PATCH 3/4] perf/x86/intel/ds: Handle PEBS overflow for " kan.liang
2018-07-23 14:59 ` Peter Zijlstra
2018-07-23 15:02 ` Peter Zijlstra [this message]
2018-07-23 16:21 ` Peter Zijlstra
2018-07-23 16:56 ` Liang, Kan
2018-07-23 17:15 ` Liang, Kan
2018-07-25 14:33 ` [tip:perf/core] " tip-bot for Kan Liang
2018-03-09 2:15 ` [PATCH 4/4] perf/x86/intel: Support Extended PEBS for Goldmont Plus kan.liang
2018-07-25 14:33 ` [tip:perf/core] " tip-bot for Kan Liang
2018-07-23 15:16 ` [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS Peter Zijlstra
2018-07-23 15:43 ` Liang, Kan
2018-07-23 15:50 ` Peter Zijlstra
2018-07-25 14:31 ` [tip:perf/core] perf/x86/intel: " tip-bot for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723150217.GC2512@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.