From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/1] tst_test.sh: Add test cmd helper tst_test_cmds()
Date: Tue, 24 Jul 2018 15:15:51 +0200 [thread overview]
Message-ID: <20180724131551.GA30730@rei> (raw)
In-Reply-To: <20180724125708.GA5894@x230>
Hi!
> > Hmm looking at this after a while I would expect the tst_test_cmds() to
> > exit the test while tst_check_cmds() to return a value, the question is
> > if this is worth of the work of renaming the current uses...
> Indeed, names would be better to be reversed. It's up to you.
> If you want, I'll first rename tst_check_cmds() to tst_test_cmds()
> and then add this new one as tst_check_cmds().
If it's easy enough, let's do that, otherwise I would keep it as it is.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-07-24 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 9:17 [LTP] [PATCH v2 1/1] tst_test.sh: Add test cmd helper tst_test_cmds() Petr Vorel
2018-06-01 9:42 ` Petr Vorel
2018-07-24 9:35 ` Cyril Hrubis
2018-07-24 12:57 ` Petr Vorel
2018-07-24 13:15 ` Cyril Hrubis [this message]
2018-07-24 15:19 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724131551.GA30730@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.