All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)
Date: Tue, 24 Jul 2018 11:35:17 -0500	[thread overview]
Message-ID: <20180724163517.flt3pmdphvsqbegc@treble> (raw)
In-Reply-To: <20180723141427.GA2458@hirez.programming.kicks-ass.net>

On Mon, Jul 23, 2018 at 04:14:27PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 23, 2018 at 08:30:06AM -0500, Josh Poimboeuf wrote:
> > On Thu, Jul 19, 2018 at 11:19:54PM +0200, Peter Zijlstra wrote:
> > > --- a/include/uapi/linux/perf_event.h
> > > +++ b/include/uapi/linux/perf_event.h
> > > @@ -143,6 +143,8 @@ enum perf_event_sample_format {
> > >  	PERF_SAMPLE_PHYS_ADDR			= 1U << 19,
> > >  
> > >  	PERF_SAMPLE_MAX = 1U << 20,		/* non-ABI */
> > > +
> > > +	__PERF_SAMPLE_CALLCHAIN_EARLY		= 1UL << 63,
> > 
> > Given the kbuild test robot errors for building on 32-bit, looks like
> > the 63 needs to be changed to 31 so it fits in an int?
> 
> I made it 1ULL << 63. The actual field (perf_event_attr::sample_type is
> u64).

Ok, did you post this somewhere?

-- 
Josh

  reply	other threads:[~2018-07-24 16:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19  4:33 BUG: KASAN: stack-out-of-bounds in unwind_next_frame Prashant Bhole
2018-07-19 15:33 ` Josh Poimboeuf
2018-07-19 17:43   ` Peter Zijlstra
2018-07-19 21:19     ` [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II) Peter Zijlstra
2018-07-19 22:45       ` kbuild test robot
2018-07-19 23:54       ` kbuild test robot
2018-07-23 13:30       ` Josh Poimboeuf
2018-07-23 14:14         ` Peter Zijlstra
2018-07-24 16:35           ` Josh Poimboeuf [this message]
2018-08-06 15:35       ` Fubo Chen
2018-08-06 15:42         ` Peter Zijlstra
2018-08-06 16:54           ` Fubo Chen
2018-08-06 18:04             ` Peter Zijlstra
2018-08-06 21:28               ` Fubo Chen
2018-08-06 22:30                 ` Peter Zijlstra
2018-08-06 23:04                   ` Fubo Chen
2018-08-07  9:05                     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724163517.flt3pmdphvsqbegc@treble \
    --to=jpoimboe@redhat.com \
    --cc=bhole_prashant_q7@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.