From: Minchan Kim <minchan@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Tino Lehnig <tino.lehnig@contabo.de>,
ngupta@vflare.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process...
Date: Wed, 25 Jul 2018 11:16:57 +0900 [thread overview]
Message-ID: <20180725021657.GA87819@rodete-desktop-imager.corp.google.com> (raw)
In-Reply-To: <20180725015502.GA16271@bombadil.infradead.org>
On Tue, Jul 24, 2018 at 06:55:02PM -0700, Matthew Wilcox wrote:
> On Wed, Jul 25, 2018 at 10:32:50AM +0900, Minchan Kim wrote:
> > Hi Tino,
> >
> > On Tue, Jul 24, 2018 at 09:30:34AM +0200, Tino Lehnig wrote:
> > > Hi,
> > >
> > > The first build I used was from the master branch of the mainline kernel,
> > > somewhere between rc5 and rc6. I have just reproduced the bug with 4.17.9
> > > and 4.18-rc6. Kernel messages below.
> > >
> > > The bug does not appear on 4.14.57. I can test more versions if it helps.
> >
> > Could you try 4.15?
> >
> > I think it's a regression of struct page field reordring and it started from
> > v4.16.
> >
> > page->units for zsmalloc is used as offset of first object on the zspage,
> > However, below patch unified it with page->_refcount.
>
> No it didn't. It's in a union with _mapcount, which is where it was before
> my patches.
>
> It's entiely possible that my patches caused this, but the explanation
> you're offering is wrong.
Before your patch, _mapcount and _refcount is separated space so we can use
_mapcount for page->units for non-mapped pages because units is unified with
_mapcount. However, with your patch, now units is unified with _refcount.
next prev parent reply other threads:[~2018-07-25 2:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 12:29 Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process Tino Lehnig
2018-07-24 1:03 ` Minchan Kim
2018-07-24 2:53 ` Sergey Senozhatsky
2018-07-24 6:47 ` Minchan Kim
2018-07-24 7:30 ` Tino Lehnig
2018-07-25 1:32 ` Minchan Kim
2018-07-25 1:55 ` Matthew Wilcox
2018-07-25 2:16 ` Minchan Kim [this message]
2018-07-25 2:35 ` Matthew Wilcox
2018-07-25 2:51 ` Minchan Kim
2018-07-25 2:55 ` Matthew Wilcox
2018-07-25 3:02 ` Minchan Kim
2018-07-25 2:51 ` Matthew Wilcox
2018-07-25 4:07 ` Sergey Senozhatsky
2018-07-25 13:21 ` Minchan Kim
2018-07-25 15:12 ` Tino Lehnig
2018-07-26 2:03 ` Minchan Kim
2018-07-26 6:10 ` Tino Lehnig
2018-07-26 6:21 ` Minchan Kim
2018-07-26 6:34 ` Tino Lehnig
2018-07-26 10:00 ` Tino Lehnig
2018-07-26 10:30 ` Minchan Kim
2018-07-26 12:35 ` Tino Lehnig
2018-07-27 9:14 ` Minchan Kim
2018-07-27 11:00 ` Tino Lehnig
2018-07-27 12:05 ` Minchan Kim
2018-07-27 12:13 ` Tino Lehnig
2018-07-27 22:58 ` Minchan Kim
2018-07-30 6:09 ` Tino Lehnig
2018-08-02 5:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725021657.GA87819@rodete-desktop-imager.corp.google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tino.lehnig@contabo.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.