From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64B6C6778F for ; Wed, 25 Jul 2018 14:05:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 929AA20890 for ; Wed, 25 Jul 2018 14:05:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 929AA20890 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728490AbeGYPRL (ORCPT ); Wed, 25 Jul 2018 11:17:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50602 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727504AbeGYPRL (ORCPT ); Wed, 25 Jul 2018 11:17:11 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6PDxD4Z120001 for ; Wed, 25 Jul 2018 10:05:20 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kes105h5s-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Jul 2018 10:05:16 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jul 2018 14:59:48 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 25 Jul 2018 14:59:45 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6PDxis044236816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Jul 2018 13:59:44 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E961A4C044; Wed, 25 Jul 2018 16:59:59 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5EB994C040; Wed, 25 Jul 2018 16:59:59 +0100 (BST) Received: from rapoport-lnx (unknown [9.148.8.110]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 25 Jul 2018 16:59:59 +0100 (BST) Date: Wed, 25 Jul 2018 16:59:42 +0300 From: Mike Rapoport To: Thiago Jung Bauermann Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Andrea Arcangeli , Prakash Sangappa Subject: Re: [PATCH 1/3] userfaultfd: selftest: Fix checking of userfaultfd_open() result References: <20180725024209.32586-1-bauerman@linux.ibm.com> <20180725024209.32586-2-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725024209.32586-2-bauerman@linux.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18072513-0020-0000-0000-000002AB02A5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18072513-0021-0000-0000-000020F79CED Message-Id: <20180725135942.GC25188@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-25_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807250151 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Jul 24, 2018 at 11:42:07PM -0300, Thiago Jung Bauermann wrote: > If the userfaultfd test is run on a kernel with CONFIG_USERFAULTFD=n, it > will report that the system call is not available yet go ahead and continue > anyway: > > # ./userfaultfd anon 30 1 > nr_pages: 480, nr_pages_per_cpu: 120 > userfaultfd syscall not available in this kernel > bounces: 0, mode:, register failure > > This is because userfaultfd_open() returns 0 on success and 1 on error but > all callers assume that it returns < 0 on error. > > Since the convention of the test as a whole is the one used by > userfault_open(), fix its callers instead. Now the test behaves correctly: > > # ./userfaultfd anon 30 1 > nr_pages: 480, nr_pages_per_cpu: 120 > userfaultfd syscall not available in this kernel > > Signed-off-by: Thiago Jung Bauermann It seems that this patch is superseded by the second patch in this series. > --- > tools/testing/selftests/vm/userfaultfd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c > index 7b8171e3128a..e4099afe7557 100644 > --- a/tools/testing/selftests/vm/userfaultfd.c > +++ b/tools/testing/selftests/vm/userfaultfd.c > @@ -859,7 +859,7 @@ static int userfaultfd_zeropage_test(void) > if (uffd_test_ops->release_pages(area_dst)) > return 1; > > - if (userfaultfd_open(0) < 0) > + if (userfaultfd_open(0)) > return 1; > uffdio_register.range.start = (unsigned long) area_dst; > uffdio_register.range.len = nr_pages * page_size; > @@ -902,7 +902,7 @@ static int userfaultfd_events_test(void) > > features = UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_EVENT_REMAP | > UFFD_FEATURE_EVENT_REMOVE; > - if (userfaultfd_open(features) < 0) > + if (userfaultfd_open(features)) > return 1; > fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK); > > @@ -961,7 +961,7 @@ static int userfaultfd_sig_test(void) > return 1; > > features = UFFD_FEATURE_EVENT_FORK|UFFD_FEATURE_SIGBUS; > - if (userfaultfd_open(features) < 0) > + if (userfaultfd_open(features)) > return 1; > fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK); > > @@ -1027,7 +1027,7 @@ static int userfaultfd_stress(void) > if (!area_dst) > return 1; > > - if (userfaultfd_open(0) < 0) > + if (userfaultfd_open(0)) > return 1; > > count_verify = malloc(nr_pages * sizeof(unsigned long long)); -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rppt at linux.vnet.ibm.com (Mike Rapoport) Date: Wed, 25 Jul 2018 16:59:42 +0300 Subject: [PATCH 1/3] userfaultfd: selftest: Fix checking of userfaultfd_open() result In-Reply-To: <20180725024209.32586-2-bauerman@linux.ibm.com> References: <20180725024209.32586-1-bauerman@linux.ibm.com> <20180725024209.32586-2-bauerman@linux.ibm.com> Message-ID: <20180725135942.GC25188@rapoport-lnx> Hi, On Tue, Jul 24, 2018 at 11:42:07PM -0300, Thiago Jung Bauermann wrote: > If the userfaultfd test is run on a kernel with CONFIG_USERFAULTFD=n, it > will report that the system call is not available yet go ahead and continue > anyway: > > # ./userfaultfd anon 30 1 > nr_pages: 480, nr_pages_per_cpu: 120 > userfaultfd syscall not available in this kernel > bounces: 0, mode:, register failure > > This is because userfaultfd_open() returns 0 on success and 1 on error but > all callers assume that it returns < 0 on error. > > Since the convention of the test as a whole is the one used by > userfault_open(), fix its callers instead. Now the test behaves correctly: > > # ./userfaultfd anon 30 1 > nr_pages: 480, nr_pages_per_cpu: 120 > userfaultfd syscall not available in this kernel > > Signed-off-by: Thiago Jung Bauermann It seems that this patch is superseded by the second patch in this series. > --- > tools/testing/selftests/vm/userfaultfd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c > index 7b8171e3128a..e4099afe7557 100644 > --- a/tools/testing/selftests/vm/userfaultfd.c > +++ b/tools/testing/selftests/vm/userfaultfd.c > @@ -859,7 +859,7 @@ static int userfaultfd_zeropage_test(void) > if (uffd_test_ops->release_pages(area_dst)) > return 1; > > - if (userfaultfd_open(0) < 0) > + if (userfaultfd_open(0)) > return 1; > uffdio_register.range.start = (unsigned long) area_dst; > uffdio_register.range.len = nr_pages * page_size; > @@ -902,7 +902,7 @@ static int userfaultfd_events_test(void) > > features = UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_EVENT_REMAP | > UFFD_FEATURE_EVENT_REMOVE; > - if (userfaultfd_open(features) < 0) > + if (userfaultfd_open(features)) > return 1; > fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK); > > @@ -961,7 +961,7 @@ static int userfaultfd_sig_test(void) > return 1; > > features = UFFD_FEATURE_EVENT_FORK|UFFD_FEATURE_SIGBUS; > - if (userfaultfd_open(features) < 0) > + if (userfaultfd_open(features)) > return 1; > fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK); > > @@ -1027,7 +1027,7 @@ static int userfaultfd_stress(void) > if (!area_dst) > return 1; > > - if (userfaultfd_open(0) < 0) > + if (userfaultfd_open(0)) > return 1; > > count_verify = malloc(nr_pages * sizeof(unsigned long long)); -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: rppt@linux.vnet.ibm.com (Mike Rapoport) Date: Wed, 25 Jul 2018 16:59:42 +0300 Subject: [PATCH 1/3] userfaultfd: selftest: Fix checking of userfaultfd_open() result In-Reply-To: <20180725024209.32586-2-bauerman@linux.ibm.com> References: <20180725024209.32586-1-bauerman@linux.ibm.com> <20180725024209.32586-2-bauerman@linux.ibm.com> Message-ID: <20180725135942.GC25188@rapoport-lnx> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180725135942.W4cQwPBbzWDTmcKSeF9hQis0xaO5-gRj-FEPz10HSNY@z> Hi, On Tue, Jul 24, 2018@11:42:07PM -0300, Thiago Jung Bauermann wrote: > If the userfaultfd test is run on a kernel with CONFIG_USERFAULTFD=n, it > will report that the system call is not available yet go ahead and continue > anyway: > > # ./userfaultfd anon 30 1 > nr_pages: 480, nr_pages_per_cpu: 120 > userfaultfd syscall not available in this kernel > bounces: 0, mode:, register failure > > This is because userfaultfd_open() returns 0 on success and 1 on error but > all callers assume that it returns < 0 on error. > > Since the convention of the test as a whole is the one used by > userfault_open(), fix its callers instead. Now the test behaves correctly: > > # ./userfaultfd anon 30 1 > nr_pages: 480, nr_pages_per_cpu: 120 > userfaultfd syscall not available in this kernel > > Signed-off-by: Thiago Jung Bauermann It seems that this patch is superseded by the second patch in this series. > --- > tools/testing/selftests/vm/userfaultfd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c > index 7b8171e3128a..e4099afe7557 100644 > --- a/tools/testing/selftests/vm/userfaultfd.c > +++ b/tools/testing/selftests/vm/userfaultfd.c > @@ -859,7 +859,7 @@ static int userfaultfd_zeropage_test(void) > if (uffd_test_ops->release_pages(area_dst)) > return 1; > > - if (userfaultfd_open(0) < 0) > + if (userfaultfd_open(0)) > return 1; > uffdio_register.range.start = (unsigned long) area_dst; > uffdio_register.range.len = nr_pages * page_size; > @@ -902,7 +902,7 @@ static int userfaultfd_events_test(void) > > features = UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_EVENT_REMAP | > UFFD_FEATURE_EVENT_REMOVE; > - if (userfaultfd_open(features) < 0) > + if (userfaultfd_open(features)) > return 1; > fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK); > > @@ -961,7 +961,7 @@ static int userfaultfd_sig_test(void) > return 1; > > features = UFFD_FEATURE_EVENT_FORK|UFFD_FEATURE_SIGBUS; > - if (userfaultfd_open(features) < 0) > + if (userfaultfd_open(features)) > return 1; > fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK); > > @@ -1027,7 +1027,7 @@ static int userfaultfd_stress(void) > if (!area_dst) > return 1; > > - if (userfaultfd_open(0) < 0) > + if (userfaultfd_open(0)) > return 1; > > count_verify = malloc(nr_pages * sizeof(unsigned long long)); -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html