All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Timur Tabi <timur@kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>
Subject: [PATCH 2/6] ASoC: doc: Replace open code with params_set_format()
Date: Wed, 25 Jul 2018 23:17:18 +0200	[thread overview]
Message-ID: <20180725211722.18944-3-tiwai@suse.de> (raw)
In-Reply-To: <20180725211722.18944-1-tiwai@suse.de>

The example code in dpcm.rst contains an open code calling
snd_mask_set(), and this can be better represented with
params_set_format() instead.  This automatically fixes the sparse
warning about snd_pcm_format_t handling, too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 Documentation/sound/soc/dpcm.rst | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/sound/soc/dpcm.rst b/Documentation/sound/soc/dpcm.rst
index 395e5a516282..fe61e02277f8 100644
--- a/Documentation/sound/soc/dpcm.rst
+++ b/Documentation/sound/soc/dpcm.rst
@@ -254,9 +254,7 @@ configuration.
 	channels->min = channels->max = 2;
 
 	/* set DAI0 to 16 bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S16_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S16_LE);
 	return 0;
   }
 
-- 
2.18.0

  parent reply	other threads:[~2018-07-25 21:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 21:17 [PATCH 0/6] ASoC: PCM format type conversion fixes Takashi Iwai
2018-07-25 21:17 ` [PATCH 1/6] ALSA: pcm: Add snd_mask_set_format() helper for standard usages Takashi Iwai
2018-07-26 16:11   ` Applied "ALSA: pcm: Add snd_mask_set_format() helper for standard usages" to the asoc tree Mark Brown
2018-07-25 21:17 ` Takashi Iwai [this message]
2018-07-26 16:11   ` Applied "ASoC: doc: Replace open code with params_set_format()" " Mark Brown
2018-07-25 21:17 ` [PATCH 3/6] ASoC: intel: Fix snd_pcm_format_t handling Takashi Iwai
2018-07-26 16:11   ` Applied "ASoC: intel: Fix snd_pcm_format_t handling" to the asoc tree Mark Brown
2018-07-25 21:17 ` [PATCH 4/6] ASoC: fsl: Use snd_mask_set_format() Takashi Iwai
2018-07-26 16:11   ` Applied "ASoC: fsl: Use snd_mask_set_format()" to the asoc tree Mark Brown
2018-07-25 21:17 ` [PATCH 5/6] ASoC: pcm186x: Declare PCM format with snd_pcm_format_t Takashi Iwai
2018-07-26 16:11   ` Applied "ASoC: pcm186x: Declare PCM format with snd_pcm_format_t" to the asoc tree Mark Brown
2018-07-25 21:17 ` [PATCH 6/6] ASoC: dmaengine: Use standard pcm_format_to_bits() macro Takashi Iwai
2018-07-26 16:11   ` Applied "ASoC: dmaengine: Use standard pcm_format_to_bits() macro" to the asoc tree Mark Brown
2018-07-26 14:46 ` [PATCH 0/6] ASoC: PCM format type conversion fixes Mark Brown
2018-07-26 15:03   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725211722.18944-3-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=timur@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.