From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] xfrm: fix ptr_ret.cocci warnings Date: Thu, 26 Jul 2018 15:09:52 +0800 Message-ID: <20180726070952.GA135949@lkp-ib03> References: <201807261538.y1P9yjWE%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, netdev@vger.kernel.org, Steffen Klassert To: Benedict Wong Return-path: Received: from mga04.intel.com ([192.55.52.120]:49440 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728310AbeGZIZ2 (ORCPT ); Thu, 26 Jul 2018 04:25:28 -0400 Content-Disposition: inline In-Reply-To: <201807261538.y1P9yjWE%fengguang.wu@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: kbuild test robot net/xfrm/xfrm_interface.c:692:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 44e2b838c24d ("xfrm: Return detailed errors from xfrmi_newlink") CC: Benedict Wong Signed-off-by: kbuild test robot --- xfrm_interface.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/net/xfrm/xfrm_interface.c +++ b/net/xfrm/xfrm_interface.c @@ -689,10 +689,7 @@ static int xfrmi_newlink(struct net *src nla_strlcpy(p->name, tb[IFLA_IFNAME], IFNAMSIZ); xi = xfrmi_locate(net, p, 1); - if (IS_ERR(xi)) - return PTR_ERR(xi); - - return 0; + return PTR_ERR_OR_ZERO(xi); } static void xfrmi_dellink(struct net_device *dev, struct list_head *head)