From: Wolfram Sang <wsa@the-dreams.de>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
Subject: Re: [PATCH 1/2] mmc: renesas_sdhi: skip SCC error check when retuning
Date: Thu, 26 Jul 2018 09:34:59 +0200 [thread overview]
Message-ID: <20180726073459.xuxld3fn5g56pvjc@tetsubishi> (raw)
In-Reply-To: <20180725133643.GE14991@bigcity.dyn.berto.se>
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
> I agree but I could not find a neat way of doing it. How about?
>
> bool use_4tap = host->pdata->flags & TMIO_MMC_HAVE_4TAP_HS400;
>
> if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) &&
> !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200) &&
> !(host->mmc->ios.timing == MMC_TIMING_MMC_HS400 && !use_4tap))
> return false;
Yeah, it's not much but the best I could think of right now, too. But it
definately is better.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-07-26 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 12:10 [PATCH 0/2] mmc: {tmio,renesas_sdhi}: retune if SCC error detected Niklas Söderlund
2018-07-25 12:10 ` [PATCH 1/2] mmc: renesas_sdhi: skip SCC error check when retuning Niklas Söderlund
2018-07-25 12:21 ` Wolfram Sang
2018-07-25 13:36 ` Niklas Söderlund
2018-07-26 7:34 ` Wolfram Sang [this message]
2018-07-25 12:10 ` [PATCH 2/2] mmc: tmio: Fix SCC error detection Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726073459.xuxld3fn5g56pvjc@tetsubishi \
--to=wsa@the-dreams.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masaharu.hayakawa.ry@renesas.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.