From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60364 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731174AbeGYXZy (ORCPT ); Wed, 25 Jul 2018 19:25:54 -0400 Date: Thu, 26 Jul 2018 08:12:02 +1000 From: Stefano Brivio To: Philip =?UTF-8?B?TcO8bGxlcg==?= , Greg Kroah-Hartman Cc: stable@vger.kernel.org, mochobb@clix.pt, manjaro@rlinhard.de Subject: Re: [PATCH 4.14 12/53] cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 ACE setting Message-ID: <20180726081202.0f09a028@elisabeth> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Wed, 25 Jul 2018 18:06:25 +0200 Philip Müller wrote: > Hi Greg, hi Stefano, > > seems adding "cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 > ACE setting" (commit 748144f) [1] created a regression within linux > v4.14 kernel series. Writing to a mounted cifs either freezes on writing > or crashes the PC. A more detailed explanation you may find in our > forums [2]. Reverting the patch, seems to "fix" it. Thoughts? Hi Philip, thanks for reporting this. My bad, I didn't check how the backport of f46ecbd97f50 ("cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 ACE setting") looked like on 4.14. As 4.14 doesn't have commit 2fc803efe614 ("cifs: remove rfc1002 header from smb2_set_info_req"), the effect is substantially different. Greg, I would need some time to check if we actually need this at all on 4.14, to do a proper backport in case and to run tests. Could you please revert this on 4.14.y for the moment being? If a backport is needed, I'll send it later on. Thanks! -- Stefano