All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Francis Deslauriers <francis.deslauriers@efficios.com>,
	peterz@infradead.org, mathieu.desnoyers@efficios.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] selftest/ftrace: Move kprobe selftest function to separate compile unit
Date: Thu, 26 Jul 2018 19:29:43 -0400	[thread overview]
Message-ID: <20180726192943.2499a61d@gandalf.local.home> (raw)
In-Reply-To: <153258443533.11602.8446454305778389593.stgit@devbox>

On Thu, 26 Jul 2018 14:53:55 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> From: Francis Deslauriers <francis.deslauriers@efficios.com>
> 
> Move selftest function to its own compile unit so it can be compiled
> with the ftrace cflags (CC_FLAGS_FTRACE) allowing it to be probed
> during the ftrace startup tests.
> 
> Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Hi Masami,

Actually, since you are sending this as part of your patch queue, you
need to add your Signed-off-by here and not Acked-by. That means it has
gone through you.

I've applied the first patch already, just resend this one, where you
add you Signed-off-by instead of Acked-by.

Thanks!

-- Steve


> ---
>  kernel/trace/Makefile                |    5 +++++
>  kernel/trace/trace_kprobe.c          |   12 +-----------
>  kernel/trace/trace_kprobe_selftest.c |   10 ++++++++++
>  kernel/trace/trace_kprobe_selftest.h |    7 +++++++
>  4 files changed, 23 insertions(+), 11 deletions(-)
>  create mode 100644 kernel/trace/trace_kprobe_selftest.c
>  create mode 100644 kernel/trace/trace_kprobe_selftest.h
> 

  reply	other threads:[~2018-07-26 23:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26  5:52 [PATCH v2 0/3] tracing: kprobes: Prohibit probing on notrace functions Masami Hiramatsu
2018-07-26  5:53 ` [PATCH v2 1/3] tracing: kprobes: Prohibit probing on notrace function Masami Hiramatsu
2018-07-28  1:00   ` Masami Hiramatsu
2018-07-28  8:11   ` kbuild test robot
2018-07-28 13:42     ` Masami Hiramatsu
2018-07-28  8:24   ` kbuild test robot
2018-07-26  5:53 ` [PATCH v2 2/3] selftest/ftrace: Move kprobe selftest function to separate compile unit Masami Hiramatsu
2018-07-26 23:29   ` Steven Rostedt [this message]
2018-07-27 12:39     ` Masami Hiramatsu
2018-07-27 12:44     ` [PATCH v2.1 " Masami Hiramatsu
2018-07-26  5:54 ` [PATCH v2 3/3] selftests/ftrace: Fix kprobe string testcase to not probe notrace function Masami Hiramatsu
2018-07-26  7:44   ` Masami Hiramatsu
2018-07-26 19:58     ` Steven Rostedt
2018-07-26 21:22       ` Shuah Khan
2018-07-27 12:47         ` Masami Hiramatsu
2018-07-27 14:26           ` Shuah Khan
2018-07-27 14:31             ` Steven Rostedt
2018-07-28  2:24               ` Masami Hiramatsu
2018-07-27 21:43   ` Steven Rostedt
2018-07-27 23:59     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180726192943.2499a61d@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=francis.deslauriers@efficios.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.