All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/5] arm64: dts: allwinner: a64: Add SID node
@ 2018-07-24 10:15 ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: srinivas.kandagatla, robh+dt, mark.rutland, maxime.ripard, wens,
	catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, Emmanuel Vadot

The A64 have a SID controller which consist on EFUSE (starting at 0x200)
and three registers to read/write the efuses.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 1b2ef28c42bd..69c0d9362553 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -227,6 +227,11 @@
 			#size-cells = <0>;
 		};
 
+		sid: eeprom@1c14000 {
+			compatible = "allwinner,sun50i-a64-sid";
+			reg = <0x1c14000 0x400>;
+		};
+
 		usb_otg: usb@1c19000 {
 			compatible = "allwinner,sun8i-a33-musb";
 			reg = <0x01c19000 0x0400>;
-- 
2.17.0


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 1/5] arm64: dts: allwinner: a64: Add SID node
@ 2018-07-24 10:15 ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: linux-arm-kernel

The A64 have a SID controller which consist on EFUSE (starting at 0x200)
and three registers to read/write the efuses.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 1b2ef28c42bd..69c0d9362553 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -227,6 +227,11 @@
 			#size-cells = <0>;
 		};
 
+		sid: eeprom at 1c14000 {
+			compatible = "allwinner,sun50i-a64-sid";
+			reg = <0x1c14000 0x400>;
+		};
+
 		usb_otg: usb at 1c19000 {
 			compatible = "allwinner,sun8i-a33-musb";
 			reg = <0x01c19000 0x0400>;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 2/5] ARM: dts: sunxi: h3/h5: Add SID node
  2018-07-24 10:15 ` Emmanuel Vadot
@ 2018-07-24 10:15   ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: srinivas.kandagatla, robh+dt, mark.rutland, maxime.ripard, wens,
	catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, Emmanuel Vadot

Both H3 and H5 and a SID controller at the same address.
They are know to be different, the H5 one is the same as the A64 so add
a node in the common dtsi and we will override the compatible string in
the SoC dts.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index c3bff1105e5d..2b3c629644a0 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -644,6 +644,10 @@
 			status = "disabled";
 		};
 
+		sid: eeprom@1c14000 {
+			reg = <0x1c14000 0x400>;
+		};
+
 		uart0: serial@1c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
-- 
2.17.0


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 2/5] ARM: dts: sunxi: h3/h5: Add SID node
@ 2018-07-24 10:15   ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: linux-arm-kernel

Both H3 and H5 and a SID controller at the same address.
They are know to be different, the H5 one is the same as the A64 so add
a node in the common dtsi and we will override the compatible string in
the SoC dts.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index c3bff1105e5d..2b3c629644a0 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -644,6 +644,10 @@
 			status = "disabled";
 		};
 
+		sid: eeprom at 1c14000 {
+			reg = <0x1c14000 0x400>;
+		};
+
 		uart0: serial at 1c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 3/5] ARM: dts: sun8i: h3: Add SID compatible string
  2018-07-24 10:15 ` Emmanuel Vadot
@ 2018-07-24 10:15   ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: srinivas.kandagatla, robh+dt, mark.rutland, maxime.ripard, wens,
	catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, Emmanuel Vadot

The SID controller on H3 is one of it's kind (at least from what we
know).
Add a compatible string for it in the SoC dtsi.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm/boot/dts/sun8i-h3.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 41d57c76f290..f543aa1dc829 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -185,3 +185,7 @@
 &pio {
 	compatible = "allwinner,sun8i-h3-pinctrl";
 };
+
+&sid {
+	compatible = "allwinner,sun8i-h3-sid";
+};
-- 
2.17.0


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 3/5] ARM: dts: sun8i: h3: Add SID compatible string
@ 2018-07-24 10:15   ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: linux-arm-kernel

The SID controller on H3 is one of it's kind (at least from what we
know).
Add a compatible string for it in the SoC dtsi.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm/boot/dts/sun8i-h3.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 41d57c76f290..f543aa1dc829 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -185,3 +185,7 @@
 &pio {
 	compatible = "allwinner,sun8i-h3-pinctrl";
 };
+
+&sid {
+	compatible = "allwinner,sun8i-h3-sid";
+};
-- 
2.17.0

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 4/5] nvmem: sunxi-sid: add support for H5's SID controller
  2018-07-24 10:15 ` Emmanuel Vadot
@ 2018-07-24 10:15   ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: srinivas.kandagatla, robh+dt, mark.rutland, maxime.ripard, wens,
	catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, Emmanuel Vadot

The H5 SoC have a SID controller that looks like the one in A64, but
in case we find some difference in the futur at a binding for it.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt
index e319fe5e205a..99c4ba6a3f61 100644
--- a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt
+++ b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt
@@ -7,6 +7,7 @@ Required properties:
   "allwinner,sun8i-a83t-sid"
   "allwinner,sun8i-h3-sid"
   "allwinner,sun50i-a64-sid"
+  "allwinner,sun50i-h5-sid"
 
 - reg: Should contain registers location and length
 
-- 
2.17.0


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 4/5] nvmem: sunxi-sid: add support for H5's SID controller
@ 2018-07-24 10:15   ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: linux-arm-kernel

The H5 SoC have a SID controller that looks like the one in A64, but
in case we find some difference in the futur at a binding for it.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt
index e319fe5e205a..99c4ba6a3f61 100644
--- a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt
+++ b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt
@@ -7,6 +7,7 @@ Required properties:
   "allwinner,sun8i-a83t-sid"
   "allwinner,sun8i-h3-sid"
   "allwinner,sun50i-a64-sid"
+  "allwinner,sun50i-h5-sid"
 
 - reg: Should contain registers location and length
 
-- 
2.17.0

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-24 10:15 ` Emmanuel Vadot
@ 2018-07-24 10:15   ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: srinivas.kandagatla, robh+dt, mark.rutland, maxime.ripard, wens,
	catalin.marinas, will.deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel, Emmanuel Vadot

The SID controller on H5 look the same as the one present in the A64.
But in case we find some difference one day at a compatible string
of it's own and a fallback to the A64 one.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
index 62d646baac3c..28183bf77164 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
@@ -129,3 +129,8 @@
 		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
 	compatible = "allwinner,sun50i-h5-pinctrl";
 };
+
+&sid {
+	compatible = "allwinner,sun50i-h5-sid",
+		     "allwinner,sun50i-a64-sid";
+};
-- 
2.17.0


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-24 10:15   ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 10:15 UTC (permalink / raw)
  To: linux-arm-kernel

The SID controller on H5 look the same as the one present in the A64.
But in case we find some difference one day at a compatible string
of it's own and a fallback to the A64 one.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
index 62d646baac3c..28183bf77164 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
@@ -129,3 +129,8 @@
 		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
 	compatible = "allwinner,sun50i-h5-pinctrl";
 };
+
+&sid {
+	compatible = "allwinner,sun50i-h5-sid",
+		     "allwinner,sun50i-a64-sid";
+};
-- 
2.17.0

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-24 10:15   ` Emmanuel Vadot
@ 2018-07-24 13:00     ` Maxime Ripard
  -1 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-24 13:00 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: srinivas.kandagatla, robh+dt, mark.rutland, wens,
	catalin.marinas, will.deacon, devicetree, linux-arm-kernel,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> The SID controller on H5 look the same as the one present in the A64.
> But in case we find some difference one day at a compatible string
> of it's own and a fallback to the A64 one.
> 
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> index 62d646baac3c..28183bf77164 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> @@ -129,3 +129,8 @@
>  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>  	compatible = "allwinner,sun50i-h5-pinctrl";
>  };
> +
> +&sid {
> +	compatible = "allwinner,sun50i-h5-sid",
> +		     "allwinner,sun50i-a64-sid";
> +};

This is still a bit pointless, please remove the common node.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-24 13:00     ` Maxime Ripard
  0 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-24 13:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> The SID controller on H5 look the same as the one present in the A64.
> But in case we find some difference one day at a compatible string
> of it's own and a fallback to the A64 one.
> 
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> index 62d646baac3c..28183bf77164 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> @@ -129,3 +129,8 @@
>  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>  	compatible = "allwinner,sun50i-h5-pinctrl";
>  };
> +
> +&sid {
> +	compatible = "allwinner,sun50i-h5-sid",
> +		     "allwinner,sun50i-a64-sid";
> +};

This is still a bit pointless, please remove the common node.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180724/b4713889/attachment.sig>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 4/5] nvmem: sunxi-sid: add support for H5's SID controller
  2018-07-24 10:15   ` Emmanuel Vadot
@ 2018-07-24 13:00     ` Maxime Ripard
  -1 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-24 13:00 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: srinivas.kandagatla, robh+dt, mark.rutland, wens,
	catalin.marinas, will.deacon, devicetree, linux-arm-kernel,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

On Tue, Jul 24, 2018 at 12:15:21PM +0200, Emmanuel Vadot wrote:
> The H5 SoC have a SID controller that looks like the one in A64, but
> in case we find some difference in the futur at a binding for it.
> 
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

The prefix in your commit title should start with dt-bindings: ...

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 4/5] nvmem: sunxi-sid: add support for H5's SID controller
@ 2018-07-24 13:00     ` Maxime Ripard
  0 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-24 13:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jul 24, 2018 at 12:15:21PM +0200, Emmanuel Vadot wrote:
> The H5 SoC have a SID controller that looks like the one in A64, but
> in case we find some difference in the futur at a binding for it.
> 
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

The prefix in your commit title should start with dt-bindings: ...

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180724/8b6f6fc4/attachment.sig>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-24 13:00     ` Maxime Ripard
  (?)
@ 2018-07-24 13:34       ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 13:34 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Emmanuel Vadot, mark.rutland, devicetree, catalin.marinas,
	will.deacon, linux-kernel, wens, robh+dt, srinivas.kandagatla,
	linux-arm-kernel

On Tue, 24 Jul 2018 15:00:04 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > The SID controller on H5 look the same as the one present in the A64.
> > But in case we find some difference one day at a compatible string
> > of it's own and a fallback to the A64 one.
> > 
> > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > index 62d646baac3c..28183bf77164 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > @@ -129,3 +129,8 @@
> >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> >  	compatible = "allwinner,sun50i-h5-pinctrl";
> >  };
> > +
> > +&sid {
> > +	compatible = "allwinner,sun50i-h5-sid",
> > +		     "allwinner,sun50i-a64-sid";
> > +};
> 
> This is still a bit pointless, please remove the common node.

 You mean directly declare sid controller in the SoC dtsi and not have
a common node in sunxi-h3-h5.dtsi ?

> Maxime
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-24 13:34       ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 13:34 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: mark.rutland, devicetree, catalin.marinas, will.deacon,
	linux-kernel, Emmanuel Vadot, wens, robh+dt, srinivas.kandagatla,
	linux-arm-kernel

On Tue, 24 Jul 2018 15:00:04 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > The SID controller on H5 look the same as the one present in the A64.
> > But in case we find some difference one day at a compatible string
> > of it's own and a fallback to the A64 one.
> > 
> > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > index 62d646baac3c..28183bf77164 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > @@ -129,3 +129,8 @@
> >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> >  	compatible = "allwinner,sun50i-h5-pinctrl";
> >  };
> > +
> > +&sid {
> > +	compatible = "allwinner,sun50i-h5-sid",
> > +		     "allwinner,sun50i-a64-sid";
> > +};
> 
> This is still a bit pointless, please remove the common node.

 You mean directly declare sid controller in the SoC dtsi and not have
a common node in sunxi-h3-h5.dtsi ?

> Maxime
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-24 13:34       ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 13:34 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, 24 Jul 2018 15:00:04 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > The SID controller on H5 look the same as the one present in the A64.
> > But in case we find some difference one day at a compatible string
> > of it's own and a fallback to the A64 one.
> > 
> > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > index 62d646baac3c..28183bf77164 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > @@ -129,3 +129,8 @@
> >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> >  	compatible = "allwinner,sun50i-h5-pinctrl";
> >  };
> > +
> > +&sid {
> > +	compatible = "allwinner,sun50i-h5-sid",
> > +		     "allwinner,sun50i-a64-sid";
> > +};
> 
> This is still a bit pointless, please remove the common node.

 You mean directly declare sid controller in the SoC dtsi and not have
a common node in sunxi-h3-h5.dtsi ?

> Maxime
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-24 13:34       ` Emmanuel Vadot
@ 2018-07-24 14:42         ` Maxime Ripard
  -1 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-24 14:42 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: Emmanuel Vadot, mark.rutland, devicetree, catalin.marinas,
	will.deacon, linux-kernel, wens, robh+dt, srinivas.kandagatla,
	linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> On Tue, 24 Jul 2018 15:00:04 +0200
> Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> 
> > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > The SID controller on H5 look the same as the one present in the A64.
> > > But in case we find some difference one day at a compatible string
> > > of it's own and a fallback to the A64 one.
> > > 
> > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > ---
> > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > index 62d646baac3c..28183bf77164 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > @@ -129,3 +129,8 @@
> > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > >  };
> > > +
> > > +&sid {
> > > +	compatible = "allwinner,sun50i-h5-sid",
> > > +		     "allwinner,sun50i-a64-sid";
> > > +};
> > 
> > This is still a bit pointless, please remove the common node.
> 
>  You mean directly declare sid controller in the SoC dtsi and not
> have a common node in sunxi-h3-h5.dtsi ?

Yep

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-24 14:42         ` Maxime Ripard
  0 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-24 14:42 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> On Tue, 24 Jul 2018 15:00:04 +0200
> Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> 
> > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > The SID controller on H5 look the same as the one present in the A64.
> > > But in case we find some difference one day at a compatible string
> > > of it's own and a fallback to the A64 one.
> > > 
> > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > ---
> > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > index 62d646baac3c..28183bf77164 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > @@ -129,3 +129,8 @@
> > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > >  };
> > > +
> > > +&sid {
> > > +	compatible = "allwinner,sun50i-h5-sid",
> > > +		     "allwinner,sun50i-a64-sid";
> > > +};
> > 
> > This is still a bit pointless, please remove the common node.
> 
>  You mean directly declare sid controller in the SoC dtsi and not
> have a common node in sunxi-h3-h5.dtsi ?

Yep

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180724/ef92eeff/attachment.sig>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-24 14:42         ` Maxime Ripard
@ 2018-07-24 14:55           ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 14:55 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: mark.rutland, devicetree, catalin.marinas, will.deacon,
	linux-kernel, Emmanuel Vadot, wens, robh+dt, srinivas.kandagatla,
	linux-arm-kernel

On Tue, 24 Jul 2018 16:42:18 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > On Tue, 24 Jul 2018 15:00:04 +0200
> > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > 
> > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > The SID controller on H5 look the same as the one present in the A64.
> > > > But in case we find some difference one day at a compatible string
> > > > of it's own and a fallback to the A64 one.
> > > > 
> > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > ---
> > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > index 62d646baac3c..28183bf77164 100644
> > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > @@ -129,3 +129,8 @@
> > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > >  };
> > > > +
> > > > +&sid {
> > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > +		     "allwinner,sun50i-a64-sid";
> > > > +};
> > > 
> > > This is still a bit pointless, please remove the common node.
> > 
> >  You mean directly declare sid controller in the SoC dtsi and not
> > have a common node in sunxi-h3-h5.dtsi ?
> 
> Yep
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com

 The reason I've put it in the common file is because I'll send patches
for the nvmem-cells needed for thermal, and those are common between
the two. Other nvmem-cells are also common (like the chipid and
probably other).

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-24 14:55           ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-24 14:55 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, 24 Jul 2018 16:42:18 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > On Tue, 24 Jul 2018 15:00:04 +0200
> > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > 
> > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > The SID controller on H5 look the same as the one present in the A64.
> > > > But in case we find some difference one day at a compatible string
> > > > of it's own and a fallback to the A64 one.
> > > > 
> > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > ---
> > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > index 62d646baac3c..28183bf77164 100644
> > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > @@ -129,3 +129,8 @@
> > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > >  };
> > > > +
> > > > +&sid {
> > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > +		     "allwinner,sun50i-a64-sid";
> > > > +};
> > > 
> > > This is still a bit pointless, please remove the common node.
> > 
> >  You mean directly declare sid controller in the SoC dtsi and not
> > have a common node in sunxi-h3-h5.dtsi ?
> 
> Yep
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com

 The reason I've put it in the common file is because I'll send patches
for the nvmem-cells needed for thermal, and those are common between
the two. Other nvmem-cells are also common (like the chipid and
probably other).

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-24 14:55           ` Emmanuel Vadot
@ 2018-07-26 11:54             ` Maxime Ripard
  -1 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-26 11:54 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: mark.rutland, devicetree, catalin.marinas, will.deacon,
	linux-kernel, Emmanuel Vadot, wens, robh+dt, srinivas.kandagatla,
	linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 2110 bytes --]

On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> On Tue, 24 Jul 2018 16:42:18 +0200
> Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> 
> > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > 
> > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > > The SID controller on H5 look the same as the one present in the A64.
> > > > > But in case we find some difference one day at a compatible string
> > > > > of it's own and a fallback to the A64 one.
> > > > > 
> > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > ---
> > > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > > >  1 file changed, 5 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > index 62d646baac3c..28183bf77164 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > @@ -129,3 +129,8 @@
> > > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > > >  };
> > > > > +
> > > > > +&sid {
> > > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > > +		     "allwinner,sun50i-a64-sid";
> > > > > +};
> > > > 
> > > > This is still a bit pointless, please remove the common node.
> > > 
> > >  You mean directly declare sid controller in the SoC dtsi and not
> > > have a common node in sunxi-h3-h5.dtsi ?
> > 
> > Yep
> 
>  The reason I've put it in the common file is because I'll send patches
> for the nvmem-cells needed for thermal, and those are common between
> the two. Other nvmem-cells are also common (like the chipid and
> probably other).

Then we'll see what we can have in common and what not when we'll have
something in common?

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-26 11:54             ` Maxime Ripard
  0 siblings, 0 replies; 27+ messages in thread
From: Maxime Ripard @ 2018-07-26 11:54 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> On Tue, 24 Jul 2018 16:42:18 +0200
> Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> 
> > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > 
> > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > > The SID controller on H5 look the same as the one present in the A64.
> > > > > But in case we find some difference one day at a compatible string
> > > > > of it's own and a fallback to the A64 one.
> > > > > 
> > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > ---
> > > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > > >  1 file changed, 5 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > index 62d646baac3c..28183bf77164 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > @@ -129,3 +129,8 @@
> > > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > > >  };
> > > > > +
> > > > > +&sid {
> > > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > > +		     "allwinner,sun50i-a64-sid";
> > > > > +};
> > > > 
> > > > This is still a bit pointless, please remove the common node.
> > > 
> > >  You mean directly declare sid controller in the SoC dtsi and not
> > > have a common node in sunxi-h3-h5.dtsi ?
> > 
> > Yep
> 
>  The reason I've put it in the common file is because I'll send patches
> for the nvmem-cells needed for thermal, and those are common between
> the two. Other nvmem-cells are also common (like the chipid and
> probably other).

Then we'll see what we can have in common and what not when we'll have
something in common?

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180726/94f8de9c/attachment.sig>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-26 11:54             ` Maxime Ripard
@ 2018-07-27 10:56               ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-27 10:56 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: mark.rutland, devicetree, catalin.marinas, will.deacon,
	linux-kernel, Emmanuel Vadot, wens, robh+dt, srinivas.kandagatla,
	linux-arm-kernel

On Thu, 26 Jul 2018 13:54:09 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> > On Tue, 24 Jul 2018 16:42:18 +0200
> > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > 
> > > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > 
> > > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > > > The SID controller on H5 look the same as the one present in the A64.
> > > > > > But in case we find some difference one day at a compatible string
> > > > > > of it's own and a fallback to the A64 one.
> > > > > > 
> > > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > > ---
> > > > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > > > >  1 file changed, 5 insertions(+)
> > > > > > 
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > index 62d646baac3c..28183bf77164 100644
> > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > @@ -129,3 +129,8 @@
> > > > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > > > >  };
> > > > > > +
> > > > > > +&sid {
> > > > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > > > +		     "allwinner,sun50i-a64-sid";
> > > > > > +};
> > > > > 
> > > > > This is still a bit pointless, please remove the common node.
> > > > 
> > > >  You mean directly declare sid controller in the SoC dtsi and not
> > > > have a common node in sunxi-h3-h5.dtsi ?
> > > 
> > > Yep
> > 
> >  The reason I've put it in the common file is because I'll send patches
> > for the nvmem-cells needed for thermal, and those are common between
> > the two. Other nvmem-cells are also common (like the chipid and
> > probably other).
> 
> Then we'll see what we can have in common and what not when we'll have
> something in common?

 Will it make more sense that I just send a new series with nvmem-cells
now along with thermal bindings ?

> Maxime
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-27 10:56               ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-27 10:56 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, 26 Jul 2018 13:54:09 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:

> On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> > On Tue, 24 Jul 2018 16:42:18 +0200
> > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > 
> > > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > 
> > > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > > > The SID controller on H5 look the same as the one present in the A64.
> > > > > > But in case we find some difference one day at a compatible string
> > > > > > of it's own and a fallback to the A64 one.
> > > > > > 
> > > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > > ---
> > > > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > > > >  1 file changed, 5 insertions(+)
> > > > > > 
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > index 62d646baac3c..28183bf77164 100644
> > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > @@ -129,3 +129,8 @@
> > > > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > > > >  };
> > > > > > +
> > > > > > +&sid {
> > > > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > > > +		     "allwinner,sun50i-a64-sid";
> > > > > > +};
> > > > > 
> > > > > This is still a bit pointless, please remove the common node.
> > > > 
> > > >  You mean directly declare sid controller in the SoC dtsi and not
> > > > have a common node in sunxi-h3-h5.dtsi ?
> > > 
> > > Yep
> > 
> >  The reason I've put it in the common file is because I'll send patches
> > for the nvmem-cells needed for thermal, and those are common between
> > the two. Other nvmem-cells are also common (like the chipid and
> > probably other).
> 
> Then we'll see what we can have in common and what not when we'll have
> something in common?

 Will it make more sense that I just send a new series with nvmem-cells
now along with thermal bindings ?

> Maxime
> 
> -- 
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
  2018-07-27 10:56               ` Emmanuel Vadot
@ 2018-07-27 11:34                 ` Emmanuel Vadot
  -1 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-27 11:34 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: Maxime Ripard, mark.rutland, devicetree, catalin.marinas,
	will.deacon, linux-kernel, Emmanuel Vadot, wens, robh+dt,
	srinivas.kandagatla, linux-arm-kernel

On Fri, 27 Jul 2018 12:56:54 +0200
Emmanuel Vadot <manu@bidouilliste.com> wrote:

> On Thu, 26 Jul 2018 13:54:09 +0200
> Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> 
> > On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> > > On Tue, 24 Jul 2018 16:42:18 +0200
> > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > 
> > > > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > > 
> > > > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > > > > The SID controller on H5 look the same as the one present in the A64.
> > > > > > > But in case we find some difference one day at a compatible string
> > > > > > > of it's own and a fallback to the A64 one.
> > > > > > > 
> > > > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > > > ---
> > > > > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > > > > >  1 file changed, 5 insertions(+)
> > > > > > > 
> > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > > index 62d646baac3c..28183bf77164 100644
> > > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > > @@ -129,3 +129,8 @@
> > > > > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > > > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > > > > >  };
> > > > > > > +
> > > > > > > +&sid {
> > > > > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > > > > +		     "allwinner,sun50i-a64-sid";
> > > > > > > +};
> > > > > > 
> > > > > > This is still a bit pointless, please remove the common node.
> > > > > 
> > > > >  You mean directly declare sid controller in the SoC dtsi and not
> > > > > have a common node in sunxi-h3-h5.dtsi ?
> > > > 
> > > > Yep
> > > 
> > >  The reason I've put it in the common file is because I'll send patches
> > > for the nvmem-cells needed for thermal, and those are common between
> > > the two. Other nvmem-cells are also common (like the chipid and
> > > probably other).
> > 
> > Then we'll see what we can have in common and what not when we'll have
> > something in common?
> 
>  Will it make more sense that I just send a new series with nvmem-cells
> now along with thermal bindings ?

 My bad, I remembered H5 thermal sensor being the same as H3 but I was
wrong.
 I'll send a v3 with your changes suggestion and we'll see later for
thermal sensor.

> > Maxime
> > 
> > -- 
> > Maxime Ripard, Bootlin (formerly Free Electrons)
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> 
> 
> -- 
> Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
@ 2018-07-27 11:34                 ` Emmanuel Vadot
  0 siblings, 0 replies; 27+ messages in thread
From: Emmanuel Vadot @ 2018-07-27 11:34 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, 27 Jul 2018 12:56:54 +0200
Emmanuel Vadot <manu@bidouilliste.com> wrote:

> On Thu, 26 Jul 2018 13:54:09 +0200
> Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> 
> > On Tue, Jul 24, 2018 at 04:55:01PM +0200, Emmanuel Vadot wrote:
> > > On Tue, 24 Jul 2018 16:42:18 +0200
> > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > 
> > > > On Tue, Jul 24, 2018 at 03:34:32PM +0200, Emmanuel Vadot wrote:
> > > > > On Tue, 24 Jul 2018 15:00:04 +0200
> > > > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > > 
> > > > > > On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> > > > > > > The SID controller on H5 look the same as the one present in the A64.
> > > > > > > But in case we find some difference one day at a compatible string
> > > > > > > of it's own and a fallback to the A64 one.
> > > > > > > 
> > > > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > > > ---
> > > > > > >  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
> > > > > > >  1 file changed, 5 insertions(+)
> > > > > > > 
> > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > > index 62d646baac3c..28183bf77164 100644
> > > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> > > > > > > @@ -129,3 +129,8 @@
> > > > > > >  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> > > > > > >  	compatible = "allwinner,sun50i-h5-pinctrl";
> > > > > > >  };
> > > > > > > +
> > > > > > > +&sid {
> > > > > > > +	compatible = "allwinner,sun50i-h5-sid",
> > > > > > > +		     "allwinner,sun50i-a64-sid";
> > > > > > > +};
> > > > > > 
> > > > > > This is still a bit pointless, please remove the common node.
> > > > > 
> > > > >  You mean directly declare sid controller in the SoC dtsi and not
> > > > > have a common node in sunxi-h3-h5.dtsi ?
> > > > 
> > > > Yep
> > > 
> > >  The reason I've put it in the common file is because I'll send patches
> > > for the nvmem-cells needed for thermal, and those are common between
> > > the two. Other nvmem-cells are also common (like the chipid and
> > > probably other).
> > 
> > Then we'll see what we can have in common and what not when we'll have
> > something in common?
> 
>  Will it make more sense that I just send a new series with nvmem-cells
> now along with thermal bindings ?

 My bad, I remembered H5 thermal sensor being the same as H3 but I was
wrong.
 I'll send a v3 with your changes suggestion and we'll see later for
thermal sensor.

> > Maxime
> > 
> > -- 
> > Maxime Ripard, Bootlin (formerly Free Electrons)
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> 
> 
> -- 
> Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2018-07-27 11:34 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 10:15 [PATCH v2 1/5] arm64: dts: allwinner: a64: Add SID node Emmanuel Vadot
2018-07-24 10:15 ` Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 2/5] ARM: dts: sunxi: h3/h5: " Emmanuel Vadot
2018-07-24 10:15   ` Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 3/5] ARM: dts: sun8i: h3: Add SID compatible string Emmanuel Vadot
2018-07-24 10:15   ` Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 4/5] nvmem: sunxi-sid: add support for H5's SID controller Emmanuel Vadot
2018-07-24 10:15   ` Emmanuel Vadot
2018-07-24 13:00   ` Maxime Ripard
2018-07-24 13:00     ` Maxime Ripard
2018-07-24 10:15 ` [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5 Emmanuel Vadot
2018-07-24 10:15   ` Emmanuel Vadot
2018-07-24 13:00   ` Maxime Ripard
2018-07-24 13:00     ` Maxime Ripard
2018-07-24 13:34     ` Emmanuel Vadot
2018-07-24 13:34       ` Emmanuel Vadot
2018-07-24 13:34       ` Emmanuel Vadot
2018-07-24 14:42       ` Maxime Ripard
2018-07-24 14:42         ` Maxime Ripard
2018-07-24 14:55         ` Emmanuel Vadot
2018-07-24 14:55           ` Emmanuel Vadot
2018-07-26 11:54           ` Maxime Ripard
2018-07-26 11:54             ` Maxime Ripard
2018-07-27 10:56             ` Emmanuel Vadot
2018-07-27 10:56               ` Emmanuel Vadot
2018-07-27 11:34               ` Emmanuel Vadot
2018-07-27 11:34                 ` Emmanuel Vadot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.