* [PATCH] misc: ti-st: Fix memory leak in the error path of probe()
@ 2018-07-27 15:45 Anton Vasilyev
0 siblings, 0 replies; only message in thread
From: Anton Vasilyev @ 2018-07-27 15:45 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Anton Vasilyev, Greg Kroah-Hartman, Arvind Yadav, Jia-Ju Bai,
linux-kernel, ldv-project
Free resources instead of direct return of the error code if kim_probe
fails.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
drivers/misc/ti-st/st_kim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index 5ec3f5a43718..14a5e9da32bd 100644
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -756,14 +756,14 @@ static int kim_probe(struct platform_device *pdev)
err = gpio_request(kim_gdata->nshutdown, "kim");
if (unlikely(err)) {
pr_err(" gpio %d request failed ", kim_gdata->nshutdown);
- return err;
+ goto err_sysfs_group;
}
/* Configure nShutdown GPIO as output=0 */
err = gpio_direction_output(kim_gdata->nshutdown, 0);
if (unlikely(err)) {
pr_err(" unable to configure gpio %d", kim_gdata->nshutdown);
- return err;
+ goto err_sysfs_group;
}
/* get reference of pdev for request_firmware
*/
--
2.18.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-27 15:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 15:45 [PATCH] misc: ti-st: Fix memory leak in the error path of probe() Anton Vasilyev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.