All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] video: sunxi: de2: fix SimpleFB node creation when DE2 not probed
@ 2018-07-27 15:50 Icenowy Zheng
  2018-07-30  7:44 ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Icenowy Zheng @ 2018-07-27 15:50 UTC (permalink / raw)
  To: u-boot

Sometimes when a monitor without EDID information is plugged, the DE2
won't be probed (because of lack of timing information), but the HDMI
node is probed, thus a SimpleFB node with invalid information will be
populated.

Also detect whether DE2 is probed when creating SimpleFB node.

Fixes: be5b96f0e411 ("sunxi: setup simplefb for Allwinner DE2")
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 drivers/video/sunxi/sunxi_de2.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/video/sunxi/sunxi_de2.c b/drivers/video/sunxi/sunxi_de2.c
index 4ed035d556..8333ddc44c 100644
--- a/drivers/video/sunxi/sunxi_de2.c
+++ b/drivers/video/sunxi/sunxi_de2.c
@@ -347,6 +347,9 @@ int sunxi_simplefb_setup(void *blob)
 	if (ret) {
 		debug("DE2 not present\n");
 		return 0;
+	} else if (!device_active(de2)) {
+		debug("DE2 present but not probed\n");
+		return 0;
 	}
 
 	ret = uclass_find_device_by_name(UCLASS_DISPLAY,
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] video: sunxi: de2: fix SimpleFB node creation when DE2 not probed
  2018-07-27 15:50 [U-Boot] [PATCH] video: sunxi: de2: fix SimpleFB node creation when DE2 not probed Icenowy Zheng
@ 2018-07-30  7:44 ` Maxime Ripard
  2018-07-31  6:09   ` [U-Boot] [linux-sunxi] " Jagan Teki
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2018-07-30  7:44 UTC (permalink / raw)
  To: u-boot

On Fri, Jul 27, 2018 at 11:50:53PM +0800, Icenowy Zheng wrote:
> Sometimes when a monitor without EDID information is plugged, the DE2
> won't be probed (because of lack of timing information), but the HDMI
> node is probed, thus a SimpleFB node with invalid information will be
> populated.
> 
> Also detect whether DE2 is probed when creating SimpleFB node.
> 
> Fixes: be5b96f0e411 ("sunxi: setup simplefb for Allwinner DE2")
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Maxime
-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180730/d7354bb6/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [linux-sunxi] Re: [PATCH] video: sunxi: de2: fix SimpleFB node creation when DE2 not probed
  2018-07-30  7:44 ` Maxime Ripard
@ 2018-07-31  6:09   ` Jagan Teki
  0 siblings, 0 replies; 3+ messages in thread
From: Jagan Teki @ 2018-07-31  6:09 UTC (permalink / raw)
  To: u-boot

On Mon, Jul 30, 2018 at 1:14 PM, Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Fri, Jul 27, 2018 at 11:50:53PM +0800, Icenowy Zheng wrote:
>> Sometimes when a monitor without EDID information is plugged, the DE2
>> won't be probed (because of lack of timing information), but the HDMI
>> node is probed, thus a SimpleFB node with invalid information will be
>> populated.
>>
>> Also detect whether DE2 is probed when creating SimpleFB node.
>>
>> Fixes: be5b96f0e411 ("sunxi: setup simplefb for Allwinner DE2")
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Applied to u-boot-sunxi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-31  6:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 15:50 [U-Boot] [PATCH] video: sunxi: de2: fix SimpleFB node creation when DE2 not probed Icenowy Zheng
2018-07-30  7:44 ` Maxime Ripard
2018-07-31  6:09   ` [U-Boot] [linux-sunxi] " Jagan Teki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.