From mboxrd@z Thu Jan 1 00:00:00 1970 From: "liujunliang_ljl@163.com" Subject: Re: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind() Date: Fri, 27 Jul 2018 17:04:48 +0800 Message-ID: <201807271704468308230@163.com> References: <20180727084104.29726-1-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_001_NextPart884175411161_=----" Cc: linux-usb , netdev , linux-kernel , "Jia-Ju Bai" To: "Jia-Ju Bai" Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This is a multi-part message in MIME format. ------=_001_NextPart884175411161_=---- Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: base64 RGVhciBKaWEtSnUgQmFpIDoNCg0KICAgICAgICAgICAgT0suDQoNCiAgICAgICAgICAgIHRoZSBw YXRjaCBpcyBvay4NCg0KDQoNCmxpdWp1bmxpYW5nX2xqbEAxNjMuY29tDQogDQpGcm9tOiBKaWEt SnUgQmFpDQpEYXRlOiAyMDE4LTA3LTI3IDE2OjQxDQpUbzogbGl1anVubGlhbmdfbGpsDQpDQzog bGludXgtdXNiOyBuZXRkZXY7IGxpbnV4LWtlcm5lbDsgSmlhLUp1IEJhaQ0KU3ViamVjdDogW1BB VENIXSBuZXQ6IHVzYjogc3I5NzAwOiBSZXBsYWNlIG1kZWxheSgpIHdpdGggbXNsZWVwKCkgaW4g c3I5NzAwX2JpbmQoKQ0Kc3I5NzAwX2JpbmQoKSBpcyBuZXZlciBjYWxsZWQgaW4gYXRvbWljIGNv bnRleHQuDQpJdCBjYWxscyBtZGVsYXkoKSB0byBidXNpbHkgd2FpdCwgd2hpY2ggaXMgbm90IG5l Y2Vzc2FyeS4NCm1kZWxheSgpIGNhbiBiZSByZXBsYWNlZCB3aXRoIG1zbGVlcCgpLg0KIA0KVGhp cyBpcyBmb3VuZCBieSBhIHN0YXRpYyBhbmFseXNpcyB0b29sIG5hbWVkIERDTlMgd3JpdHRlbiBi eSBteXNlbGYuDQogDQpTaWduZWQtb2ZmLWJ5OiBKaWEtSnUgQmFpIDxiYWlqaWFqdTE5OTBAZ21h aWwuY29tPg0KLS0tDQpkcml2ZXJzL25ldC91c2Ivc3I5NzAwLmMgfCAyICstDQoxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCiANCmRpZmYgLS1naXQgYS9kcml2 ZXJzL25ldC91c2Ivc3I5NzAwLmMgYi9kcml2ZXJzL25ldC91c2Ivc3I5NzAwLmMNCmluZGV4IDJk MzE2YzFiODUxYi4uNmFjMjMyZTUyYmY3IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9uZXQvdXNiL3Ny OTcwMC5jDQorKysgYi9kcml2ZXJzL25ldC91c2Ivc3I5NzAwLmMNCkBAIC0zNTgsNyArMzU4LDcg QEAgc3RhdGljIGludCBzcjk3MDBfYmluZChzdHJ1Y3QgdXNibmV0ICpkZXYsIHN0cnVjdCB1c2Jf aW50ZXJmYWNlICppbnRmKQ0KLyogcG93ZXIgdXAgYW5kIHJlc2V0IHBoeSAqLw0Kc3Jfd3JpdGVf cmVnKGRldiwgU1JfUFJSLCBQUlJfUEhZX1JTVCk7DQovKiBhdCBsZWFzdCAxMG1zLCBoZXJlIDIw bXMgZm9yIHNhZmUgKi8NCi0gbWRlbGF5KDIwKTsNCisgbXNsZWVwKDIwKTsNCnNyX3dyaXRlX3Jl ZyhkZXYsIFNSX1BSUiwgMCk7DQovKiBhdCBsZWFzdCAxbXMsIGhlcmUgMm1zIGZvciByZWFkaW5n IHJpZ2h0IHJlZ2lzdGVyICovDQp1ZGVsYXkoMiAqIDEwMDApOw0KLS0gDQoyLjE3LjANCg== ------=_001_NextPart884175411161_=---- Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable =0A

Dear Jia-Ju Bai :

&n= bsp; &= nbsp; OK.

&nbs= p; the patch is ok.

=0A

liujunliang_ljl@163.com

=0A

From: Jia-Ju Bai

Date: 201= 8-07-27 16:41

To: liujunliang_ljl

CC: linux-usb; netdev; = linux-kernel; Jia-Ju Bai=

Subject: [PATCH] net: usb: sr9700: Replace mdelay()= with msleep() in sr9700_bind()

sr9700_bind() i= s never called in atomic context.

=0A

It calls mdelay() to busily= wait, which is not necessary.

=0A

mdelay() can be replaced with = msleep().

=0A

This is found by a static analy= sis tool named DCNS written by myself.

=0A

Si= gned-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

=0A

---=0A

drivers/net/usb/sr9700.c | 2 +-

=0A

1 file changed, = 1 insertion(+), 1 deletion(-)

=0A

diff --git = a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c

=0A

index 2= d316c1b851b..6ac232e52bf7 100644

=0A

--- a/drivers/net/usb/sr9700= .c

=0A

+++ b/drivers/net/usb/sr9700.c

=0A

@@ -358,7 +358= ,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *int= f)

=0A

/* power up and reset phy */

=0A

sr_write_reg= (dev, SR_PRR, PRR_PHY_RST);

=0A

/* at least 10ms, here 20ms for= safe */

=0A

- mdelay(20);

=0A

+ msleep(20);

=0A sr_write_reg(dev, SR_PRR, 0);

=0A

/* at least 1ms, here 2ms= for reading right register */

=0A

udelay(2 * 1000);

=0A--

=0A

2.17.0

=0A=0A ------=_001_NextPart884175411161_=------ From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind() From: "liujunliang_ljl@163.com" Message-Id: <201807271704468308230@163.com> Date: Fri, 27 Jul 2018 17:04:48 +0800 To: Jia-Ju Bai Cc: linux-usb , netdev , linux-kernel List-ID: RGVhciBKaWEtSnUgQmFpIDoNCg0KICAgICAgICAgICAgT0suDQoNCiAgICAgICAgICAgIHRoZSBw YXRjaCBpcyBvay4NCg0KDQoNCmxpdWp1bmxpYW5nX2xqbEAxNjMuY29tDQogDQpGcm9tOiBKaWEt SnUgQmFpDQpEYXRlOiAyMDE4LTA3LTI3IDE2OjQxDQpUbzogbGl1anVubGlhbmdfbGpsDQpDQzog bGludXgtdXNiOyBuZXRkZXY7IGxpbnV4LWtlcm5lbDsgSmlhLUp1IEJhaQ0KU3ViamVjdDogW1BB VENIXSBuZXQ6IHVzYjogc3I5NzAwOiBSZXBsYWNlIG1kZWxheSgpIHdpdGggbXNsZWVwKCkgaW4g c3I5NzAwX2JpbmQoKQ0Kc3I5NzAwX2JpbmQoKSBpcyBuZXZlciBjYWxsZWQgaW4gYXRvbWljIGNv bnRleHQuDQpJdCBjYWxscyBtZGVsYXkoKSB0byBidXNpbHkgd2FpdCwgd2hpY2ggaXMgbm90IG5l Y2Vzc2FyeS4NCm1kZWxheSgpIGNhbiBiZSByZXBsYWNlZCB3aXRoIG1zbGVlcCgpLg0KIA0KVGhp cyBpcyBmb3VuZCBieSBhIHN0YXRpYyBhbmFseXNpcyB0b29sIG5hbWVkIERDTlMgd3JpdHRlbiBi eSBteXNlbGYuDQogDQpTaWduZWQtb2ZmLWJ5OiBKaWEtSnUgQmFpIDxiYWlqaWFqdTE5OTBAZ21h aWwuY29tPg0KLS0tDQpkcml2ZXJzL25ldC91c2Ivc3I5NzAwLmMgfCAyICstDQoxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCiANCi0tIA0KMi4xNy4wCgpkaWZm IC0tZ2l0IGEvZHJpdmVycy9uZXQvdXNiL3NyOTcwMC5jIGIvZHJpdmVycy9uZXQvdXNiL3NyOTcw MC5jDQppbmRleCAyZDMxNmMxYjg1MWIuLjZhYzIzMmU1MmJmNyAxMDA2NDQNCi0tLSBhL2RyaXZl cnMvbmV0L3VzYi9zcjk3MDAuYw0KKysrIGIvZHJpdmVycy9uZXQvdXNiL3NyOTcwMC5jDQpAQCAt MzU4LDcgKzM1OCw3IEBAIHN0YXRpYyBpbnQgc3I5NzAwX2JpbmQoc3RydWN0IHVzYm5ldCAqZGV2 LCBzdHJ1Y3QgdXNiX2ludGVyZmFjZSAqaW50ZikNCi8qIHBvd2VyIHVwIGFuZCByZXNldCBwaHkg Ki8NCnNyX3dyaXRlX3JlZyhkZXYsIFNSX1BSUiwgUFJSX1BIWV9SU1QpOw0KLyogYXQgbGVhc3Qg MTBtcywgaGVyZSAyMG1zIGZvciBzYWZlICovDQotIG1kZWxheSgyMCk7DQorIG1zbGVlcCgyMCk7 DQpzcl93cml0ZV9yZWcoZGV2LCBTUl9QUlIsIDApOw0KLyogYXQgbGVhc3QgMW1zLCBoZXJlIDJt cyBmb3IgcmVhZGluZyByaWdodCByZWdpc3RlciAqLw0KdWRlbGF5KDIgKiAxMDAwKTsNCg==