From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52202 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727241AbeGaIqV (ORCPT ); Tue, 31 Jul 2018 04:46:21 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [PATCH] net/wireless/intersil/hostap: fix defined but not usedwarnings From: Kalle Valo In-Reply-To: References: To: Randy Dunlap Cc: Jouni Malinen , linux-wireless@vger.kernel.org, David Miller , "netdev@vger.kernel.org" Message-Id: <20180731070729.7323360708@smtp.codeaurora.org> (sfid-20180731_090732_557534_F909FFB6) Date: Tue, 31 Jul 2018 07:07:29 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Randy Dunlap wrote: > From: Randy Dunlap > > Fix build warnings in drivers/net/wireless/intersil/hostap/ when > CONFIG_PROC_FS is not enabled by marking the unused functions as > __maybe_unused. > > ../drivers/net/wireless/intersil/hostap/hostap_ap.c:70:12: warning: 'ap_debug_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_ap.c:994:12: warning: 'prism2_sta_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: 'prism2_debug_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: 'prism2_stats_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: 'prism2_crypt_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: 'prism2_registers_proc_show' defined but not used [-Wunused-function] > > Signed-off-by: Randy Dunlap > Cc: Jouni Malinen > Cc: linux-wireless@vger.kernel.org > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: netdev@vger.kernel.org I'll drop this as I take Yue's patch. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/10512915/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] net/wireless/intersil/hostap: fix defined but not usedwarnings Date: Tue, 31 Jul 2018 07:07:29 +0000 (UTC) Message-ID: <20180731070729.7323360708@smtp.codeaurora.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Jouni Malinen , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Miller , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Randy Dunlap Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Randy Dunlap wrote: > From: Randy Dunlap > > Fix build warnings in drivers/net/wireless/intersil/hostap/ when > CONFIG_PROC_FS is not enabled by marking the unused functions as > __maybe_unused. > > ../drivers/net/wireless/intersil/hostap/hostap_ap.c:70:12: warning: 'ap_debug_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_ap.c:994:12: warning: 'prism2_sta_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: 'prism2_debug_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: 'prism2_stats_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: 'prism2_crypt_proc_show' defined but not used [-Wunused-function] > ../drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: 'prism2_registers_proc_show' defined but not used [-Wunused-function] > > Signed-off-by: Randy Dunlap > Cc: Jouni Malinen > Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org I'll drop this as I take Yue's patch. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/10512915/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches