From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 31 Jul 2018 10:59:28 +0300 From: Mika Westerberg To: Lukas Wunner Cc: Bjorn Helgaas , "Gustavo A. R. Silva" , Sinan Kaya , linux-pci@vger.kernel.org Subject: Re: [PATCH 1/2] PCI: pciehp: Avoid implicit fallthroughs in switch statements Message-ID: <20180731075928.GZ2534@lahna.fi.intel.com> References: <92c3c456edb461494d5c44e1ff6bab2711228ff1.1532754355.git.lukas@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <92c3c456edb461494d5c44e1ff6bab2711228ff1.1532754355.git.lukas@wunner.de> List-ID: On Sat, Jul 28, 2018 at 07:22:00AM +0200, Lukas Wunner wrote: > Per Mika's request, add an explicit break to the last case of switch > statements everywhere in pciehp to be more defensive towards future > amendments. > > Per Gustavo's request, mark all non-empty implicit fallthroughs with a > comment to silence warnings triggered by -Wimplicit-fallthrough=2. > > Signed-off-by: Lukas Wunner > Cc: Gustavo A. R. Silva > Cc: Mika Westerberg Reviewed-by: Mika Westerberg