From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH net-next 1/3] net: update real_num_rx_queues even when !CONFIG_SYSFS Date: Tue, 31 Jul 2018 15:02:01 +0200 Message-ID: <20180731150201.49e2fd45@redhat.com> References: <20180731034353.3774-1-jakub.kicinski@netronome.com> <20180731034353.3774-2-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: brouer@redhat.com, davem@davemloft.net, alexei.starovoitov@gmail.com, daniel@iogearbox.net, netdev@vger.kernel.org, oss-drivers@netronome.com, bjorn.topel@intel.com To: Jakub Kicinski Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56008 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731962AbeGaOmV (ORCPT ); Tue, 31 Jul 2018 10:42:21 -0400 In-Reply-To: <20180731034353.3774-2-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 30 Jul 2018 20:43:51 -0700 Jakub Kicinski wrote: > We used to depend on real_num_rx_queues as a upper bound for sanity > checks. For AF_XDP socket validation it's useful if the check behaves > the same regardless of CONFIG_SYSFS setting. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet Acked-by: Jesper Dangaard Brouer > --- > include/linux/netdevice.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 9c917467a2c7..3bf7e93c9e96 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -3431,8 +3431,9 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq); > int netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq); > #else > static inline int netif_set_real_num_rx_queues(struct net_device *dev, > - unsigned int rxq) > + unsigned int rxqs) > { > + dev->real_num_rx_queues = rxqs; > return 0; > } > #endif -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer