All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
	vkoul@kernel.org
Subject: Re: [PATCH v5 8/8] ASoC: Intel: Skylake: add option to control HDAudio + DSP usage
Date: Tue, 31 Jul 2018 17:20:00 +0100	[thread overview]
Message-ID: <20180731162000.GJ5719@sirena.org.uk> (raw)
In-Reply-To: <5f73f810-6fe5-bad9-81fb-fd587ef39e8c@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1901 bytes --]

On Tue, Jul 31, 2018 at 09:06:54AM -0700, Pierre-Louis Bossart wrote:
> On 7/31/18 3:48 AM, Takashi Iwai wrote:
> > Pierre-Louis Bossart wrote:

> > > +config SND_SOC_INTEL_SKYLAKE_FORCE_HDA_DSP
> > > +	bool "Force HDAudio Codec + DSP support"
> > > +	depends on SND_SOC_INTEL_SKYLAKE_HDA_DSP
> > > +	help
> > > +	  If you have a Intel Skylake+ platform with the DSP enabled in
> > > +	  the BIOS and an HDAudio codec, then enable this option by saying Y
> > > +	  This option will ignore information from the BIOS and force the use
> > > +	  of the HDaudio codec, if present.
> > > +	  This is a debug option not recommended for distros.

> > ... and this one is better to be a module option.
> > Distros tend to enable all possible options, and this may be set
> > unnecessarily.  If any, this kconfig should be only toggling the
> > default option value.

> Sorry, I don't get this one. this wouldn't change anything between built-in
> or module, it's just a yes/no answer to ignore ACPI stuff. the default is
> also no and there is a clear statement not to include it except for debug.
> We have a similar option for SOF to bypass all ACPI information and go
> straight to 'nocodec' mode.

Debug options like these are really a lot more useful as something
runtime selectable with something like a module parameter as Takashi
suggests - an innatentive distro maintainer could easily enable it by
mistake when going through a bunch of new options in a new kernel
release and if someone needs it for debugging purposes in a distro
context it's a real pain to have to rebuild the kernel.

It's also a bit confusing as the config text says:

> > > +	  If you have a Intel Skylake+ platform with the DSP enabled in
> > > +	  the BIOS and an HDAudio codec, then enable this option by saying Y

which sounds like people should turn it on, the bit about it being a
debug option is quite deep in the text.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2018-07-31 16:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 23:05 [PATCH v5 0/8] Enable HDA Codec support on Intel Platforms Pierre-Louis Bossart
2018-07-27 23:05 ` [PATCH v5 1/8] ASoC: Intel: Skylake: extend widget handling Pierre-Louis Bossart
2018-08-01  9:47   ` Mark Brown
2018-07-27 23:05 ` [PATCH v5 2/8] ASoC: Intel: common: add table for HDA-based platforms Pierre-Louis Bossart
2018-07-27 23:05 ` [PATCH v5 3/8] ASoC: Intel: Boards: Machine driver for SKL+ w/ HDAudio codecs Pierre-Louis Bossart
2018-08-01 10:04   ` Mark Brown
2018-07-27 23:05 ` [PATCH v5 4/8] ASoC: Intel: Skylake: use HDAudio if ACPI enumeration fails Pierre-Louis Bossart
2018-07-27 23:05 ` [PATCH v5 5/8] ASoC: Intel: Skylake: add HDA BE DAIs Pierre-Louis Bossart
2018-07-27 23:05 ` [PATCH v5 6/8] ASoC: Intel: Skylake: use hda_bus instead of hdac_bus Pierre-Louis Bossart
2018-07-27 23:05 ` [PATCH v5 7/8] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers Pierre-Louis Bossart
2018-07-27 23:05 ` [PATCH v5 8/8] ASoC: Intel: Skylake: add option to control HDAudio + DSP usage Pierre-Louis Bossart
2018-07-31 10:48   ` Takashi Iwai
2018-07-31 16:06     ` Pierre-Louis Bossart
2018-07-31 16:20       ` Mark Brown [this message]
2018-08-01 14:50         ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731162000.GJ5719@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.