From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Aug 2018 01:22:20 -0700 From: Christoph Hellwig To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr Message-ID: <20180801082220.GA26378@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-6-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180731195155.46664-6-keescook@chromium.org> List-ID: On Tue, Jul 31, 2018 at 12:51:50PM -0700, Kees Cook wrote: > There is a lot of needless struct request_sense usage in the CDROM > code. These can all be struct scsi_sense_hdr instead, to avoid any > confusion over their respective structure sizes. This patch is a lot > of noise changing "sense" to "sshdr", but the final code is more > readable to distinguish between "sense" meaning "struct request_sense" > and "sshdr" meaning "struct scsi_sense_hdr". Looks good, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr Date: Wed, 1 Aug 2018 01:22:20 -0700 Message-ID: <20180801082220.GA26378@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-6-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180731195155.46664-6-keescook@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= List-Id: linux-ide@vger.kernel.org On Tue, Jul 31, 2018 at 12:51:50PM -0700, Kees Cook wrote: > There is a lot of needless struct request_sense usage in the CDROM > code. These can all be struct scsi_sense_hdr instead, to avoid any > confusion over their respective structure sizes. This patch is a lot > of noise changing "sense" to "sshdr", but the final code is more > readable to distinguish between "sense" meaning "struct request_sense" > and "sshdr" meaning "struct scsi_sense_hdr". Looks good, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 01 Aug 2018 08:22:20 +0000 Subject: Re: [PATCH v2 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr Message-Id: <20180801082220.GA26378@infradead.org> List-Id: References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-6-keescook@chromium.org> In-Reply-To: <20180731195155.46664-6-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 12:51:50PM -0700, Kees Cook wrote: > There is a lot of needless struct request_sense usage in the CDROM > code. These can all be struct scsi_sense_hdr instead, to avoid any > confusion over their respective structure sizes. This patch is a lot > of noise changing "sense" to "sshdr", but the final code is more > readable to distinguish between "sense" meaning "struct request_sense" > and "sshdr" meaning "struct scsi_sense_hdr". Looks good, Reviewed-by: Christoph Hellwig