From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:44082 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387532AbeHAKZj (ORCPT ); Wed, 1 Aug 2018 06:25:39 -0400 Received: by mail-wr1-f68.google.com with SMTP id r16-v6so19242942wrt.11 for ; Wed, 01 Aug 2018 01:41:00 -0700 (PDT) Date: Wed, 1 Aug 2018 10:40:57 +0200 From: Lorenzo Bianconi To: Stanislaw Gruszka Cc: Kalle Valo , Sean Wang , linux-wireless@vger.kernel.org, Felix Fietkau , Hans Ulli Kroll , Jakub Kicinski , Michal Schmidt , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 00/14] Add mt76x0 driver Message-ID: <20180801084056.GB4794@localhost.localdomain> (sfid-20180801_105646_624401_98662A39) References: <1533040864-9026-1-git-send-email-sgruszka@redhat.com> <87y3dqzga9.fsf@purkki.adurom.net> <20180801082508.GA4526@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180801082508.GA4526@redhat.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Aug 01, Stanislaw Gruszka wrote: > On Wed, Aug 01, 2018 at 10:39:58AM +0300, Kalle Valo wrote: > > Stanislaw Gruszka writes: > > > > > Add mt76x0 driver for MT7610U based USB dongles. Currently driver > > > support only STA mode. > > > > > > mt76x0 is based on Jakub's mt7601u driver already included > > > in the kernel. I would like the driver be integrated as part > > > of mt76 (instead of separate driver in mediatek dir like mt7601u) > > > to utilize mt76 code for adding support for MT76x0 PCIe devices > > > in further development. > > > > So what's the future for mt7601u, are we going to delete it? What's > > Jakub's opinion about all this? And what's the delta featurewise between > > mt7601u and this driver? Which one will be loaded by default? > > mt7601u is driver for different chip: MT7601. This driver if for MT7610 > chip. There are lot of similarities between the drivers, but there are > bunch of differences too. And in the future development of mt76x0, due > to integration into mt76 and mt76x2u and adding support for PCIe chips, > the differences against mt7601u will be much be bigger. > > > Also I noticed that mt76 is missing an entry in MAINTAINERS file? Could > > someone send a separate patch to add that, please? > > The question is if Felix would like to be the maintainer? Otherwise who would > want to do this job? I think the best option would be to get some > commitment from Mediatek if that possible, maybe Sean Wang could aggree > to be the maintainer ? :-) Maybe add multiple maintainers? I think the best option is Felix (if he agrees) since he started the work and he has more experience/knowledge of the code Regards, Lorenzo > > Thanks > Stanislaw From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Bianconi Subject: Re: [PATCH v3 00/14] Add mt76x0 driver Date: Wed, 1 Aug 2018 10:40:57 +0200 Message-ID: <20180801084056.GB4794@localhost.localdomain> References: <1533040864-9026-1-git-send-email-sgruszka@redhat.com> <87y3dqzga9.fsf@purkki.adurom.net> <20180801082508.GA4526@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180801082508.GA4526-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stanislaw Gruszka Cc: Kalle Valo , Sean Wang , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felix Fietkau , Hans Ulli Kroll , Jakub Kicinski , Michal Schmidt , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Aug 01, Stanislaw Gruszka wrote: > On Wed, Aug 01, 2018 at 10:39:58AM +0300, Kalle Valo wrote: > > Stanislaw Gruszka writes: > > > > > Add mt76x0 driver for MT7610U based USB dongles. Currently driver > > > support only STA mode. > > > > > > mt76x0 is based on Jakub's mt7601u driver already included > > > in the kernel. I would like the driver be integrated as part > > > of mt76 (instead of separate driver in mediatek dir like mt7601u) > > > to utilize mt76 code for adding support for MT76x0 PCIe devices > > > in further development. > > > > So what's the future for mt7601u, are we going to delete it? What's > > Jakub's opinion about all this? And what's the delta featurewise between > > mt7601u and this driver? Which one will be loaded by default? > > mt7601u is driver for different chip: MT7601. This driver if for MT7610 > chip. There are lot of similarities between the drivers, but there are > bunch of differences too. And in the future development of mt76x0, due > to integration into mt76 and mt76x2u and adding support for PCIe chips, > the differences against mt7601u will be much be bigger. > > > Also I noticed that mt76 is missing an entry in MAINTAINERS file? Could > > someone send a separate patch to add that, please? > > The question is if Felix would like to be the maintainer? Otherwise who would > want to do this job? I think the best option would be to get some > commitment from Mediatek if that possible, maybe Sean Wang could aggree > to be the maintainer ? :-) Maybe add multiple maintainers? I think the best option is Felix (if he agrees) since he started the work and he has more experience/knowledge of the code Regards, Lorenzo > > Thanks > Stanislaw