From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Aug 2018 16:54:02 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Mike Snitzer , Kent Overstreet Subject: Re: [PATCH 2/3] block: kill QUEUE_FLAG_NO_SG_MERGE Message-ID: <20180801145402.GB28668@lst.de> References: <20180731104914.17249-1-ming.lei@redhat.com> <20180731104914.17249-3-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180731104914.17249-3-ming.lei@redhat.com> List-ID: We still hit __blk_recalc_rq_segments at least once per submission, don't we? Either rather wait with this until we have multi-page bvecs.