From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB45C28CF6 for ; Wed, 1 Aug 2018 17:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36A2F208A3 for ; Wed, 1 Aug 2018 17:18:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CE2us6i7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A2F208A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404964AbeHATFJ (ORCPT ); Wed, 1 Aug 2018 15:05:09 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33182 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404951AbeHATFI (ORCPT ); Wed, 1 Aug 2018 15:05:08 -0400 Received: by mail-pf1-f193.google.com with SMTP id d4-v6so7953449pfn.0 for ; Wed, 01 Aug 2018 10:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=89uBHxu/kfQfe/TZJ6c8QvSSBcbTN0vkU5yEIyvApIA=; b=CE2us6i7zs7HmGN5xPznQp2MJV+K0Lhi3eYdjhRq9XchZS63wBqUSXJLdDipDx2lqo QGIr1tUe6K91yRB12Ny5YJpYrnNYall0XgICNoiHwLVFzlx7d3rAeAm4+mgrDA/X1Wou TDomczY/e5TuhzdcqvCn1n8LUaqjRQttl5knM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=89uBHxu/kfQfe/TZJ6c8QvSSBcbTN0vkU5yEIyvApIA=; b=hlKb5vYBqAptRYQT7Ebo0PAsJ2KkhfyoYMf+M7NSK9DlducKmuIgfpM4y7lLHVixiy qsb2DATLqJ5PF99NvgPSUj8z1UoR8qlUDKWaZkfn5D+NbLeWcfSkVBujaWwKbOvds9de ve+VVpOmmeJYCzJ/uN0nBpwvZST5/+WFpjsuYTJLhGFPUHD8u36Rt76S3KVwkoM9w22J qdBthoZutmjGlGTE762E5qd13z56bW850O8wYYCKFELI8eVlKMiqzOZuOpT6ZFPPPThF NGSBMAjooMevWScDMzxstV3rmHaASXGmbxYpRorFdkVZKGjEMaXMv4zCSlk4CwarZVVl g5yw== X-Gm-Message-State: AOUpUlHqBGl42usLwMigp7FfkHP1pQ2+LhCcfE2FVAls7etMT3QCpgaU Cr/svIgvtNPX+8Jkj/Xi6yg2cg== X-Google-Smtp-Source: AAOMgpdNcygtUj7cj8zwQeOC85/jmy/q44koXSgcEaWtOaV5MPqNE86KK2KtKU8901uzsF9e8zrFsQ== X-Received: by 2002:a62:68c3:: with SMTP id d186-v6mr8623984pfc.70.1533143908044; Wed, 01 Aug 2018 10:18:28 -0700 (PDT) Received: from localhost ([2620:15c:202:1:b6af:f85:ed6c:ac6a]) by smtp.gmail.com with ESMTPSA id v22-v6sm44395411pfi.60.2018.08.01.10.18.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 10:18:27 -0700 (PDT) Date: Wed, 1 Aug 2018 10:18:26 -0700 From: Matthias Kaehlcke To: Chanwoo Choi Cc: MyungJoo Ham , Kyungmin Park , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Mark Rutland , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris , Douglas Anderson , Enric Balletbo i Serra , "Rafael J . Wysocki" , Viresh Kumar , Lee Jones , Benson Leung , Olof Johansson Subject: Re: [PATCH v5 07/12] PM / devfreq: export devfreq_class Message-ID: <20180801171826.GK68975@google.com> References: <20180703234705.227473-1-mka@chromium.org> <20180703234705.227473-8-mka@chromium.org> <5B3C5B78.6020401@samsung.com> <20180706180923.GH129942@google.com> <41164a91-b271-5f3b-b461-21ff5997cc84@samsung.com> <20180716194114.GA129942@google.com> <20180731192904.GG68975@google.com> <5B616CE0.50400@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5B616CE0.50400@samsung.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 01, 2018 at 05:18:40PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 01일 04:29, Matthias Kaehlcke wrote: > > On Mon, Jul 16, 2018 at 12:41:14PM -0700, Matthias Kaehlcke wrote: > >> Hi Chanwoo, > >> > >> On Thu, Jul 12, 2018 at 06:08:36PM +0900, Chanwoo Choi wrote: > >>> Hi Matthias, > >>> > >>> On 2018년 07월 07일 03:09, Matthias Kaehlcke wrote: > >>>> Hi, > >>>> > >>>> On Wed, Jul 04, 2018 at 02:30:32PM +0900, Chanwoo Choi wrote: > >>>> > >>>>> I didn't see any framework which exporting the class instance. > >>>>> It is very dangerous. Unknown device drivers is able to reset > >>>>> the 'devfreq_class' instance. I can't agree this approach. > >>>> > >>>> While I agree that it is potential dangerous it is actually a common > >>>> practice to export the class: > >>>> > >>> > >>> I tried to find the real usage of exported class instance > >>> and I add the comment for each class instance. Almost exported class > >>> instance are used in the their own director or some exported class > >>> like rio_mport_class/switchtec_class are created from specific device driver > >>> instead of subsystem. > >>> > >>> Only following two cases are used on outside of subsystem directory. > >>> devtmpfs.c and alarmtimer.c are core feature of linux kernel. > >>> > >>> drivers/base/devtmpfs.c uses 'block_class'. > >>> kernel/time/alarmtimer.c uses 'rtc_class'. > >>> > >>> I cannot yet agree this approach due to only block_class and rtc_class. > >> > >> I thought your main concern was that the class is exported, which is > >> what several other subsystems do. That the class isn't used outside of > >> the subsystem directory most likely means that there is no need for > >> it, rather than that it shouldn't be done at all (depending on the > >> type of use of course). > >> > >> In any case not exporting the class object provides a limited > >> protection against potential abuse of the class at best. To use the > >> class API all that is needed is a 'struct device' of a devfreq device, > >> which has a pointer to the class object (dev->class). > >> > >> Theoretically I could register a fake devfreq device to obtain access > >> to the class object, though that doesn't seem a very neat approach ;-) > >> > >>> You added the following comment why devfreq_class instance is necessary. > >>> Actullay, I don't know the best solution right now. But, all device drivers > >>> can be added or removed if driver uses the module type. It is not a problem > >>> for only devfreq instance. > >> > >> Certainly it's not a problem limited to devfreq devices. In many other > >> cases bus notifiers can be used, but since devfreq devices areen't > >> tied to a specific bus this is not an option here. > >> > >> If you really don't want to export the class we could add wrappers > >> for (un)registering a class interface: > >> > >> int devfreq_class_interface_register(struct class_interface *) > >> void devfreq_class_interface_unregister(struct class_interface *) > > About this approach, I agree because it doesn't export the devfreq_class > instance as you commented. Great, I'll change it in the next revision!