From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink updates 2018-07-31 Date: Thu, 2 Aug 2018 08:15:03 +0200 Message-ID: <20180802061503.GA2021@nanopsycho> References: <20180801215255.6642-1-saeedm@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Duyck , Saeed Mahameed , "David S. Miller" , Netdev , Jiri Pirko , Jakub Kicinski , Bjorn Helgaas To: Saeed Mahameed Return-path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:52975 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726174AbeHBIHY (ORCPT ); Thu, 2 Aug 2018 04:07:24 -0400 Received: by mail-wm0-f45.google.com with SMTP id o11-v6so1093123wmh.2 for ; Wed, 01 Aug 2018 23:17:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Thu, Aug 02, 2018 at 01:13:20AM CEST, saeedm@dev.mellanox.co.il wrote: [...] >> >> So after looking over the patch set the one thing I would ask for in >> this is some sort of documentation at a minimum. As a user I don't see >> how you can expect someone to be able to use this when the naming of >> things are pretty cryptic and there is no real explanation anywhere if >> you don't go through and read the patch description itself. When you >> start adding driver specific interfaces, you should at least start >> adding vendor specific documentation. >> > >Sure, sounds like a great idea, something like: >Documentation/networking/mlx5.txt and have a devlink section ? >or have a generic devlink doc and a mlx5 section in it ? I think that Documentation/networking/devlink/mlx5.txt would be good. We can have generic param description in: Documentation/networking/devlink/generic.txt