From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Hao Date: Thu, 02 Aug 2018 08:40:42 +0000 Subject: Re: [PATCH] fpga: dfl: fme: error pointer vs NULL bug Message-Id: <20180802084042.GA3280@hao-dev> List-Id: References: <20180802082931.6nfcgaztkxbkrgh7@kili.mountain> In-Reply-To: <20180802082931.6nfcgaztkxbkrgh7@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Kang Luwei , Alan Tull , Moritz Fischer , linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Aug 02, 2018 at 11:29:31AM +0300, Dan Carpenter wrote: > The dfl_fme_create_region() function doesn't return NULL pointers, it > returns error pointers. Thanks for your patch. But it's the same fixing as below one. :) https://marc.info/?l=linux-fpga&m3200573532534&w=2 Hao > > Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c > index fc9fd2d0482f..0b840531ef33 100644 > --- a/drivers/fpga/dfl-fme-pr.c > +++ b/drivers/fpga/dfl-fme-pr.c > @@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev, > /* Create region for each port */ > fme_region = dfl_fme_create_region(pdata, mgr, > fme_br->br, i); > - if (!fme_region) { > + if (IS_ERR(fme_region)) { > ret = PTR_ERR(fme_region); > goto destroy_region; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-fpga" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Thu, 2 Aug 2018 16:40:42 +0800 From: Wu Hao Subject: Re: [PATCH] fpga: dfl: fme: error pointer vs NULL bug Message-ID: <20180802084042.GA3280@hao-dev> References: <20180802082931.6nfcgaztkxbkrgh7@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180802082931.6nfcgaztkxbkrgh7@kili.mountain> To: Dan Carpenter Cc: Kang Luwei , Alan Tull , Moritz Fischer , linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: On Thu, Aug 02, 2018 at 11:29:31AM +0300, Dan Carpenter wrote: > The dfl_fme_create_region() function doesn't return NULL pointers, it > returns error pointers. Thanks for your patch. But it's the same fixing as below one. :) https://marc.info/?l=linux-fpga&m=153200573532534&w=2 Hao > > Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c > index fc9fd2d0482f..0b840531ef33 100644 > --- a/drivers/fpga/dfl-fme-pr.c > +++ b/drivers/fpga/dfl-fme-pr.c > @@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev, > /* Create region for each port */ > fme_region = dfl_fme_create_region(pdata, mgr, > fme_br->br, i); > - if (!fme_region) { > + if (IS_ERR(fme_region)) { > ret = PTR_ERR(fme_region); > goto destroy_region; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-fpga" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html