From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [pull request][net-next 00/10] Mellanox, mlx5 and devlink
 updates 2018-07-31
Date: Thu, 2 Aug 2018 10:11:12 -0700
Message-ID: <20180802101112.78b1df4b@cakuba.netronome.com>
References: <20180801215255.6642-1-saeedm@mellanox.com>
        <20180801170047.687ce65c@cakuba.netronome.com>
        <20180801.184035.163038060223453766.davem@davemloft.net>
        <wihtvodxjc7.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, <saeedm@mellanox.com>,
        <netdev@vger.kernel.org>, <jiri@mellanox.com>,
        <alexander.duyck@gmail.com>, <helgaas@kernel.org>
To: Petr Machata <petrm@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f170.google.com ([209.85.210.170]:37735 "EHLO
        mail-pf1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727047AbeHBTDR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 2 Aug 2018 15:03:17 -0400
Received: by mail-pf1-f170.google.com with SMTP id a26-v6so1684019pfo.4
        for <netdev@vger.kernel.org>; Thu, 02 Aug 2018 10:11:16 -0700 (PDT)
In-Reply-To: <wihtvodxjc7.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 02 Aug 2018 11:29:12 +0300, Petr Machata wrote:
> David Miller <davem@davemloft.net> writes:
> 
> > From: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Date: Wed, 1 Aug 2018 17:00:47 -0700
> >  
> >> On Wed,  1 Aug 2018 14:52:45 -0700, Saeed Mahameed wrote:  
> >>> - According to the discussion outcome, we are keeping the congestion control
> >>>   setting as mlx5 device specific for the current HW generation.  
> >> 
> >> I still see queuing and marking based on queue level.  You want to add 
> >> a Qdisc that will mirror your HW's behaviour to offload, if you really
> >> believe this is not a subset of RED, why not...  But devlink params?  
> >
> > I totally agree, devlink seems like absolutely to wrong level and set
> > of interfaces to be doing this stuff.
> >
> > I will not pull these changes in and I probably should have not
> > accepted the DCB changes from the other day and they were sneakily
> > leading up to this crap.  
> 
> Are you talking about the recent additions of DCB helpers
> dcb_ieee_getapp_prio_dscp_mask_map() etc.?
> 
> If yes, I can assure there were no sneaky intentions at all. I'm at a
> loss to understand the relation to mlx5 team's decision to use devlink
> for congestion control configuration.
> 
> Could you please clarify your remark?

Oh, I think David meant the patches I was objecting to a while ago,
which were doing buffer configuration via the DCB API.