All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: dev@dpdk.org
Subject: [PATCH] net/mlx5: fix VLAN POP action on switch flow rules
Date: Thu, 2 Aug 2018 12:20:51 +0200	[thread overview]
Message-ID: <20180802101928.15510-1-adrien.mazarguil@6wind.com> (raw)

TC message for VLAN POP is broken due to an unfinished nested attribute.

Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow rules")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx5/mlx5_nl_flow.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/mlx5_nl_flow.c b/drivers/net/mlx5/mlx5_nl_flow.c
index 8803ffc32..a1c8c340b 100644
--- a/drivers/net/mlx5/mlx5_nl_flow.c
+++ b/drivers/net/mlx5/mlx5_nl_flow.c
@@ -991,6 +991,7 @@ mlx5_nl_flow_transpose(void *buf,
 			goto error_nobufs;
 		if (i == TCA_VLAN_ACT_POP) {
 			mnl_attr_nest_end(buf, act);
+			mnl_attr_nest_end(buf, act_index);
 			++action;
 			break;
 		}
-- 
2.11.0

             reply	other threads:[~2018-08-02 10:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 10:20 Adrien Mazarguil [this message]
2018-08-02 12:48 ` [PATCH] net/mlx5: fix VLAN POP action on switch flow rules Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802101928.15510-1-adrien.mazarguil@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.