All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajay Singh <ajay.kathat@microchip.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
	<venkateswara.kaja@microchip.com>, <ganesh.krishna@microchip.com>,
	<adham.abozaeid@microchip.com>, <aditya.shankar@microchip.com>
Subject: Re: [PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file
Date: Thu, 2 Aug 2018 13:54:15 +0530	[thread overview]
Message-ID: <20180802135415.17f126cc@ajaysk-VirtualBox> (raw)
In-Reply-To: <20180802073317.GA14107@kroah.com>

Hi Greg,

On Thu, 2 Aug 2018 09:33:17 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sun, Jul 29, 2018 at 11:36:52AM +0530, Ajay Singh wrote:
> > Cleanup patch to remove the unnecessary copyright information in
> > the file, as it already has SPDX License Identifier.
> > 
> > diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
> > b/drivers/staging/wilc1000/wilc_debugfs.c index ac26e94..d86f457
> > 100644 --- a/drivers/staging/wilc1000/wilc_debugfs.c
> > +++ b/drivers/staging/wilc1000/wilc_debugfs.c
> > @@ -1,14 +1,4 @@
> >  // SPDX-License-Identifier: GPL-2.0
> > -/*
> > - * NewportMedia WiFi chipset driver test tools - wilc-debug
> > - * Copyright (c) 2012 NewportMedia Inc.
> > - * Author: SSW <sswd@wilcsemic.com>  
> 
> No, you can not just drop copyright lines for no reason at all.  Did
> your lawyers approve this patch?
> 

Actually, I had planned to keep Microchip Copyright header for these
files later, as currently these files has the previous
company copyright information. 
I am not sure what will be right practice to either keep all
previous companies copyright or only the latest copyright information.

Its better to drop this for now and after consulting internally I will
submit the new patch.


> SPDX identifes the _license_ of the file, not the copyrights, so it is
> ok to drop these lines:
> 
> > - *
> > - * This program is free software; you can redistribute it and/or
> > modify
> > - * it under the terms of the GNU General Public License version 2
> > as
> > - * published by the Free Software Foundation.  
> 
> As that is what it is replacing.  But not the copyrights.
> 
> Go show your lawyer this patch:
> 
> > --- a/drivers/staging/wilc1000/wilc_sdio.c
> > +++ b/drivers/staging/wilc1000/wilc_sdio.c
> > @@ -1,9 +1,4 @@
> >  // SPDX-License-Identifier: GPL-2.0
> > -/*
> > - * Copyright (c) Atmel Corporation.  All rights reserved.  
> 
> And see what they do :)
> 
> (yes, explicit copyright notices are really not needed and do not do
> "much", but it is still the norm that they are present and our
> industry does still rely on them...)
> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2018-08-02 10:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-29  6:06 [PATCH 0/8] staging: wilc1000: changes to address TODO items Ajay Singh
2018-07-29  6:06 ` [PATCH 1/8] staging: wilc1000: fix TODO to compile spi and sdio components in single module Ajay Singh
2018-07-29  6:06 ` [PATCH 2/8] staging: wilc1000: remove unnecessary comments and comments description Ajay Singh
2018-07-29  6:06 ` [PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file Ajay Singh
2018-08-02  7:33   ` Greg KH
2018-08-02  8:24     ` Ajay Singh [this message]
2018-07-29  6:06 ` [PATCH 4/8] staging: wilc1000: modified debug log messages description Ajay Singh
2018-07-29  6:06 ` [PATCH 5/8] staging: wilc1000: added comments for 'hif_cs' mutex lock Ajay Singh
2018-07-29  6:06 ` [PATCH 6/8] staging: wilc1000: rename 'rcvd_ch_cnt' element in 'user_scan_req' struct Ajay Singh
2018-07-29  6:06 ` [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range Ajay Singh
2018-08-02  7:34   ` Greg KH
2018-08-03  8:28     ` Ajay Singh
2018-08-05 14:11       ` Greg KH
2018-08-04 15:37         ` Ajay Singh
2018-07-29  6:06 ` [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue Ajay Singh
2018-08-02  7:34   ` Greg KH
2018-08-02  8:26     ` Ajay Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802135415.17f126cc@ajaysk-VirtualBox \
    --to=ajay.kathat@microchip.com \
    --cc=adham.abozaeid@microchip.com \
    --cc=aditya.shankar@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=ganesh.krishna@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=venkateswara.kaja@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.