From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v4 30/32] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp Date: Thu, 2 Aug 2018 17:38:41 +0200 Message-ID: <20180802153841.jwb7lp52cath4y6g@mac> References: <20180727140614.13256-1-anthony.perard@citrix.com> <20180727140614.13256-31-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1flFgi-00007B-7B for xen-devel@lists.xenproject.org; Thu, 02 Aug 2018 15:38:52 +0000 Content-Disposition: inline In-Reply-To: <20180727140614.13256-31-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBKdWwgMjcsIDIwMTggYXQgMDM6MDY6MTJQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gK3N0YXRpYyB2b2lkIGRtX3N0b3BwZWQobGlieGxfX2VnYyAqZWdjLCBsaWJ4bF9f ZXZfcW1wICpldiwKPiArICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBsaWJ4bF9fanNvbl9v YmplY3QgKnJlc3BvbnNlLCBpbnQgcmMpCj4gK3sKPiArICAgIEVHQ19HQzsKPiArICAgIGxpYnhs X19kb21haW5fc3VzcGVuZF9zdGF0ZSAqZHNwcyA9IENPTlRBSU5FUl9PRihldiwgKmRzcHMsIHFt cCk7Cj4gKyAgICBjb25zdCBjaGFyICpjb25zdCBmaWxlbmFtZSA9IGRzcHMtPmRtX3NhdmVmaWxl Owo+ICsgICAgdWludDMyX3QgY29uc3QgZG9taWQgPSBldi0+ZG9taWQ7Cj4gKwo+ICsgICAgaWYg KHJjKQo+ICsgICAgICAgIGdvdG8gb3V0Owo+ICsKPiArICAgIGxpYnhsX19jYXJlZmRfYmVnaW4o KTsKPiArICAgIGV2LT5jZmQgPSBsaWJ4bF9fY2FyZWZkX29wZW5lZChDVFgsCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG9wZW4oZmlsZW5hbWUsIE9fV1JPTkxZIHwgT19DUkVB VCwgMDYwMCkpOwo+ICsgICAgaWYgKCFldi0+Y2ZkKSB7Cj4gKyAgICAgICAgTE9HRUQoRVJST1Is IGRvbWlkLCAiRmFpbGVkIHRvIG9wZW4gZmlsZSAlcyBmb3IgUUVNVSIsIGZpbGVuYW1lKTsKPiAr ICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gKyAgICAgICAgZ290byBvdXQ7Cj4gKyAgICB9Cj4g Kwo+ICsgICAgZXYtPmNhbGxiYWNrID0gZG1fc3RhdGVfZmRfcmVhZHk7Cj4gKyAgICByYyA9IGxp YnhsX19ldl9xbXBfc2VuZChnYywgZXYsICJhZGQtZmQiLCBOVUxMKTsKPiArICAgIGlmIChyYykK PiArICAgICAgICBnb3RvIG91dDsKPiArCj4gKyAgICByZXR1cm47Cj4gK291dDoKClRoYXQgbGFi ZWwgd291bGQgYmUgYmV0dGVyIG5hbWVkICdlcnJvcicsIGJlY2F1c2UgaXQncyBvbmx5IHVzZWQg Zm9yCnRoZSBlcnJvciBwYXRocy4KCj4gKyAgICBpZiAoZXYtPmNmZCkgewo+ICsgICAgICAgIGxp YnhsX19jYXJlZmRfY2xvc2UoZXYtPmNmZCk7Cj4gKyAgICAgICAgdW5saW5rKGZpbGVuYW1lKTsK PiArICAgICAgICBldi0+Y2ZkID0gTlVMTDsKPiArICAgIH0KPiArICAgIGRzcHMtPmNhbGxiYWNr X2RldmljZV9tb2RlbF9kb25lKGVnYywgZHNwcywgcmMpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9p ZCBkbV9zdGF0ZV9mZF9yZWFkeShsaWJ4bF9fZWdjICplZ2MsIGxpYnhsX19ldl9xbXAgKmV2LAo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBsaWJ4bF9fanNvbl9vYmplY3Qg KnJlc3BvbnNlLCBpbnQgcmMpCj4gK3sKPiArICAgIEVHQ19HQzsKPiArICAgIGxpYnhsX19kb21h aW5fc3VzcGVuZF9zdGF0ZSAqZHNwcyA9IENPTlRBSU5FUl9PRihldiwgKmRzcHMsIHFtcCk7Cj4g KyAgICBsaWJ4bF9fanNvbl9vYmplY3QgKmFyZ3MgPSBOVUxMOwo+ICsgICAgY29uc3QgbGlieGxf X2pzb25fb2JqZWN0ICpvOwo+ICsgICAgaW50IGZkc2V0Owo+ICsKPiArICAgIGxpYnhsX19jYXJl ZmRfY2xvc2UoZXYtPmNmZCk7Cj4gKyAgICBldi0+Y2ZkID0gTlVMTDsKPiArCj4gKyAgICBpZiAo cmMpCj4gKyAgICAgICAgZ290byBvdXQ7Cj4gKwo+ICsgICAgbyA9IGxpYnhsX19qc29uX21hcF9n ZXQoImZkc2V0LWlkIiwgcmVzcG9uc2UsIEpTT05fSU5URUdFUik7Cj4gKyAgICBpZiAoIW8pIHsK PiArICAgICAgICByYyA9IEVSUk9SX0ZBSUw7Cj4gKyAgICAgICAgZ290byBvdXQ7Cj4gKyAgICB9 Cj4gKyAgICBmZHNldCA9IGxpYnhsX19qc29uX29iamVjdF9nZXRfaW50ZWdlcihvKTsKPiArCj4g KyAgICBldi0+Y2FsbGJhY2sgPSBkbV9zdGF0ZV9zYXZlZDsKPiArCj4gKyAgICBpZiAocW1wX2V2 X3FlbXVfY2hlY2tfdmVyc2lvbihldiwgMiwgMTEsIDApKQo+ICsgICAgICAgIHFtcF9wYXJhbWV0 ZXJzX2FkZF9ib29sKGdjLCAmYXJncywgImxpdmUiLCBkc3BzLT5saXZlKTsKPiArICAgIFFNUF9Q QVJBTUVURVJTX1NQUklOVEYoJmFyZ3MsICJmaWxlbmFtZSIsICIvZGV2L2Zkc2V0LyVkIiwgZmRz ZXQpOwo+ICsgICAgcmMgPSBsaWJ4bF9fZXZfcW1wX3NlbmQoZ2MsIGV2LCAieGVuLXNhdmUtZGV2 aWNlcy1zdGF0ZSIsIGFyZ3MpOwoKSSB0aGluayBzb21lIGNvbW1lbnRzIGFib3V0IHRoZSBsb2dp YyBhYm92ZSB3b3VsZCBiZSBoZWxwZnVsIChhdCBsZWFzdApmb3IgbWUpLiBEbyB5b3UgbmVlZCB0 byBwYXNzIGFuIGV4dHJhIGFyZ3VtZW50IHRvIDIuMTEuMCBhbmQgaGlnaGVyCnZlcnNpb25zIGlu IG9yZGVyIHRvIGxpdmUtbWlncmF0ZT8KCj4gKyAgICBpZiAocmMpCj4gKyAgICAgICAgZ290byBv dXQ7Cj4gKwo+ICsgICAgcmV0dXJuOwo+ICtvdXQ6CgpTYW1lIGhlcmUgcmVnYXJkaW5nIHRoZSBu YW1pbmcgb2YgdGhlIGxhYmVsLgoKPiArICAgIGlmIChyYykKPiArICAgICAgICB1bmxpbmsoZHNw cy0+ZG1fc2F2ZWZpbGUpOwo+ICsgICAgZHNwcy0+Y2FsbGJhY2tfZGV2aWNlX21vZGVsX2RvbmUo ZWdjLCBkc3BzLCByYyk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGRtX3N0YXRlX3NhdmVkKGxp YnhsX19lZ2MgKmVnYywgbGlieGxfX2V2X3FtcCAqZXYsCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IGxpYnhsX19qc29uX29iamVjdCAqcmVzcG9uc2UsIGludCByYykKPiArewo+ ICsgICAgRUdDX0dDOwo+ICsgICAgbGlieGxfX2RvbWFpbl9zdXNwZW5kX3N0YXRlICpkc3BzID0g Q09OVEFJTkVSX09GKGV2LCAqZHNwcywgcW1wKTsKPiArCj4gKyAgICBpZiAocmMpCj4gKyAgICAg ICAgdW5saW5rKGRzcHMtPmRtX3NhdmVmaWxlKTsKClVzZSB0aGUgbGlieGwgdW5saW5rIGhlbHBl ci4KClRoYW5rcywgUm9nZXIuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9q ZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVu LWRldmVs