From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow Date: Thu, 2 Aug 2018 18:00:44 +0200 Message-ID: <20180802160044.GK19257@lunn.ch> References: <39b57ee542fc20a1c457c12e6011dc239dda8725.1533125016.git.joabreu@synopsys.com> <20180801152330.GE32125@lunn.ch> <6dae65da-699f-77c9-2f50-775c888b5a12@synopsys.com> <20180802140323.GB7462@lunn.ch> <9c9d9d73-5566-a432-4dad-91cd8f5267a9@synopsys.com> <20180802143638.GD7462@lunn.ch> <343454e6-f563-8f78-e874-aa9ff5af0b53@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, "David S. Miller" , Joao Pinto , Giuseppe Cavallaro , Alexandre Torgue To: Jose Abreu Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:54000 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387645AbeHBRwg (ORCPT ); Thu, 2 Aug 2018 13:52:36 -0400 Content-Disposition: inline In-Reply-To: <343454e6-f563-8f78-e874-aa9ff5af0b53@synopsys.com> Sender: netdev-owner@vger.kernel.org List-ID: > Looks like a plan. So, I will remove the adjust_link speed > selection for > 1g and the C45 support. I will leave the SS > selection in dwxgmac2_core_init (patch 2/9) as this makes no > difference because only 1g will be selected for now. I will also > clearly refer in cover letter the BW results for 1g tests. > > Later on I will add support for 10g once shipping arrives. > > Looks okay? Hi Jose Yes, this is good. Thanks Andrew