From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.bootlin.com ([62.4.15.54]:40655 "EHLO mail.bootlin.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728122AbeHCKGh (ORCPT <rfc822;stable@vger.kernel.org>);
        Fri, 3 Aug 2018 06:06:37 -0400
Date: Fri, 3 Aug 2018 10:11:26 +0200
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix the "no scaling" case on multi-planar YUV
 formats
Message-ID: <20180803101126.76282da6@bbrezillon>
In-Reply-To: <8760101jrs.fsf@anholt.net>
References: <20180725122907.13702-1-boris.brezillon@bootlin.com>
        <8760101jrs.fsf@anholt.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Fri, 27 Jul 2018 13:55:03 -0700
Eric Anholt <eric@anholt.net> wrote:

> Boris Brezillon <boris.brezillon@bootlin.com> writes:
> 
> > When there's no scaling requested ->is_unity should be true no matter
> > the format.
> >
> > Also, when no scaling is requested and we have a multi-planar YUV
> > format, we should leave ->y_scaling[0] to VC4_SCALING_NONE and only
> > set ->x_scaling[0] to VC4_SCALING_PPF.
> >
> > Doing this fixes an hardly visible artifact (seen when using modetest
> > and a rather big overlay plane in YUV420).
> >
> > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>  
> 
> Reviewed-by: Eric Anholt <eric@anholt.net>

Queued to drm-misc-fixes.